From: Masami Hiramatsu <mhiramat@redhat.com> To: Frederic Weisbecker <fweisbec@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, lkml <linux-kernel@vger.kernel.org> Cc: systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>, DLE <dle-develop@lists.sourceforge.net>, "Masami Hiramatsu" <mhiramat@redhat.com>, "Jim Keniston" <jkenisto@us.ibm.com>, "H. Peter Anvin" <hpa@zytor.com>, "Ananth N Mavinakayanahalli" <ananth@in.ibm.com>, "Avi Kivity" <avi@redhat.com>, "Andi Kleen" <ak@linux.intel.com>, "Christoph Hellwig" <hch@infradead.org>, "Frank Ch. Eigler" <fche@redhat.com>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Jason Baron" <jbaron@redhat.com>, "K.Prasad" <prasad@linux.vnet.ibm.com>, "Lai Jiangshan" <laijs@cn.fujitsu.com>, "Li Zefan" <lizf@cn.fujitsu.com>, PrzemysławPawełczyk <przemyslaw@pawelczyk.it>, "Roland McGrath" <roland@redhat.com>, "Sam Ravnborg" <sam@ravnborg.org>, "Srikar Dronamraju" <srikar@linux.vnet.ibm.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Tom Zanussi" <tzanussi@gmail.com>, "Vegard Nossum" <vegard.nossum@gmail.com> Subject: [PATCH tracing/kprobes 3/4] tracing/kprobes: Fix format typo in trace_kprobes Date: Fri, 21 Aug 2009 15:43:43 -0400 [thread overview] Message-ID: <20090821194343.12478.37618.stgit@localhost.localdomain> (raw) In-Reply-To: <20090821000108.GC6078@nowhere> Fix a format typo in kprobe-tracer. Currently, it shows 'tsize' in format; $ cat /debug/tracing/events/kprobes/event/format ... field: unsigned long ip; offset:16;tsize:8; field: int nargs; offset:24;tsize:4; ... This should be '\tsize'; $ cat /debug/tracing/events/kprobes/event/format ... field: unsigned long ip; offset:16; size:8; field: int nargs; offset:24; size:4; ... Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> Cc: Jim Keniston <jkenisto@us.ibm.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Avi Kivity <avi@redhat.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Frank Ch. Eigler <fche@redhat.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Jason Baron <jbaron@redhat.com> Cc: K.Prasad <prasad@linux.vnet.ibm.com> Cc: Lai Jiangshan <laijs@cn.fujitsu.com> Cc: Li Zefan <lizf@cn.fujitsu.com> Cc: Przemysław Pawełczyk <przemyslaw@pawelczyk.it> Cc: Roland McGrath <roland@redhat.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: Vegard Nossum <vegard.nossum@gmail.com> --- kernel/trace/trace_kprobe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 7cd726e..22e91c0 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -1069,7 +1069,7 @@ static int __probe_event_show_format(struct trace_seq *s, #define SHOW_FIELD(type, item, name) \ do { \ ret = trace_seq_printf(s, "\tfield: " #type " %s;\t" \ - "offset:%u;tsize:%u;\n", name, \ + "offset:%u;\tsize:%u;\n", name, \ (unsigned int)offsetof(typeof(field), item),\ (unsigned int)sizeof(type)); \ if (!ret) \ -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <mhiramat@redhat.com> To: Frederic Weisbecker <fweisbec@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, lkml<linux-kernel@vger.kernel.org> Cc: systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>, DLE <dle-develop@lists.sourceforge.net>, "Masami Hiramatsu" <mhiramat@redhat.com>, "Jim Keniston" <jkenisto@us.ibm.com>, "H. Peter Anvin" <hpa@zytor.com>, "Ananth N Mavinakayanahalli" <ananth@in.ibm.com>, "Avi Kivity" <avi@redhat.com>, "Andi Kleen" <ak@linux.intel.com>, "Christoph Hellwig" <hch@infradead.org>, "Frank Ch. Eigler" <fche@redhat.com>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Jason Baron" <jbaron@redhat.com>, "K.Prasad" <prasad@linux.vnet.ibm.com>, "Lai Jiangshan" <laijs@cn.fujitsu.com>, "Li Zefan" <lizf@cn.fujitsu.com>, PrzemysławPawełczyk <przemyslaw@pawelczyk.it>, "Roland McGrath" <roland@redhat.com>, "Sam Ravnborg" <sam@ravnborg.org> Subject: [PATCH tracing/kprobes 3/4] tracing/kprobes: Fix format typo in trace_kprobes Date: Fri, 21 Aug 2009 15:43:43 -0400 [thread overview] Message-ID: <20090821194343.12478.37618.stgit@localhost.localdomain> (raw) In-Reply-To: <20090821000108.GC6078@nowhere> Fix a format typo in kprobe-tracer. Currently, it shows 'tsize' in format; $ cat /debug/tracing/events/kprobes/event/format ... field: unsigned long ip; offset:16;tsize:8; field: int nargs; offset:24;tsize:4; ... This should be '\tsize'; $ cat /debug/tracing/events/kprobes/event/format ... field: unsigned long ip; offset:16; size:8; field: int nargs; offset:24; size:4; ... Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> Cc: Jim Keniston <jkenisto@us.ibm.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Avi Kivity <avi@redhat.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Frank Ch. Eigler <fche@redhat.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Jason Baron <jbaron@redhat.com> Cc: K.Prasad <prasad@linux.vnet.ibm.com> Cc: Lai Jiangshan <laijs@cn.fujitsu.com> Cc: Li Zefan <lizf@cn.fujitsu.com> Cc: Przemysław Pawełczyk <przemyslaw@pawelczyk.it> Cc: Roland McGrath <roland@redhat.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: Vegard Nossum <vegard.nossum@gmail.com> --- kernel/trace/trace_kprobe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 7cd726e..22e91c0 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -1069,7 +1069,7 @@ static int __probe_event_show_format(struct trace_seq *s, #define SHOW_FIELD(type, item, name) \ do { \ ret = trace_seq_printf(s, "\tfield: " #type " %s;\t" \ - "offset:%u;tsize:%u;\n", name, \ + "offset:%u;\tsize:%u;\n", name, \ (unsigned int)offsetof(typeof(field), item),\ (unsigned int)sizeof(type)); \ if (!ret) \ -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-08-21 19:41 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-08-13 20:34 [PATCH -tip v14 00/12] tracing: kprobe-based event tracer and x86 instruction decoder Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-13 20:34 ` [PATCH -tip v14 01/12] x86: instruction decoder API Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-19 23:42 ` Frederic Weisbecker 2009-08-20 0:21 ` Frederic Weisbecker 2009-08-20 15:03 ` Masami Hiramatsu 2009-08-20 15:03 ` Masami Hiramatsu 2009-08-20 15:25 ` Frederic Weisbecker 2009-08-20 16:16 ` Masami Hiramatsu 2009-08-20 16:16 ` Masami Hiramatsu 2009-08-20 18:07 ` Frederic Weisbecker 2009-08-20 19:01 ` Masami Hiramatsu 2009-08-20 19:01 ` Masami Hiramatsu 2009-08-20 20:14 ` Frederic Weisbecker 2009-08-20 14:42 ` Masami Hiramatsu 2009-08-20 14:42 ` Masami Hiramatsu 2009-08-20 14:46 ` Frederic Weisbecker 2009-08-13 20:34 ` [PATCH -tip v14 02/12] x86: x86 instruction decoder build-time selftest Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-13 20:34 ` [PATCH -tip v14 03/12] kprobes: checks probe address is instruction boudary on x86 Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-18 23:03 ` Frederic Weisbecker 2009-08-18 23:17 ` Masami Hiramatsu 2009-08-18 23:17 ` Masami Hiramatsu 2009-08-18 23:43 ` Frederic Weisbecker 2009-08-19 0:19 ` Masami Hiramatsu 2009-08-19 0:19 ` Masami Hiramatsu 2009-08-19 0:46 ` Frederic Weisbecker 2009-08-13 20:34 ` [PATCH -tip v14 04/12] kprobes: cleanup fix_riprel() using insn decoder " Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-13 20:34 ` [PATCH -tip v14 05/12] x86: add pt_regs register and stack access APIs Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-13 20:34 ` [PATCH -tip v14 06/12] tracing: ftrace dynamic ftrace_event_call support Masami Hiramatsu 2009-08-13 20:34 ` Masami Hiramatsu 2009-08-13 20:35 ` [PATCH -tip v14 07/12] tracing: Introduce TRACE_FIELD_ZERO() macro Masami Hiramatsu 2009-08-13 20:35 ` Masami Hiramatsu 2009-08-19 1:09 ` Frederic Weisbecker 2009-08-19 2:20 ` Masami Hiramatsu 2009-08-19 2:20 ` Masami Hiramatsu 2009-08-19 13:58 ` Frederic Weisbecker 2009-08-13 20:35 ` [PATCH -tip v14 08/12] tracing: add kprobe-based event tracer Masami Hiramatsu 2009-08-13 20:35 ` Masami Hiramatsu 2009-08-19 1:23 ` Frederic Weisbecker 2009-08-13 20:35 ` [PATCH -tip v14 09/12] tracing: Kprobe-tracer supports more than 6 arguments Masami Hiramatsu 2009-08-13 20:35 ` Masami Hiramatsu 2009-08-13 20:35 ` [PATCH -tip v14 10/12] tracing: Generate names for each kprobe event automatically Masami Hiramatsu 2009-08-13 20:35 ` Masami Hiramatsu 2009-08-13 20:35 ` [PATCH -tip v14 11/12] tracing: Kprobe tracer assigns new event ids for each event Masami Hiramatsu 2009-08-13 20:35 ` Masami Hiramatsu 2009-08-13 20:35 ` [PATCH -tip v14 12/12] tracing: Add kprobes event profiling interface Masami Hiramatsu 2009-08-13 20:35 ` Masami Hiramatsu 2009-08-13 20:57 ` [TOOL] kprobestest : Kprobe stress test tool Masami Hiramatsu 2009-08-13 20:57 ` Masami Hiramatsu 2009-08-20 18:43 ` Frederic Weisbecker 2009-08-20 19:45 ` Masami Hiramatsu 2009-08-20 19:45 ` Masami Hiramatsu 2009-08-21 0:01 ` Frederic Weisbecker 2009-08-21 1:00 ` Masami Hiramatsu 2009-08-21 1:00 ` Masami Hiramatsu 2009-08-21 19:43 ` [PATCH tracing/kprobes 1/4] x86: Fix x86 instruction decoder selftest to check only .text Masami Hiramatsu 2009-08-21 19:43 ` Masami Hiramatsu 2009-08-23 19:34 ` Frederic Weisbecker 2009-08-21 19:43 ` [PATCH tracing/kprobes 2/4] x86: Check awk features before generating inat-tables.c Masami Hiramatsu 2009-08-21 19:43 ` Masami Hiramatsu 2009-08-21 19:43 ` Masami Hiramatsu [this message] 2009-08-21 19:43 ` [PATCH tracing/kprobes 3/4] tracing/kprobes: Fix format typo in trace_kprobes Masami Hiramatsu 2009-08-21 19:43 ` [PATCH tracing/kprobes 4/4] tracing/kprobes: Change trace_arg to probe_arg Masami Hiramatsu 2009-08-21 19:43 ` Masami Hiramatsu 2009-08-13 20:59 ` [TOOL] c2kpe: C expression to kprobe event format converter Masami Hiramatsu 2009-08-13 20:59 ` Masami Hiramatsu 2009-08-13 21:05 ` Christoph Hellwig 2009-08-13 21:05 ` Christoph Hellwig 2009-08-30 19:50 ` Frederic Weisbecker 2009-08-31 4:14 ` Masami Hiramatsu 2009-08-31 4:14 ` Masami Hiramatsu 2009-08-31 22:14 ` Frederic Weisbecker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090821194343.12478.37618.stgit@localhost.localdomain \ --to=mhiramat@redhat.com \ --cc=ak@linux.intel.com \ --cc=ananth@in.ibm.com \ --cc=avi@redhat.com \ --cc=dle-develop@lists.sourceforge.net \ --cc=fche@redhat.com \ --cc=fweisbec@gmail.com \ --cc=hch@infradead.org \ --cc=hpa@zytor.com \ --cc=jbaron@redhat.com \ --cc=jkenisto@us.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=laijs@cn.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lizf@cn.fujitsu.com \ --cc=mingo@elte.hu \ --cc=prasad@linux.vnet.ibm.com \ --cc=przemyslaw@pawelczyk.it \ --cc=roland@redhat.com \ --cc=rostedt@goodmis.org \ --cc=sam@ravnborg.org \ --cc=srikar@linux.vnet.ibm.com \ --cc=systemtap@sources.redhat.com \ --cc=tzanussi@gmail.com \ --cc=vegard.nossum@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.