All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: nm@ti.com
Cc: linux-omap@vger.kernel.org
Subject: [PATCH 01/12] OMAP OPP: remove some unnecessary variables
Date: Thu, 17 Dec 2009 17:47:32 -0700	[thread overview]
Message-ID: <20091218004730.7694.17270.stgit@localhost.localdomain> (raw)
In-Reply-To: <20091218004617.7694.84525.stgit@localhost.localdomain>

No need to allocate new variables; the passed-in OPP list pointers do nicely
as iterators.
---
 arch/arm/plat-omap/include/plat/opp.h |    2 +
 arch/arm/plat-omap/opp.c              |   52 +++++++++++++++------------------
 2 files changed, 24 insertions(+), 30 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/opp.h b/arch/arm/plat-omap/include/plat/opp.h
index 5d5d21b..f340928 100644
--- a/arch/arm/plat-omap/include/plat/opp.h
+++ b/arch/arm/plat-omap/include/plat/opp.h
@@ -60,7 +60,7 @@ unsigned long opp_get_freq(const struct omap_opp *opp);
  * This functions returns the number of opps if there are any OPPs enabled,
  * else returns corresponding error value.
  */
-int opp_get_opp_count(const struct omap_opp *oppl);
+int opp_get_opp_count(struct omap_opp *oppl);
 
 /**
  * opp_find_freq_exact() - search for an exact frequency
diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
index c4dc07b..4c581c7 100644
--- a/arch/arm/plat-omap/opp.c
+++ b/arch/arm/plat-omap/opp.c
@@ -62,21 +62,19 @@ unsigned long opp_get_freq(const struct omap_opp *opp)
 	return opp->rate;
 }
 
-int opp_get_opp_count(const struct omap_opp *oppl)
+int opp_get_opp_count(struct omap_opp *oppl)
 {
-	struct omap_opp *opp;
 	u8 n = 0;
 
 	if (unlikely(!oppl || IS_ERR(oppl))) {
 		pr_err("%s: Invalid parameters being passed\n", __func__);
 		return -EINVAL;
 	}
-	opp = (struct omap_opp *)oppl;
-	opp++;			/* skip initial terminator */
-	while (!OPP_TERM(opp)) {
-		if (opp->enabled)
+	oppl++;			/* skip initial terminator */
+	while (!OPP_TERM(oppl)) {
+		if (oppl->enabled)
 			n++;
-		opp++;
+		oppl++;
 	}
 	return n;
 }
@@ -84,54 +82,50 @@ int opp_get_opp_count(const struct omap_opp *oppl)
 struct omap_opp *opp_find_freq_exact(struct omap_opp *oppl,
 				     unsigned long freq, bool enabled)
 {
-	struct omap_opp *opp = (struct omap_opp *)oppl;
-
 	if (unlikely(!oppl || IS_ERR(oppl))) {
 		pr_err("%s: Invalid parameters being passed\n", __func__);
 		return ERR_PTR(-EINVAL);
 	}
 	/* skip initial terminator */
-	if (OPP_TERM(opp))
-		opp++;
-	while (!OPP_TERM(opp)) {
-		if ((opp->rate == freq) && (opp->enabled == enabled))
+	if (OPP_TERM(oppl))
+		oppl++;
+	while (!OPP_TERM(oppl)) {
+		if ((oppl->rate == freq) && (oppl->enabled == enabled))
 			break;
-		opp++;
+		oppl++;
 	}
 
-	return OPP_TERM(opp) ? ERR_PTR(-ENOENT) : opp;
+	return OPP_TERM(oppl) ? ERR_PTR(-ENOENT) : oppl;
 }
 
 struct omap_opp *opp_find_freq_approx(struct omap_opp *oppl,
 				      unsigned long *freq, u8 dir_flag)
 {
-	struct omap_opp *opp = (struct omap_opp *)oppl;
-
 	if (unlikely(!oppl || IS_ERR(oppl) || !freq || IS_ERR(freq))) {
 		pr_err("%s: Invalid parameters being passed\n", __func__);
 		return ERR_PTR(-EINVAL);
 	}
 	/* skip initial terminator */
-	if (OPP_TERM(opp)) {
-		opp++;
+	if (OPP_TERM(oppl)) {
+		oppl++;
 		/* If searching init list for a high val, skip to very top */
 		if (dir_flag == OPP_SEARCH_LOW)
-			while (!OPP_TERM(opp + 1))
-				opp++;
+			while (!OPP_TERM(oppl + 1))
+				oppl++;
 	}
-	while (!OPP_TERM(opp)) {
-		if (opp->enabled &&
-		    (((dir_flag == OPP_SEARCH_HIGH) && (opp->rate >= *freq)) ||
-		     ((dir_flag == OPP_SEARCH_LOW) && (opp->rate <= *freq))))
+	while (!OPP_TERM(oppl)) {
+		if (oppl->enabled &&
+		    (((dir_flag == OPP_SEARCH_HIGH) && (oppl->rate >= *freq)) ||
+		     ((dir_flag == OPP_SEARCH_LOW) && (oppl->rate <= *freq))))
 			break;
-		opp += (dir_flag == OPP_SEARCH_LOW) ? -1 : 1;
+		oppl += (dir_flag == OPP_SEARCH_LOW) ? -1 : 1;
 	}
 
-	if (OPP_TERM(opp))
+	if (OPP_TERM(oppl))
 		return ERR_PTR(-ENOENT);
 
-	*freq = opp->rate;
-	return opp;
+	*freq = oppl->rate;
+	return oppl;
 }
 
 /* wrapper to reuse converting opp_def to opp struct */



       reply	other threads:[~2009-12-18  0:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091218004617.7694.84525.stgit@localhost.localdomain>
2009-12-18  0:47 ` Paul Walmsley [this message]
2009-12-18 17:28   ` [PATCH 01/12] OMAP OPP: remove some unnecessary variables Kevin Hilman
2009-12-18  0:47 ` [PATCH 02/12] OMAP OPP: split opp_find_freq_approx() into opp_find_freq_{floor, ceil}() Paul Walmsley
2009-12-18  0:47 ` [PATCH 03/12] OMAP OPP: only traverse opp_find_freq_floor() once Paul Walmsley
2009-12-19 12:10   ` Menon, Nishanth
2009-12-18  0:47 ` [PATCH 04/12] OMAP TWL/TPS OPP: move TWL/TPS-specific code to its own file Paul Walmsley
2009-12-19 12:14   ` Menon, Nishanth
2009-12-18  0:47 ` [PATCH 05/12] OMAP TWL/TPS OPP: vsel rounding belongs in opp_twl_tps.c Paul Walmsley
2009-12-19 12:16   ` Menon, Nishanth
2009-12-18  0:47 ` [PATCH 07/12] OMAP OPP: add opp_find_opp_by_opp_id() Paul Walmsley
2009-12-18  0:47 ` [PATCH 06/12] OMAP OPP: add microvolts DC ("u_volt") field into struct omap_opp Paul Walmsley
2009-12-18  0:47 ` [PATCH 08/12] OMAP SR/SRF: use opp_find_opp_by_opp_id() Paul Walmsley
2009-12-18  0:47 ` [PATCH 09/12] OMAP OPP: remove vsel Paul Walmsley
2009-12-18  0:47 ` [PATCH 10/12] OMAP OPP: remove "initial terminators" from OPP lists Paul Walmsley
2009-12-18 19:08   ` Kevin Hilman
2009-12-18  0:47 ` [PATCH 11/12] OMAP OPP: use kzalloc() rather than kmalloc() Paul Walmsley
2009-12-18  0:47 ` [PATCH 12/12] OMAP3 OPP: move CPUFreq table init code to OPP layer Paul Walmsley
2009-12-19 12:22   ` Menon, Nishanth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091218004730.7694.17270.stgit@localhost.localdomain \
    --to=paul@pwsan.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.