From: Carlos Corbacho <carlos@strangeworlds.co.uk> To: Larry Finger <Larry.Finger@lwfinger.net> Cc: Matthew Garrett <mjg@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Linux ACPI <linux-acpi@vger.kernel.org>, lenb@kernel.org Subject: [PATCH] ACPI: WMI: Handle duplicate GUIDs Date: Sat, 26 Dec 2009 19:14:59 +0000 [thread overview] Message-ID: <200912261914.59515.carlos@strangeworlds.co.uk> (raw) In-Reply-To: <4B365E56.9030302@lwfinger.net> It would appear that in BIOS's with nVidia hooks, the GUID 05901221-D566-11D1-B2F0-00A0C9062910 is duplicated. For now, the simplest solution is to just ignore any duplicate GUIDs. These particular hooks are not currently supported/ used in the kernel, so whoever does that can figure out what the 'right' solution should be (if there's a better one). Fixes kernel bugzilla #14846 Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk> Reported-by: Larry Finger <Larry.Finger@lwfinger.net> Reported-by: Oldřich Jedlička <oldium.pro@seznam.cz> --- Len, Can you get this out ASAP, as it fixes a regression with the WMI autoloading code. drivers/platform/x86/wmi.c | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 9f93d6c..845aaf6 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -716,6 +716,22 @@ static int wmi_class_init(void) return ret; } +static bool guid_already_parsed(const char *guid_string) { + struct guid_block *gblock; + struct wmi_block *wblock; + struct list_head *p; + + list_for_each(p, &wmi_blocks.list) { + wblock = list_entry(p, struct wmi_block, list); + gblock = &wblock->gblock; + + if (strncmp(gblock->guid, guid_string, 16) == 0) { + return true; + } + } + return false; +} + /* * Parse the _WDG method for the GUID data blocks */ @@ -725,6 +741,7 @@ static __init acpi_status parse_wdg(acpi_handle handle) union acpi_object *obj; struct guid_block *gblock; struct wmi_block *wblock; + char guid_string[37]; acpi_status status; u32 i, total; @@ -747,6 +764,19 @@ static __init acpi_status parse_wdg(acpi_handle handle) memcpy(gblock, obj->buffer.pointer, obj->buffer.length); for (i = 0; i < total; i++) { + /* + Some WMI devices, like those for nVidia hooks, have a + duplicate GUID. It's not clear what we should do in this + case yet, so for now, we'll just ignore the duplicate. + Anyone who wants to add support for that device can come + up with a better workaround for the mess then. + */ + if (guid_already_parsed(gblock[i].guid) == true) { + wmi_gtoa(gblock[i].guid, guid_string); + printk(KERN_INFO PREFIX "Skipping duplicate GUID %s\n", + guid_string); + continue; + } wblock = kzalloc(sizeof(struct wmi_block), GFP_KERNEL); if (!wblock) return AE_NO_MEMORY; -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Carlos Corbacho <carlos@strangeworlds.co.uk> To: Larry Finger <Larry.Finger@lwfinger.net> Cc: Matthew Garrett <mjg@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Linux ACPI <linux-acpi@vger.kernel.org>, lenb@kernel.org Subject: [PATCH] ACPI: WMI: Handle duplicate GUIDs Date: Sat, 26 Dec 2009 19:14:59 +0000 [thread overview] Message-ID: <200912261914.59515.carlos@strangeworlds.co.uk> (raw) In-Reply-To: <4B365E56.9030302@lwfinger.net> It would appear that in BIOS's with nVidia hooks, the GUID 05901221-D566-11D1-B2F0-00A0C9062910 is duplicated. For now, the simplest solution is to just ignore any duplicate GUIDs. These particular hooks are not currently supported/ used in the kernel, so whoever does that can figure out what the 'right' solution should be (if there's a better one). Fixes kernel bugzilla #14846 Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk> Reported-by: Larry Finger <Larry.Finger@lwfinger.net> Reported-by: Oldřich Jedlička <oldium.pro@seznam.cz> --- Len, Can you get this out ASAP, as it fixes a regression with the WMI autoloading code. drivers/platform/x86/wmi.c | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 9f93d6c..845aaf6 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -716,6 +716,22 @@ static int wmi_class_init(void) return ret; } +static bool guid_already_parsed(const char *guid_string) { + struct guid_block *gblock; + struct wmi_block *wblock; + struct list_head *p; + + list_for_each(p, &wmi_blocks.list) { + wblock = list_entry(p, struct wmi_block, list); + gblock = &wblock->gblock; + + if (strncmp(gblock->guid, guid_string, 16) == 0) { + return true; + } + } + return false; +} + /* * Parse the _WDG method for the GUID data blocks */ @@ -725,6 +741,7 @@ static __init acpi_status parse_wdg(acpi_handle handle) union acpi_object *obj; struct guid_block *gblock; struct wmi_block *wblock; + char guid_string[37]; acpi_status status; u32 i, total; @@ -747,6 +764,19 @@ static __init acpi_status parse_wdg(acpi_handle handle) memcpy(gblock, obj->buffer.pointer, obj->buffer.length); for (i = 0; i < total; i++) { + /* + Some WMI devices, like those for nVidia hooks, have a + duplicate GUID. It's not clear what we should do in this + case yet, so for now, we'll just ignore the duplicate. + Anyone who wants to add support for that device can come + up with a better workaround for the mess then. + */ + if (guid_already_parsed(gblock[i].guid) == true) { + wmi_gtoa(gblock[i].guid, guid_string); + printk(KERN_INFO PREFIX "Skipping duplicate GUID %s\n", + guid_string); + continue; + } wblock = kzalloc(sizeof(struct wmi_block), GFP_KERNEL); if (!wblock) return AE_NO_MEMORY;
next prev parent reply other threads:[~2009-12-26 19:15 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-12-25 20:48 Regression in module wmi since 2.6.32 (bisected to commit 1caab3c) Larry Finger 2009-12-25 20:56 ` Carlos Corbacho 2009-12-25 21:35 ` Larry Finger 2009-12-25 21:58 ` Carlos Corbacho 2009-12-25 22:09 ` Larry Finger 2009-12-26 1:18 ` Carlos Corbacho 2009-12-26 1:36 ` Dmitry Torokhov 2009-12-26 15:32 ` Larry Finger 2009-12-26 18:36 ` Carlos Corbacho 2009-12-26 19:04 ` Larry Finger 2009-12-26 19:14 ` Carlos Corbacho [this message] 2009-12-26 19:14 ` [PATCH] ACPI: WMI: Handle duplicate GUIDs Carlos Corbacho 2009-12-26 19:42 ` Len Brown 2010-01-06 15:27 ` Regression in module wmi since 2.6.32 (bisected to commit 1caab3c) Matthew Garrett
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=200912261914.59515.carlos@strangeworlds.co.uk \ --to=carlos@strangeworlds.co.uk \ --cc=Larry.Finger@lwfinger.net \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mjg@redhat.com \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.