From: Josef Bacik <josef@redhat.com>
To: Tomas Carnecky <tomas.carnecky@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Bug in btrfs_rename (kernel BUG at fs/btrfs/inode.c:5595!)
Date: Wed, 13 Jan 2010 15:13:18 -0500 [thread overview]
Message-ID: <20100113201317.GC2774@dhcp231-156.rdu.redhat.com> (raw)
In-Reply-To: <4B4E1A5D.1070203@gmail.com>
On Wed, Jan 13, 2010 at 08:09:17PM +0100, Tomas Carnecky wrote:
> I was running v2.6.33-rc2-187-g08d869a and everything was ok. Today I
> decided to update the kernel (to v2.6.33-rc4) and a minute or two after
> logging into the gnome desktop this kernel bug appeared in dmesg. I then
> went back to the old kernel but the bug didn't disappear, not even after
> running btrfsck on the filesystem.
>
Ok will you please run with this patch? It shouldn't panic your box, since it
seems ret is -EEXIST. Just watch your logs for
OH NO, ORPHAN ENTRY ALREADY EXISTS FOR <number>
and then look up and find all occurances of
Btrfs: orphan add <number>
with the stack trace and send it back to me so I can verify that nothing heinous
is happening. I assume we're just racing with unlink/rename so all that needs
to be done is to take that BUG_ON out, but it would be nice to know for sure.
Thanks,
Josef
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 5440bab..68fc2e0 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -2096,6 +2096,13 @@ int btrfs_orphan_add(struct btrfs_trans_handle *trans, struct inode *inode)
*/
ret = btrfs_insert_orphan_item(trans, root, inode->i_ino);
+ printk(KERN_ERR "Btrfs: orphan add %llu\n", (unsigned long long)inode->i_ino);
+ dump_stack();
+ if (ret) {
+ printk(KERN_ERR "OH NO, ORPHAN ENTRY ALREADY EXISTS FOR %llu\n",
+ (unsigned long long)inode->i_ino);
+ }
+
return ret;
}
@@ -5592,7 +5599,7 @@ static int btrfs_rename(struct inode *old_dir, struct dentry *old_dentry,
BUG_ON(ret);
if (new_inode->i_nlink == 0) {
ret = btrfs_orphan_add(trans, new_dentry->d_inode);
- BUG_ON(ret);
+ BUG_ON(ret && ret != -EEXIST);
}
}
next prev parent reply other threads:[~2010-01-13 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 19:09 Bug in btrfs_rename (kernel BUG at fs/btrfs/inode.c:5595!) Tomas Carnecky
2010-01-13 20:13 ` Josef Bacik [this message]
2010-01-13 20:11 ` Tomas Carnecky
2010-01-14 17:03 ` Josef Bacik
2010-01-14 19:00 ` Josef Bacik
2010-01-14 20:20 ` Yan, Zheng
2010-01-14 23:59 ` Tomas Carnecky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113201317.GC2774@dhcp231-156.rdu.redhat.com \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=tomas.carnecky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.