All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Cory Maccarrone <darkstar6262@gmail.com>
Cc: linux-omap@vger.kernel.org, miknix@gmail.com,
	a.j.buxton@gmail.com, linwizard-devel@lists.sf.net
Subject: Re: Commit 0c8219f0... breaks omap7xx support
Date: Mon, 15 Mar 2010 12:08:43 -0700	[thread overview]
Message-ID: <20100315190842.GZ2900@atomide.com> (raw)
In-Reply-To: <20100315182939.GV2900@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

* Tony Lindgren <tony@atomide.com> [100315 11:35]:
> * Cory Maccarrone <darkstar6262@gmail.com> [100309 15:38]:
> > On Tue, Mar 9, 2010 at 7:56 AM, Tony Lindgren <tony@atomide.com> wrote:
> > >
> > > Does your system boot without any patches if DEBUG_LL is not set
> > > in your .config?
> > 
> > No, it doesn't.  Seems like the debugging code is still trying to run,
> > even disabled.  If I add in that check, it'll boot with DEBUG_LL not
> > set, but won't without that.
> 
> Sorry for the delay on this. How about with the following patch with
> DEBUG_LL not set?
> 
> Note that this is using the shift register now too.

Then we may want to do this too for the boards that don't have any UART.

Tony

[-- Attachment #2: debug-ll-no-serial.patch --]
[-- Type: text/x-diff, Size: 1106 bytes --]

>From b33f67e61cc45558cfbda86b3e2032ffbcb2f99c Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Mon, 15 Mar 2010 10:47:08 -0700
Subject: [PATCH] omap: Fix uncompress code for boards with no UART

With the recent DEBUG_LL and uncompress code changes, boards
with no UART configured fail to boot as pointed out by
Cory Maccarrone <darkstar6262@gmail.com>.

Some boards may not have UARTs available at all, so add
DEBUG_LL_NONE option for that.

Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/arch/arm/plat-omap/include/plat/uncompress.h b/arch/arm/plat-omap/include/plat/uncompress.h
index dc37b2c..7d69d39 100644
--- a/arch/arm/plat-omap/include/plat/uncompress.h
+++ b/arch/arm/plat-omap/include/plat/uncompress.h
@@ -66,6 +66,13 @@ static inline void flush(void)
 /*
  * Macros to configure UART1 and debug UART
  */
+
+#define DEBUG_LL_NONE(mach)						\
+	if (machine_is_##mach()) {					\
+		uart_base = 0;						\
+		break;							\
+	}
+
 #define _DEBUG_LL_ENTRY(mach, uart1_phys, uart1_shft,			\
 			dbg_uart, dbg_shft, dbg_id)			\
 	if (machine_is_##mach()) {					\

  reply	other threads:[~2010-03-15 19:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-07  4:56 Commit 0c8219f0... breaks omap7xx support Cory Maccarrone
2010-03-09  0:48 ` Tony Lindgren
2010-03-09  1:51   ` Cory Maccarrone
2010-03-09  2:46     ` Tony Lindgren
2010-03-09  3:06       ` Cory Maccarrone
2010-03-09 15:56         ` Tony Lindgren
2010-03-09 23:41           ` Cory Maccarrone
2010-03-15 18:29             ` Tony Lindgren
2010-03-15 19:08               ` Tony Lindgren [this message]
2010-05-29  4:01               ` Cory Maccarrone
2010-05-31  8:21                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315190842.GZ2900@atomide.com \
    --to=tony@atomide.com \
    --cc=a.j.buxton@gmail.com \
    --cc=darkstar6262@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linwizard-devel@lists.sf.net \
    --cc=miknix@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.