From: Jason Wang <jasowang@redhat.com>
To: lmr@redhat.com, autotest@test.kernel.org
Cc: kvm@vger.kernel.org, mst@redhat.com
Subject: [V2 PATCH 1/2] KVM test: Use -device to add nic device when possible
Date: Sun, 26 Sep 2010 10:28:22 +0800 [thread overview]
Message-ID: <20100926022822.5641.15310.stgit@dhcp-91-158.nay.redhat.com> (raw)
This patch tries to use "-device" to add nic device becuase recent qemu suggest
to use it. A nic_extra_params was also introduced to add some advanced params to
a nic (currently only availabe for virtio_net) such as mrg_rxbuf.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
client/tests/kvm/kvm_vm.py | 28 +++++++++++++++++++++-------
client/tests/kvm/tests_base.cfg.sample | 2 ++
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
index 135d08e..644903b 100755
--- a/client/tests/kvm/kvm_vm.py
+++ b/client/tests/kvm/kvm_vm.py
@@ -234,13 +234,26 @@ class VM:
if boot: cmd += ",boot=on"
return cmd
- def add_nic(help, vlan, model=None, mac=None, netdev_id=None):
- if has_option(help, "netdev"):
- cmd = " -net nic,netdev=%s" % netdev_id
+ def add_nic(help, vlan, model=None, mac=None, netdev_id=None,
+ nic_extra_params=None):
+ if has_option(help, "device"):
+ if model == "virtio": model="virtio-net-pci"
+ if not model: model= "rtl8139"
+ cmd = " -device %s" % model
+ if mac: cmd += ",mac=%s" % mac
+ if has_option(help, "netdev"):
+ cmd += ",netdev=%s" % netdev_id
+ else:
+ cmd += "vlan=%d," % vlan
+ if nic_extra_params:
+ cmd += ",%s" % nic_extra_params
else:
- cmd = " -net nic,vlan=%d" % vlan
- if model: cmd += ",model=%s" % model
- if mac: cmd += ",macaddr='%s'" % mac
+ if has_option(help, "netdev"):
+ cmd = " -net nic,netdev=%s" % netdev_id
+ else:
+ cmd = " -net nic,vlan=%d" % vlan
+ if model: cmd += ",model=%s" % model
+ if mac: cmd += ",macaddr='%s'" % mac
return cmd
def add_net(help, vlan, mode, ifname=None, script=None,
@@ -388,7 +401,8 @@ class VM:
if "address_index" in nic_params:
mac = kvm_utils.get_mac_ip_pair_from_dict(nic_params)[0]
qemu_cmd += add_nic(help, vlan, nic_params.get("nic_model"), mac,
- self.netdev_id[vlan])
+ self.netdev_id[vlan],
+ nic_params.get("nic_extra_params"))
# Handle the '-net tap' or '-net user' part
script = nic_params.get("nic_script")
downscript = nic_params.get("nic_downscript")
diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index c8fbf50..89e6f45 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -618,6 +618,8 @@ variants:
nic_model = e1000
- virtio_net:
nic_model = virtio
+ # you can add advanced attributes here
+ # nic_extra_params =
# Guests
next reply other threads:[~2010-09-26 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 2:28 Jason Wang [this message]
2010-09-26 2:28 ` [V2 PATCH 2/2] KVM test: Add vhost-net support Jason Wang
2010-10-08 15:19 ` Lucas Meneghel Rodrigues
2010-10-08 15:23 ` Lucas Meneghel Rodrigues
2010-10-09 1:46 ` Jason Wang
2010-10-11 14:12 ` Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926022822.5641.15310.stgit@dhcp-91-158.nay.redhat.com \
--to=jasowang@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lmr@redhat.com \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.