From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Richard Zhao <richard.zhao@freescale.com>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] ARM: imx: move selection between i.MX21 and i.MX27 to CPU family choice
Date: Fri, 4 Mar 2011 23:28:16 +0100 [thread overview]
Message-ID: <20110304222816.GZ22310@pengutronix.de> (raw)
In-Reply-To: <20110304081916.GB29521@pengutronix.de>
[added linux-kbuild to Cc:]
Hello,
yet another reply to your mail, the last one for today, I promise.
> +config ARCH_IMX_MULTI_OMX27
> + select ARCH_ALLOW_IMX27
> + bool "i.MX27 support"
s/OMX/IMX/
Other than that is works. One ugly thing about that patch is that when
starting with
│ *** enable ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR to get *** │
│ *** support for multiple i.MX Families *** │
│ Select i.MX CPU (i.MX27 support) ---> │
│ *** MX27 platforms: *** │
│ [*] MX27ADS platform │
│ [*] Phytec phyCORE-i.MX27 CPU module (pcm038) │
and then enabling ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR this yields
│ [ ] i.MX1 support (NEW) │
│ [ ] i.MX21 support (NEW) │
│ [ ] i.MX25 support (NEW) │
│ [ ] i.MX27 support (NEW) │
│ [ ] i.MX31 and i.MX35 support (NEW) │
.
At least the machines enabled before are reselected when enabling "i.MX27
support". Still it would be nice if "i.MX27 support" would be
autoselected in this case. Any ideas?
[For those that didn't see Sascha's patch, the construct in
arch/arm/mach-imx/Kconfig is:
config ARCH_ALLOW_IMX1
bool
config ARCH_ALLOW_IMX21
bool
...
if ARM_PATCH_PHYS_VIRT && AUTO_ZRELADDR
config ARCH_IMX_MULTI_IMX1
select ARCH_ALLOW_IMX1
bool "i.MX1 support"
config ARCH_IMX_MULTI_IMX21
select ARCH_ALLOW_IMX21
bool "i.MX21 support"
...
endif
if !(ARM_PATCH_PHYS_VIRT && AUTO_ZRELADDR)
choice
prompt "Select i.MX CPU"
config ARCH_IMX_ONLY_IMX1
select ARCH_ALLOW_IMX1
bool "i.MX1 support"
config ARCH_IMX_ONLY_IMX21
select ARCH_ALLOW_IMX21
bool "i.MX21 support"
...
endchoice
endif
]
I merged Sascha's patch into my "move mach-mx3/* to mach-imx" series;
the tree is provided at
git://git.pengutronix.de/git/ukl/linux-2.6.git multi-soc-kernel
. As this tree doesn't contain ARM_PATCH_PHYS_VIRT yet, I tested the UI
with the patch below.
Best regards
Uwe
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index cfc398a..f5e0638 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -106,6 +106,9 @@ config ARCH_ALLOW_IMX31
config ARCH_ALLOW_IMX35
bool
+config ARM_PATCH_PHYS_VIRT
+ bool "testme"
+
if ARM_PATCH_PHYS_VIRT && AUTO_ZRELADDR
config ARCH_IMX_MULTI_IMX1
select ARCH_ALLOW_IMX1
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: move selection between i.MX21 and i.MX27 to CPU family choice
Date: Fri, 4 Mar 2011 23:28:16 +0100 [thread overview]
Message-ID: <20110304222816.GZ22310@pengutronix.de> (raw)
In-Reply-To: <20110304081916.GB29521@pengutronix.de>
[added linux-kbuild to Cc:]
Hello,
yet another reply to your mail, the last one for today, I promise.
> +config ARCH_IMX_MULTI_OMX27
> + select ARCH_ALLOW_IMX27
> + bool "i.MX27 support"
s/OMX/IMX/
Other than that is works. One ugly thing about that patch is that when
starting with
? *** enable ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR to get *** ?
? *** support for multiple i.MX Families *** ?
? Select i.MX CPU (i.MX27 support) ---> ?
? *** MX27 platforms: *** ?
? [*] MX27ADS platform ?
? [*] Phytec phyCORE-i.MX27 CPU module (pcm038) ?
and then enabling ARM_PATCH_PHYS_VIRT and AUTO_ZRELADDR this yields
? [ ] i.MX1 support (NEW) ?
? [ ] i.MX21 support (NEW) ?
? [ ] i.MX25 support (NEW) ?
? [ ] i.MX27 support (NEW) ?
? [ ] i.MX31 and i.MX35 support (NEW) ?
.
At least the machines enabled before are reselected when enabling "i.MX27
support". Still it would be nice if "i.MX27 support" would be
autoselected in this case. Any ideas?
[For those that didn't see Sascha's patch, the construct in
arch/arm/mach-imx/Kconfig is:
config ARCH_ALLOW_IMX1
bool
config ARCH_ALLOW_IMX21
bool
...
if ARM_PATCH_PHYS_VIRT && AUTO_ZRELADDR
config ARCH_IMX_MULTI_IMX1
select ARCH_ALLOW_IMX1
bool "i.MX1 support"
config ARCH_IMX_MULTI_IMX21
select ARCH_ALLOW_IMX21
bool "i.MX21 support"
...
endif
if !(ARM_PATCH_PHYS_VIRT && AUTO_ZRELADDR)
choice
prompt "Select i.MX CPU"
config ARCH_IMX_ONLY_IMX1
select ARCH_ALLOW_IMX1
bool "i.MX1 support"
config ARCH_IMX_ONLY_IMX21
select ARCH_ALLOW_IMX21
bool "i.MX21 support"
...
endchoice
endif
]
I merged Sascha's patch into my "move mach-mx3/* to mach-imx" series;
the tree is provided at
git://git.pengutronix.de/git/ukl/linux-2.6.git multi-soc-kernel
. As this tree doesn't contain ARM_PATCH_PHYS_VIRT yet, I tested the UI
with the patch below.
Best regards
Uwe
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index cfc398a..f5e0638 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -106,6 +106,9 @@ config ARCH_ALLOW_IMX31
config ARCH_ALLOW_IMX35
bool
+config ARM_PATCH_PHYS_VIRT
+ bool "testme"
+
if ARM_PATCH_PHYS_VIRT && AUTO_ZRELADDR
config ARCH_IMX_MULTI_IMX1
select ARCH_ALLOW_IMX1
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-03-04 22:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 3:28 [RFC PATCH 1/1] ARM: imx5x: clean up ARCH_MX5X Richard Zhao
2011-03-02 9:54 ` Shawn Guo
2011-03-02 11:25 ` Uwe Kleine-König
2011-03-02 16:06 ` Richard Zhao
2011-03-02 16:33 ` Uwe Kleine-König
2011-03-03 6:17 ` Richard Zhao
2011-03-02 17:23 ` [PATCH] ARM: imx: move selection between i.MX21 and i.MX27 to CPU family choice Uwe Kleine-König
2011-03-03 5:26 ` Richard Zhao
2011-03-03 10:02 ` Uwe Kleine-König
2011-03-03 12:11 ` Sascha Hauer
2011-03-03 16:25 ` Uwe Kleine-König
2011-03-03 18:00 ` Sascha Hauer
2011-03-03 20:10 ` Uwe Kleine-König
2011-03-04 8:19 ` Sascha Hauer
2011-03-04 10:11 ` Uwe Kleine-König
2011-03-04 21:20 ` Uwe Kleine-König
2011-03-04 22:28 ` Uwe Kleine-König [this message]
2011-03-04 22:28 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304222816.GZ22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=richard.zhao@freescale.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.