From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Cc: akpm@linux-foundation.org, jkosina@suse.cz, Alan Ott <alan@signal11.us>
Subject: [PATCH -next] hid-example: fix some build issues
Date: Mon, 18 Apr 2011 11:12:51 -0700 [thread overview]
Message-ID: <20110418111251.8a922b6b.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201104142149.p3ELnnoF008424@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
samples/hid-example.o needs some Kconfig and Makefile additions
in order to build. It should use <linux/*.h> headers from
the build tree, so use HEADERS_CHECK to require that those
header files be present.
Change the kconfig symbol from tristate to bool since
userspace cannot be built as loadable modules.
However, I don't understand why the userspace header files are
not present as reported in Andrew's build log, since it builds
OK on x86_64 without any of these changes.
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alan Ott <alan@signal11.us>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org
---
samples/Kconfig | 4 ++--
samples/hidraw/Makefile | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
--- linux-next-20110418.orig/samples/hidraw/Makefile
+++ linux-next-20110418/samples/hidraw/Makefile
@@ -6,3 +6,5 @@ hostprogs-y := hid-example
# Tell kbuild to always build the programs
always := $(hostprogs-y)
+
+HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include
--- linux-next-20110418.orig/samples/Kconfig
+++ linux-next-20110418/samples/Kconfig
@@ -62,8 +62,8 @@ config SAMPLE_KDB
command to the kdb shell.
config SAMPLE_HIDRAW
- tristate "Build simple hidraw example"
- depends on HIDRAW
+ bool "Build simple hidraw example"
+ depends on HIDRAW && HEADERS_CHECK
help
Build an example of how to use hidraw from userspace.
next prev parent reply other threads:[~2011-04-18 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 21:14 + hid-examplec-is-borked.patch added to -mm tree akpm
2011-04-18 18:12 ` Randy Dunlap [this message]
2011-04-19 8:48 ` [PATCH -next] hid-example: fix some build issues Jiri Kosina
2011-04-19 9:13 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418111251.8a922b6b.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alan@signal11.us \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.