From: Felipe Balbi <balbi@ti.com> To: Viliam Mateicka <viliam.mateicka@gmail.com> Cc: balbi@ti.com, Skacore Systems <skacore.systems@gmail.com>, Alan Stern <stern@rowland.harvard.edu>, Ben Dooks <ben-linux@fluff.org>, Kukjin Kim <kgene.kim@samsung.com>, Greg Kroah-Hartman <gregkh@suse.de>, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s3c2410_udc: fix custom UDC command handling Date: Mon, 20 Jun 2011 20:34:45 +0300 [thread overview] Message-ID: <20110620173444.GG26623@legolas.emea.dhcp.ti.com> (raw) In-Reply-To: <BANLkTinc-9hxLQ1Epf5=PoHvxtapfO7Vvg@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 2087 bytes --] Hi, On Mon, Jun 20, 2011 at 07:27:18PM +0200, Viliam Mateicka wrote: > I wonder then, who applies the patch first. One ass can't stop > progress (was there some progress afterall ?) because of one > line-break (which git produces by default afterall) and several > non-conforming whitespace conversions. I think you should stop > replying to me, because I'm kinda starting to like trolling afterall. Look, maybe you're just new to git/linux and that's fine. The only problem we had from day one is that you have been a complete dick when replying. If you go that road, that's what you'll get in return. Just so you see the properly formatted patch, I'm quoting below. See that there's no line breaks introduced by git. commit c27c9b5312f4b2a7e66ee772943355d77fc2c550 Author: Viliam Mateicka <viliam.mateicka@gmail.com> Date: Mon Jun 20 19:08:27 2011 +0300 usb: gadget: s3c2410_udc: fix custom UDC command handling There is a bug in Samsung's UDC driver, which is completely disabling the USB device when a custom UDC command is used. Following patch seems to get the right behavior (e.g. enabling pull-up instead of disabling then Vcc is applied). Signed-off-by: Viliam Mateicka <viliam.mateicka@gmail.com> [ balbi@ti.com : manually re-created the patch because author was unable to send a proper one ] Signed-off-by: Felipe Balbi <balbi@ti.com> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index 100f263..b6e1ca5 100644 --- a/drivers/usb/gadget/s3c2410_udc.c +++ b/drivers/usb/gadget/s3c2410_udc.c @@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum s3c2410_udc_cmd_e cmd) return; if (udc_info->udc_command) { - udc_info->udc_command(S3C2410_UDC_P_DISABLE); + udc_info->udc_command(cmd); } else if (gpio_is_valid(udc_info->pullup_pin)) { int value; (if you see any line breaks that's your mailer, it's better to check from the archives [1]) [1] http://marc.info/?l=linux-usb -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 490 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] s3c2410_udc: fix custom UDC command handling Date: Mon, 20 Jun 2011 20:34:45 +0300 [thread overview] Message-ID: <20110620173444.GG26623@legolas.emea.dhcp.ti.com> (raw) In-Reply-To: <BANLkTinc-9hxLQ1Epf5=PoHvxtapfO7Vvg@mail.gmail.com> Hi, On Mon, Jun 20, 2011 at 07:27:18PM +0200, Viliam Mateicka wrote: > I wonder then, who applies the patch first. One ass can't stop > progress (was there some progress afterall ?) because of one > line-break (which git produces by default afterall) and several > non-conforming whitespace conversions. I think you should stop > replying to me, because I'm kinda starting to like trolling afterall. Look, maybe you're just new to git/linux and that's fine. The only problem we had from day one is that you have been a complete dick when replying. If you go that road, that's what you'll get in return. Just so you see the properly formatted patch, I'm quoting below. See that there's no line breaks introduced by git. commit c27c9b5312f4b2a7e66ee772943355d77fc2c550 Author: Viliam Mateicka <viliam.mateicka@gmail.com> Date: Mon Jun 20 19:08:27 2011 +0300 usb: gadget: s3c2410_udc: fix custom UDC command handling There is a bug in Samsung's UDC driver, which is completely disabling the USB device when a custom UDC command is used. Following patch seems to get the right?behavior (e.g. enabling pull-up instead of disabling then Vcc is applied). Signed-off-by: Viliam Mateicka <viliam.mateicka@gmail.com> [ balbi at ti.com : manually re-created the patch because author was unable to send a proper one ] Signed-off-by: Felipe Balbi <balbi@ti.com> diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index 100f263..b6e1ca5 100644 --- a/drivers/usb/gadget/s3c2410_udc.c +++ b/drivers/usb/gadget/s3c2410_udc.c @@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum s3c2410_udc_cmd_e cmd) return; if (udc_info->udc_command) { - udc_info->udc_command(S3C2410_UDC_P_DISABLE); + udc_info->udc_command(cmd); } else if (gpio_is_valid(udc_info->pullup_pin)) { int value; (if you see any line breaks that's your mailer, it's better to check from the archives [1]) [1] http://marc.info/?l=linux-usb -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110620/90132734/attachment.sig>
next prev parent reply other threads:[~2011-06-20 17:34 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-16 8:04 [PATCH] s3c2410_udc: fix custom UDC command handling Viliam Mateicka 2011-06-16 8:04 ` Viliam Mateicka 2011-06-20 8:25 ` Viliam Mateicka 2011-06-20 8:25 ` Viliam Mateicka 2011-06-20 15:07 ` Alan Stern 2011-06-20 15:07 ` Alan Stern 2011-06-20 15:15 ` Felipe Balbi 2011-06-20 15:15 ` Felipe Balbi 2011-06-20 15:20 ` Skacore Systems 2011-06-20 15:20 ` Skacore Systems 2011-06-20 15:36 ` Felipe Balbi 2011-06-20 15:36 ` Felipe Balbi 2011-06-20 15:48 ` Skacore Systems 2011-06-20 15:48 ` Skacore Systems 2011-06-20 15:57 ` Skacore Systems 2011-06-20 15:57 ` Skacore Systems 2011-06-20 16:06 ` Felipe Balbi 2011-06-20 16:06 ` Felipe Balbi 2011-06-20 16:41 ` Skacore Systems 2011-06-20 16:41 ` Skacore Systems 2011-06-20 17:05 ` Felipe Balbi 2011-06-20 17:05 ` Felipe Balbi 2011-06-20 17:27 ` Viliam Mateicka 2011-06-20 17:27 ` Viliam Mateicka 2011-06-20 17:34 ` Felipe Balbi [this message] 2011-06-20 17:34 ` Felipe Balbi 2011-06-20 19:05 ` Viliam Mateicka 2011-06-20 19:05 ` Viliam Mateicka 2011-06-20 16:07 ` Jassi Brar 2011-06-20 16:07 ` Jassi Brar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110620173444.GG26623@legolas.emea.dhcp.ti.com \ --to=balbi@ti.com \ --cc=ben-linux@fluff.org \ --cc=gregkh@suse.de \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=skacore.systems@gmail.com \ --cc=stern@rowland.harvard.edu \ --cc=viliam.mateicka@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.