From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Linux PM mailing list <linux-pm@lists.linux-foundation.org> Cc: LKML <linux-kernel@vger.kernel.org>, Paul Mundt <lethal@linux-sh.org>, Magnus Damm <magnus.damm@gmail.com>, linux-sh@vger.kernel.org Subject: [PATCH 3/3] ARM / shmobile: Return -EBUSY from A4LC power off if A3RV is active Date: Wed, 13 Jul 2011 21:56:44 +0000 [thread overview] Message-ID: <201107132356.45037.rjw@sisk.pl> (raw) In-Reply-To: <201107132352.59801.rjw@sisk.pl> From: Rafael J. Wysocki <rjw@sisk.pl> Since the A4LC should only be powered off if the A3RV is off, make the A4LC's power down routine return -EBUSY if A3RV is not off to indicate to the core that it doesn't want to power off the domain in that case. This will cause the core to regard A4LC as active, so the pm_genpd_poweron() in pd_power_down_a3rv() is not necessary any more. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- arch/arm/mach-shmobile/pm-sh7372.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6/arch/arm/mach-shmobile/pm-sh7372.c =================================--- linux-2.6.orig/arch/arm/mach-shmobile/pm-sh7372.c +++ linux-2.6/arch/arm/mach-shmobile/pm-sh7372.c @@ -106,7 +106,6 @@ static int pd_power_down_a3rv(struct gen int ret = pd_power_down(genpd); /* try to power down A4LC after A3RV is requested off */ - pm_genpd_poweron(&sh7372_a4lc.genpd); genpd_queue_power_off_work(&sh7372_a4lc.genpd); return ret; @@ -118,7 +117,7 @@ static int pd_power_down_a4lc(struct gen if (!(__raw_readl(PSTR) & (1 << sh7372_a3rv.bit_shift))) return pd_power_down(genpd); - return 0; + return -EBUSY; } static bool pd_active_wakeup(struct device *dev)
WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Linux PM mailing list <linux-pm@lists.linux-foundation.org> Cc: LKML <linux-kernel@vger.kernel.org>, Paul Mundt <lethal@linux-sh.org>, Magnus Damm <magnus.damm@gmail.com>, linux-sh@vger.kernel.org Subject: [PATCH 3/3] ARM / shmobile: Return -EBUSY from A4LC power off if A3RV is active Date: Wed, 13 Jul 2011 23:56:44 +0200 [thread overview] Message-ID: <201107132356.45037.rjw@sisk.pl> (raw) In-Reply-To: <201107132352.59801.rjw@sisk.pl> From: Rafael J. Wysocki <rjw@sisk.pl> Since the A4LC should only be powered off if the A3RV is off, make the A4LC's power down routine return -EBUSY if A3RV is not off to indicate to the core that it doesn't want to power off the domain in that case. This will cause the core to regard A4LC as active, so the pm_genpd_poweron() in pd_power_down_a3rv() is not necessary any more. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- arch/arm/mach-shmobile/pm-sh7372.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6/arch/arm/mach-shmobile/pm-sh7372.c =================================================================== --- linux-2.6.orig/arch/arm/mach-shmobile/pm-sh7372.c +++ linux-2.6/arch/arm/mach-shmobile/pm-sh7372.c @@ -106,7 +106,6 @@ static int pd_power_down_a3rv(struct gen int ret = pd_power_down(genpd); /* try to power down A4LC after A3RV is requested off */ - pm_genpd_poweron(&sh7372_a4lc.genpd); genpd_queue_power_off_work(&sh7372_a4lc.genpd); return ret; @@ -118,7 +117,7 @@ static int pd_power_down_a4lc(struct gen if (!(__raw_readl(PSTR) & (1 << sh7372_a3rv.bit_shift))) return pd_power_down(genpd); - return 0; + return -EBUSY; } static bool pd_active_wakeup(struct device *dev)
next prev parent reply other threads:[~2011-07-13 21:56 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-13 21:52 [PATCH 0/3] PM / Domains / shmobile fixes Rafael J. Wysocki 2011-07-13 21:52 ` Rafael J. Wysocki 2011-07-13 21:54 ` [PATCH 1/3] ARM / shmobile: Use genpd_queue_power_off_work() Rafael J. Wysocki 2011-07-13 21:54 ` Rafael J. Wysocki 2011-07-13 21:54 ` Rafael J. Wysocki 2011-07-13 21:55 ` [PATCH 2/3] PM / Domains: Take .power_off() error code into account Rafael J. Wysocki 2011-07-13 21:55 ` Rafael J. Wysocki 2011-07-13 21:55 ` Rafael J. Wysocki 2011-07-13 21:56 ` [PATCH 3/3] ARM / shmobile: Return -EBUSY from A4LC power off if A3RV is active Rafael J. Wysocki 2011-07-13 21:56 ` Rafael J. Wysocki [this message] 2011-07-13 21:56 ` Rafael J. Wysocki 2011-07-14 2:10 ` [PATCH 0/3] PM / Domains / shmobile fixes Magnus Damm 2011-07-14 2:10 ` Magnus Damm 2011-07-14 2:10 ` Magnus Damm 2011-07-14 19:34 ` Rafael J. Wysocki 2011-07-14 19:34 ` Rafael J. Wysocki 2011-07-14 19:34 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201107132356.45037.rjw@sisk.pl \ --to=rjw@sisk.pl \ --cc=lethal@linux-sh.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@lists.linux-foundation.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.