All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Oleg Nesterov <oleg@redhat.com>,
	Paul Menage <paul@paulmenage.org>
Cc: containers@lists.linux-foundation.org,
	linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state setting bug in freezer_change_state()
Date: Mon, 29 Aug 2011 16:04:18 +0200	[thread overview]
Message-ID: <20110829140418.GB18871@mtj.dyndns.org> (raw)

d02f52811d0e "cgroup_freezer: prepare for removal of TIF_FREEZE" moved
setting of freezer->state into freezer_change_state(); unfortunately,
while doing so, when it's beginning to freeze tasks, it sets the state
to CGROUP_FROZEN instead of CGROUP_FREEZING ending up skipping the
whole freezing state.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Oleg Nesterov <oleg@redhat.com>
Cc: Paul Menage <paul@paulmenage.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
---
Rafael, these four patches fix the issues spotted by Oleg during
review of the freezer patchset.  Please apply them on pm-freezer once
Oleg acks them.  Thanks.

 kernel/cgroup_freezer.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: work/kernel/cgroup_freezer.c
===================================================================
--- work.orig/kernel/cgroup_freezer.c
+++ work/kernel/cgroup_freezer.c
@@ -311,14 +311,14 @@ static int freezer_change_state(struct c
 	if (goal_state == freezer->state)
 		goto out;
 
-	freezer->state = goal_state;
-
 	switch (goal_state) {
 	case CGROUP_THAWED:
+		freezer->state = CGROUP_THAWED;
 		atomic_dec(&system_freezing_cnt);
 		unfreeze_cgroup(cgroup, freezer);
 		break;
 	case CGROUP_FROZEN:
+		freezer->state = CGROUP_FREEZING;
 		atomic_inc(&system_freezing_cnt);
 		retval = try_to_freeze_cgroup(cgroup, freezer);
 		break;

             reply	other threads:[~2011-08-29 14:04 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 14:04 Tejun Heo [this message]
2011-08-29 14:05 ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD Tejun Heo
2011-08-29 14:05   ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Tejun Heo
2011-08-29 14:06     ` [PATCH pm-freezer 4/4] freezer: use lock_task_sighand() in fake_signal_wake_up() Tejun Heo
2011-08-29 14:06     ` Tejun Heo
2011-08-29 16:36       ` Oleg Nesterov
     [not found]       ` <20110829140621.GE18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 16:36         ` Oleg Nesterov
2011-08-29 16:36       ` Oleg Nesterov
2011-08-29 16:35     ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Oleg Nesterov
2011-08-29 17:12       ` Oleg Nesterov
2011-08-29 17:21         ` Oleg Nesterov
     [not found]         ` <20110829171228.GA11339-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-29 17:21           ` Oleg Nesterov
2011-08-29 17:21         ` Oleg Nesterov
     [not found]       ` <20110829163533.GB9973-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-29 17:12         ` Oleg Nesterov
2011-08-29 17:12       ` Oleg Nesterov
     [not found]     ` <20110829140549.GD18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 14:06       ` [PATCH pm-freezer 4/4] freezer: use lock_task_sighand() in fake_signal_wake_up() Tejun Heo
2011-08-29 16:35       ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Oleg Nesterov
2011-08-29 16:35     ` Oleg Nesterov
     [not found]   ` <20110829140509.GC18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 14:05     ` Tejun Heo
2011-08-29 18:02     ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD Oleg Nesterov
2011-08-29 14:05   ` [PATCH pm-freezer 3/4] freezer: check freezing() before leaving FROZEN state Tejun Heo
2011-08-29 18:02   ` [PATCH pm-freezer 2/4] freezer: set PF_NOFREEZE on a dying task right before TASK_DEAD Oleg Nesterov
2011-08-29 18:02   ` Oleg Nesterov
2011-08-29 14:05 ` Tejun Heo
     [not found] ` <20110829140418.GB18871-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-29 14:05   ` Tejun Heo
2011-08-29 16:00   ` [PATCH pm-freezer 1/4] cgroup_freezer: fix freezer->state setting bug in freezer_change_state() Oleg Nesterov
2011-08-29 16:00 ` Oleg Nesterov
2011-08-29 16:00 ` Oleg Nesterov
2011-08-29 14:04 Tejun Heo
2011-08-29 14:04 Tejun Heo
2011-08-31 10:21 Tejun Heo
2011-08-31 18:08 ` Oleg Nesterov
2011-08-31 18:08 ` Oleg Nesterov
     [not found] ` <20110831102100.GA2828-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2011-08-31 18:08   ` Oleg Nesterov
2011-09-02  0:42   ` Matt Helsley
2011-09-02  0:42 ` Matt Helsley
2011-09-02  0:42 ` Matt Helsley
2011-09-02  2:50   ` Tejun Heo
     [not found]   ` <20110902004231.GF1919-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2011-09-02  2:50     ` Tejun Heo
2011-09-02 16:58     ` Oleg Nesterov
2011-09-02 16:58       ` Oleg Nesterov
2011-09-02 17:08       ` Tejun Heo
2011-09-02 17:08       ` Tejun Heo
2011-09-02 17:15         ` Oleg Nesterov
2011-09-02 17:31           ` Tejun Heo
     [not found]           ` <20110902171517.GA8247-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-02 17:31             ` Tejun Heo
2011-09-02 17:31           ` Tejun Heo
2011-09-02 17:15         ` Oleg Nesterov
2011-09-02 17:30         ` Oleg Nesterov
     [not found]         ` <20110902170844.GJ2752-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2011-09-02 17:15           ` Oleg Nesterov
2011-09-02 17:30           ` Oleg Nesterov
2011-09-02 17:30             ` Oleg Nesterov
2011-09-02 18:31       ` Matt Helsley
2011-09-02 18:31       ` Matt Helsley
     [not found]       ` <20110902165839.GA7478-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-02 17:08         ` Tejun Heo
2011-09-02 18:31         ` Matt Helsley
2011-09-02  2:50   ` Tejun Heo
2011-09-02 16:58   ` Oleg Nesterov
2011-08-31 10:21 Tejun Heo
2011-08-31 10:21 Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829140418.GB18871@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=oleg@redhat.com \
    --cc=paul@paulmenage.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.