From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@openvz.org
Subject: [PATCH 1/7] nfsd: use "init_net" for portmapper
Date: Mon, 10 Dec 2012 12:19:04 +0300 [thread overview]
Message-ID: <20121210091904.8855.89077.stgit@localhost.localdomain> (raw)
In-Reply-To: <20121210091832.8855.26672.stgit@localhost.localdomain>
There could be a situation, when NFSd was started in one network namespace, but
stopped in another one.
This will trigger kernel panic, because RPCBIND client is stored on per-net
NFSd data, and will be NULL on NFSd shutdown.
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
---
fs/nfsd/nfssvc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index b34a67d..9beace6 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -11,7 +11,6 @@
#include <linux/module.h>
#include <linux/fs_struct.h>
#include <linux/swap.h>
-#include <linux/nsproxy.h>
#include <linux/sunrpc/stats.h>
#include <linux/sunrpc/svcsock.h>
@@ -341,7 +340,7 @@ static int nfsd_get_default_max_blksize(void)
int nfsd_create_serv(void)
{
int error;
- struct net *net = current->nsproxy->net_ns;
+ struct net *net = &init_net;
WARN_ON(!mutex_is_locked(&nfsd_mutex));
if (nfsd_serv) {
next prev parent reply other threads:[~2012-12-10 9:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 9:18 [PATCH 0/7] nfsd: cleanup "init_net" references Stanislav Kinsbursky
2012-12-10 9:19 ` Stanislav Kinsbursky [this message]
2012-12-10 9:19 ` [PATCH 2/7] nfsd: pass net to nfsd_init_socks() Stanislav Kinsbursky
2012-12-10 9:19 ` [PATCH 3/7] nfsd: pass net to nfsd_startup() and nfsd_shutdown() Stanislav Kinsbursky
2012-12-10 9:19 ` [PATCH 4/7] nfsd: pass net to nfsd_create_serv() Stanislav Kinsbursky
2012-12-10 9:19 ` [PATCH 5/7] nfsd: pass net to nfsd_svc() Stanislav Kinsbursky
2012-12-10 9:19 ` [PATCH 6/7] nfsd: pass net to nfsd_set_nrthreads() Stanislav Kinsbursky
2012-12-10 9:19 ` [PATCH 7/7] nfsd: pass net to __write_ports() and down Stanislav Kinsbursky
2012-12-10 12:34 ` [PATCH 0/7] nfsd: cleanup "init_net" references J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210091904.8855.89077.stgit@localhost.localdomain \
--to=skinsbursky@parallels.com \
--cc=bfields@fieldses.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.