All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Iles <jamie@jamieiles.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/20] ARM: picoxcell: Remove init_irq declaration in machine description
Date: Tue, 14 May 2013 16:20:46 +0000	[thread overview]
Message-ID: <20130514162046.GA16346@page> (raw)
In-Reply-To: <1368545933-7430-5-git-send-email-maxime.ripard@free-electrons.com>

Hi Maxime,

Thanks for this, I'll add it to my tree.  I've modified it slightly to 
kill off the other irq includes, hopefully that's okay with you.

Thanks,

Jamie

8<---

From 4b83f75a7af388aaf5f79ccf72c37074bc9166da Mon Sep 17 00:00:00 2001
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Tue, 14 May 2013 17:38:37 +0200
Subject: [PATCH] ARM: picoxcell: Remove init_irq declaration in machine
 description

Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is
specified") removed the need to explictly setup the init_irq field in
the machine description when using only irqchip_init. Remove that
declaration for picoxcell as well.

[ jiles: removed other, unused irq includes. ]

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 arch/arm/mach-picoxcell/common.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/mach-picoxcell/common.c b/arch/arm/mach-picoxcell/common.c
index f6f71bb..b069fa6 100644
--- a/arch/arm/mach-picoxcell/common.c
+++ b/arch/arm/mach-picoxcell/common.c
@@ -8,12 +8,8 @@
  * All enquiries to support@picochip.com
  */
 #include <linux/delay.h>
-#include <linux/irq.h>
-#include <linux/irqchip.h>
-#include <linux/irqdomain.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_irq.h>
 #include <linux/of_platform.h>
 #include <linux/dw_apb_timer.h>
 
@@ -85,7 +81,6 @@ static void picoxcell_wdt_restart(char mode, const char *cmd)
 DT_MACHINE_START(PICOXCELL, "Picochip picoXcell")
 	.map_io		= picoxcell_map_io,
 	.nr_irqs	= NR_IRQS_LEGACY,
-	.init_irq	= irqchip_init,
 	.init_time	= dw_apb_timer_init,
 	.init_machine	= picoxcell_init_machine,
 	.dt_compat	= picoxcell_dt_match,
-- 
1.8.1.2


WARNING: multiple messages have this Message-ID (diff)
From: Jamie Iles <jamie@jamieiles.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jamie Iles <jamie@jamieiles.com>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Christian Daudt <csd@broadcom.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	David Brown <davidb@codeaurora.org>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	Barry Song <baohua.song@csr.com>,
	Tony Prisk <linux@prisktech.co.nz>,
	linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 04/20] ARM: picoxcell: Remove init_irq declaration in machine description
Date: Tue, 14 May 2013 17:20:46 +0100	[thread overview]
Message-ID: <20130514162046.GA16346@page> (raw)
In-Reply-To: <1368545933-7430-5-git-send-email-maxime.ripard@free-electrons.com>

Hi Maxime,

Thanks for this, I'll add it to my tree.  I've modified it slightly to 
kill off the other irq includes, hopefully that's okay with you.

Thanks,

Jamie

8<---

>From 4b83f75a7af388aaf5f79ccf72c37074bc9166da Mon Sep 17 00:00:00 2001
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Tue, 14 May 2013 17:38:37 +0200
Subject: [PATCH] ARM: picoxcell: Remove init_irq declaration in machine
 description

Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is
specified") removed the need to explictly setup the init_irq field in
the machine description when using only irqchip_init. Remove that
declaration for picoxcell as well.

[ jiles: removed other, unused irq includes. ]

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 arch/arm/mach-picoxcell/common.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/mach-picoxcell/common.c b/arch/arm/mach-picoxcell/common.c
index f6f71bb..b069fa6 100644
--- a/arch/arm/mach-picoxcell/common.c
+++ b/arch/arm/mach-picoxcell/common.c
@@ -8,12 +8,8 @@
  * All enquiries to support@picochip.com
  */
 #include <linux/delay.h>
-#include <linux/irq.h>
-#include <linux/irqchip.h>
-#include <linux/irqdomain.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_irq.h>
 #include <linux/of_platform.h>
 #include <linux/dw_apb_timer.h>
 
@@ -85,7 +81,6 @@ static void picoxcell_wdt_restart(char mode, const char *cmd)
 DT_MACHINE_START(PICOXCELL, "Picochip picoXcell")
 	.map_io		= picoxcell_map_io,
 	.nr_irqs	= NR_IRQS_LEGACY,
-	.init_irq	= irqchip_init,
 	.init_time	= dw_apb_timer_init,
 	.init_machine	= picoxcell_init_machine,
 	.dt_compat	= picoxcell_dt_match,
-- 
1.8.1.2


WARNING: multiple messages have this Message-ID (diff)
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/20] ARM: picoxcell: Remove init_irq declaration in machine description
Date: Tue, 14 May 2013 17:20:46 +0100	[thread overview]
Message-ID: <20130514162046.GA16346@page> (raw)
In-Reply-To: <1368545933-7430-5-git-send-email-maxime.ripard@free-electrons.com>

Hi Maxime,

Thanks for this, I'll add it to my tree.  I've modified it slightly to 
kill off the other irq includes, hopefully that's okay with you.

Thanks,

Jamie

8<---

>From 4b83f75a7af388aaf5f79ccf72c37074bc9166da Mon Sep 17 00:00:00 2001
From: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Tue, 14 May 2013 17:38:37 +0200
Subject: [PATCH] ARM: picoxcell: Remove init_irq declaration in machine
 description

Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is
specified") removed the need to explictly setup the init_irq field in
the machine description when using only irqchip_init. Remove that
declaration for picoxcell as well.

[ jiles: removed other, unused irq includes. ]

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 arch/arm/mach-picoxcell/common.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm/mach-picoxcell/common.c b/arch/arm/mach-picoxcell/common.c
index f6f71bb..b069fa6 100644
--- a/arch/arm/mach-picoxcell/common.c
+++ b/arch/arm/mach-picoxcell/common.c
@@ -8,12 +8,8 @@
  * All enquiries to support at picochip.com
  */
 #include <linux/delay.h>
-#include <linux/irq.h>
-#include <linux/irqchip.h>
-#include <linux/irqdomain.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_irq.h>
 #include <linux/of_platform.h>
 #include <linux/dw_apb_timer.h>
 
@@ -85,7 +81,6 @@ static void picoxcell_wdt_restart(char mode, const char *cmd)
 DT_MACHINE_START(PICOXCELL, "Picochip picoXcell")
 	.map_io		= picoxcell_map_io,
 	.nr_irqs	= NR_IRQS_LEGACY,
-	.init_irq	= irqchip_init,
 	.init_time	= dw_apb_timer_init,
 	.init_machine	= picoxcell_init_machine,
 	.dt_compat	= picoxcell_dt_match,
-- 
1.8.1.2

  reply	other threads:[~2013-05-14 16:20 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 15:38 [PATCHv2 00/20] Cleanup irqchip_init calls Maxime Ripard
2013-05-14 15:38 ` Maxime Ripard
2013-05-14 15:38 ` Maxime Ripard
2013-05-14 15:38 ` [PATCH 01/20] ARM: sunxi: Remove init_irq declaration in machine description Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38 ` [PATCH 02/20] ARM: zynq: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:49   ` Michal Simek
2013-05-14 15:49     ` Michal Simek
2013-05-14 15:49     ` Michal Simek
2013-05-14 15:49     ` Michal Simek
2013-05-14 15:38 ` [PATCH 03/20] ARM: nomadik: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38 ` [PATCH 04/20] ARM: picoxcell: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 16:20   ` Jamie Iles [this message]
2013-05-14 16:20     ` Jamie Iles
2013-05-14 16:20     ` Jamie Iles
2013-05-16  8:19     ` Maxime Ripard
2013-05-16  8:19       ` Maxime Ripard
2013-05-16  8:19       ` Maxime Ripard
2013-05-20 22:42       ` Jamie Iles
2013-05-20 22:42         ` Jamie Iles
2013-05-20 22:42         ` Jamie Iles
2013-05-14 15:38 ` [PATCH 05/20] ARM: shmobile: ape6evm: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15  0:59   ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  1:46     ` Simon Horman
2013-05-15  1:46       ` Simon Horman
2013-05-15  1:46       ` Simon Horman
2013-05-15  1:49       ` Simon Horman
2013-05-15  1:49         ` Simon Horman
2013-05-15  1:49         ` Simon Horman
2013-05-14 15:38 ` [PATCH 06/20] ARM: shmobile: kzm9g: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15  0:59   ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  1:46     ` Simon Horman
2013-05-15  1:46       ` Simon Horman
2013-05-15  1:46       ` Simon Horman
2013-05-14 15:38 ` [PATCH 07/20] ARM: shmobile: lager: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15  0:59   ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  1:46   ` Simon Horman
2013-05-15  1:46     ` Simon Horman
2013-05-15  1:46     ` Simon Horman
2013-05-14 15:38 ` [PATCH 08/20] ARM: shmobile: emev2: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15  0:59   ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  0:59     ` Simon Horman
2013-05-15  1:47     ` Simon Horman
2013-05-15  1:47       ` Simon Horman
2013-05-15  1:47       ` Simon Horman
2013-05-14 15:38 ` [PATCH 09/20] ARM: shmobile: r8a73a4: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15  1:47   ` Simon Horman
2013-05-15  1:47     ` Simon Horman
2013-05-15  1:47     ` Simon Horman
2013-05-14 15:38 ` [PATCH 10/20] ARM: shmobile: r8a7790: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15  1:48   ` Simon Horman
2013-05-15  1:48     ` Simon Horman
2013-05-15  1:48     ` Simon Horman
2013-05-14 15:38 ` [PATCH 11/20] ARM: shmobile: sh73a0: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15  1:48   ` Simon Horman
2013-05-15  1:48     ` Simon Horman
2013-05-15  1:48     ` Simon Horman
2013-05-14 15:38 ` [PATCH 12/20] ARM: bcm281xx: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 18:04   ` Christian Daudt
2013-05-14 18:04     ` Christian Daudt
2013-05-14 18:04     ` Christian Daudt
2013-05-14 15:38 ` [PATCH 13/20] ARM: spear: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38 ` [PATCH 14/20] ARM: msm: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15 17:12   ` David Brown
2013-05-15 17:12     ` David Brown
2013-05-15 17:12     ` David Brown
2013-05-14 15:38 ` [PATCH 15/20] ARM: mvebu: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-19 20:17   ` Jason Cooper
2013-05-19 20:17     ` Jason Cooper
2013-05-19 20:17     ` Jason Cooper
2013-05-19 20:17     ` Jason Cooper
2013-05-14 15:38 ` [PATCH 16/20] ARM: mxs: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-17  1:53   ` Shawn Guo
2013-05-17  1:53     ` Shawn Guo
2013-05-17  1:53     ` Shawn Guo
2013-05-17  1:53     ` Shawn Guo
2013-05-14 15:38 ` [PATCH 17/20] ARM: sirf: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38 ` [PATCH 18/20] ARM: vexpress: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38 ` [PATCH 19/20] ARM: virt: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38 ` [PATCH 20/20] ARM: vt8500: " Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-14 15:38   ` Maxime Ripard
2013-05-15 18:52   ` Tony Prisk
2013-05-15 18:52     ` Tony Prisk
2013-05-15 18:52     ` Tony Prisk
2013-05-16  8:18     ` Maxime Ripard
2013-05-16  8:18       ` Maxime Ripard
2013-05-16  8:18       ` Maxime Ripard
2013-05-15 12:55 ` [PATCHv2 00/20] Cleanup irqchip_init calls Arnd Bergmann
2013-05-15 12:55   ` Arnd Bergmann
2013-05-15 12:55   ` Arnd Bergmann
2013-05-16  8:18   ` Maxime Ripard
2013-05-16  8:18     ` Maxime Ripard
2013-05-16  8:18     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514162046.GA16346@page \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.