All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@logfs.org>
To: linux-kernel@vger.kernel.org
Cc: Chris Mason <chris.mason@fusionio.com>, linux-btrfs@vger.kernel.org
Subject: [PATCH 1/2] list: add list_del_each_entry
Date: Fri, 5 Jul 2013 16:41:29 -0400	[thread overview]
Message-ID: <20130705204129.GB15943@logfs.org> (raw)
In-Reply-To: <20130705204100.GA15943@logfs.org>

I have seen a lot of boilerplate code that either follows the pattern of
	while (!list_empty(head)) {
		pos = list_entry(head->next, struct foo, list);
		list_del(pos->list);
		...
	}
or some variant thereof.

With this patch in, people can use
	list_del_each_entry(pos, head, list) {
		...
	}

The patch also adds a list_del_each variant, even though I have
only found a single user for that one so far.

Signed-off-by: Joern Engel <joern@logfs.org>
---
 include/linux/list.h |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/include/linux/list.h b/include/linux/list.h
index 6a1f8df..ab39c7d 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -557,6 +557,24 @@ static inline void list_splice_tail_init(struct list_head *list,
 #define list_safe_reset_next(pos, n, member)				\
 	n = list_entry(pos->member.next, typeof(*pos), member)
 
+/**
+ * list_del_each - removes an entry from the list until it is empty
+ * @pos:	the &struct list_head to use as a loop cursor.
+ * @head:	the head of your list.
+ */
+#define list_del_each(pos, head) \
+	while (list_empty(head) ? 0 : (pos = (head)->next, list_del(pos), 1))
+
+/**
+ * list_del_each_entry - removes an entry from the list until it is empty
+ * @pos:	the type * to use as loop cursor.
+ * @head:	the head of your list.
+ * @member:	the name of the list_struct within the struct
+ */
+#define list_del_each_entry(pos, head, member) \
+	while (list_empty(head) && (pos = list_first_entry((head), \
+		typeof(*pos), member), list_del((head)->next), 1))
+
 /*
  * Double linked lists with a single pointer list head.
  * Mostly useful for hash tables where the two pointer list head is
-- 
1.7.10.4


  reply	other threads:[~2013-07-05 22:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 17:28 [PATCH 0/2] introduce list_for_each_entry_del Joern Engel
2013-06-03 17:28 ` [PATCH 1/2] list: add list_for_each_entry_del Joern Engel
2013-06-06 19:32   ` Andy Shevchenko
2013-06-06 18:12     ` Jörn Engel
2013-06-06 19:49       ` Andy Shevchenko
2013-06-07 16:36         ` Jörn Engel
2013-06-07 18:30           ` Andy Shevchenko
2013-06-07 18:48             ` Jörn Engel
2013-06-08  0:03               ` Andy Shevchenko
2013-06-03 17:28 ` [PATCH 2/2] btrfs: use list_for_each_entry_del Joern Engel
2013-06-03 18:07 ` [PATCH 0/2] introduce list_for_each_entry_del Jörn Engel
2013-06-03 20:49 ` Christoph Hellwig
2013-06-03 19:36   ` Jörn Engel
2013-06-03 19:55     ` Jörn Engel
2013-06-04 14:48       ` Christoph Hellwig
2013-06-04 14:53         ` Chris Mason
2013-06-04 20:09           ` Arne Jansen
2013-06-04 18:44             ` Jörn Engel
2013-06-05  2:03               ` [PATCH 1/2] list: add while_list_drain_entry Jörn Engel
2013-06-05 14:32                 ` David Sterba
2013-06-05  2:04               ` [PATCH 2/2] btrfs: use while_list_drain_entry Jörn Engel
2013-06-05  2:09               ` [PATCH 0/2] introduce list_for_each_entry_del Jörn Engel
2013-06-05  6:53                 ` Arne Jansen
2013-06-05 14:25                   ` David Sterba
2013-07-05 20:41 ` Jörn Engel
2013-07-05 20:41   ` Jörn Engel [this message]
2013-07-05 22:38     ` [PATCH 1/2] list: add list_del_each_entry Filipe David Manana
2013-07-15 17:35       ` Jörn Engel
2013-07-05 20:41   ` [PATCH 2/2] btrfs: use list_del_each_entry Jörn Engel
2013-07-08  4:37   ` [PATCH 0/2] introduce list_for_each_entry_del Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130705204129.GB15943@logfs.org \
    --to=joern@logfs.org \
    --cc=chris.mason@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.