All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>,
	kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: [PATCH 11/11] KVM: PPC: Book3S HV: Return -EINVAL rather than BUG'ing
Date: Fri, 6 Sep 2013 13:25:37 +1000	[thread overview]
Message-ID: <20130906032537.GL29710@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <20130906031003.GA29710@iris.ozlabs.ibm.com>

From: Michael Ellerman <michael@ellerman.id.au>

This means that if we do happen to get a trap that we don't know
about, we abort the guest rather than crashing the host kernel.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
 arch/powerpc/kvm/book3s_hv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 0bb23a9..731e46e 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -709,8 +709,7 @@ static int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu,
 		printk(KERN_EMERG "trap=0x%x | pc=0x%lx | msr=0x%llx\n",
 			vcpu->arch.trap, kvmppc_get_pc(vcpu),
 			vcpu->arch.shregs.msr);
-		r = RESUME_HOST;
-		BUG();
+		r = -EINVAL;
 		break;
 	}
 
-- 
1.8.4.rc3

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>,
	kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: [PATCH 11/11] KVM: PPC: Book3S HV: Return -EINVAL rather than BUG'ing
Date: Fri, 06 Sep 2013 03:25:37 +0000	[thread overview]
Message-ID: <20130906032537.GL29710@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <20130906031003.GA29710@iris.ozlabs.ibm.com>

From: Michael Ellerman <michael@ellerman.id.au>

This means that if we do happen to get a trap that we don't know
about, we abort the guest rather than crashing the host kernel.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
 arch/powerpc/kvm/book3s_hv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 0bb23a9..731e46e 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -709,8 +709,7 @@ static int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu,
 		printk(KERN_EMERG "trap=0x%x | pc=0x%lx | msr=0x%llx\n",
 			vcpu->arch.trap, kvmppc_get_pc(vcpu),
 			vcpu->arch.shregs.msr);
-		r = RESUME_HOST;
-		BUG();
+		r = -EINVAL;
 		break;
 	}
 
-- 
1.8.4.rc3


  parent reply	other threads:[~2013-09-06  3:25 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  3:10 [PATCH 00/11] HV KVM improvements in preparation for POWER8 support Paul Mackerras
2013-09-06  3:10 ` Paul Mackerras
2013-09-06  3:11 ` [PATCH 01/11] KVM: PPC: Book3S HV: Save/restore SIAR and SDAR along with other PMU registers Paul Mackerras
2013-09-06  3:11   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-06  3:17 ` [PATCH 02/11] KVM: PPC: Book3S HV: Implement timebase offset for guests Paul Mackerras
2013-09-06  3:17   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-06  3:18 ` [PATCH 03/11] KVM: PPC: Book3S: Add GET/SET_ONE_REG interface for VRSAVE Paul Mackerras
2013-09-06  3:18   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-14  2:07     ` Paul Mackerras
2013-09-14  2:07       ` Paul Mackerras
2013-09-06  3:21 ` [PATCH 04/11] KVM: PPC: Book3S HV: Add GET/SET_ONE_REG interface for LPCR Paul Mackerras
2013-09-06  3:21   ` Paul Mackerras
2013-09-13 18:36   ` Alexander Graf
2013-09-13 18:36     ` Alexander Graf
2013-09-14  2:21     ` Paul Mackerras
2013-09-14  2:21       ` Paul Mackerras
2013-09-14  5:12       ` Alexander Graf
2013-09-14  5:12         ` Alexander Graf
2013-09-14  5:58         ` Paul Mackerras
2013-09-14  5:58           ` Paul Mackerras
2013-09-14 11:38           ` Alexander Graf
2013-09-14 11:38             ` Alexander Graf
2013-09-06  3:22 ` [PATCH 05/11] KVM: PPC: Book3S HV: Add support for guest Program Priority Register Paul Mackerras
2013-09-06  3:22   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-17  3:29   ` Benjamin Herrenschmidt
2013-09-17  3:29     ` Benjamin Herrenschmidt
2013-09-20  3:39     ` Alexander Graf
2013-09-20  3:39       ` Alexander Graf
2013-09-06  3:22 ` [PATCH 06/11] KVM: PPC: Book3S HV: Support POWER6 compatibility mode on POWER7 Paul Mackerras
2013-09-06  3:22   ` Paul Mackerras
2013-09-06  5:28   ` Aneesh Kumar K.V
2013-09-06  5:40     ` Aneesh Kumar K.V
2013-09-06  6:38     ` Paul Mackerras
2013-09-06  6:38       ` Paul Mackerras
2013-09-13 19:58   ` Alexander Graf
2013-09-13 19:58     ` Alexander Graf
2013-09-14  2:03     ` Paul Mackerras
2013-09-14  2:03       ` Paul Mackerras
2013-09-06  3:23 ` [PATCH 07/11] KVM: PPC: Book3S HV: Implement H_CONFER Paul Mackerras
2013-09-06  3:23   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-06  3:23 ` [PATCH 08/11] KVM: PPC: Book3S HV: Restructure kvmppc_hv_entry to be a subroutine Paul Mackerras
2013-09-06  3:23   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-06  3:24 ` [PATCH 09/11] KVM: PPC: Book3S HV: Pull out interrupt-reading code into " Paul Mackerras
2013-09-06  3:24   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-06  3:24 ` [PATCH 10/11] KVM: PPC: Book3S HV: Avoid unbalanced increments of VPA yield count Paul Mackerras
2013-09-06  3:24   ` Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-06  3:25 ` Paul Mackerras [this message]
2013-09-06  3:25   ` [PATCH 11/11] KVM: PPC: Book3S HV: Return -EINVAL rather than BUG'ing Paul Mackerras
2013-09-13 21:51   ` Alexander Graf
2013-09-13 21:51     ` Alexander Graf
2013-09-11  9:11 ` [PATCH 00/11] HV KVM improvements in preparation for POWER8 support Paul Mackerras
2013-09-11  9:11   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130906032537.GL29710@iris.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.