From: Dan Carpenter <dan.carpenter@oracle.com> To: Gleb Natapov <gleb@kernel.org> Cc: Paolo Bonzini <pbonzini@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, kvm@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch RFC] kvm, cpuid: silence a buffer overflow warning Date: Thu, 20 Feb 2014 12:34:19 +0000 [thread overview] Message-ID: <20140220123419.GA10110@elgon.mountain> (raw) This seems like a harmless off by one overflow if "i" is the last element in the vcpu->arch.cpuid_entries[] array. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Not tested. I always wonder if it's worth fixing these or if it's worth reporting them? Either of those seem like a lot of work for something harmless. diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index c6976257eff5..7d02c0fc768c 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -660,7 +660,7 @@ static int move_to_next_stateful_cpuid_entry(struct kvm_vcpu *vcpu, int i) e->flags &= ~KVM_CPUID_FLAG_STATE_READ_NEXT; /* when no next entry is found, the current entry[i] is reselected */ - for (j = i + 1; ; j = (j + 1) % nent) { + for (j = (i + 1) % nent; ; j = (j + 1) % nent) { struct kvm_cpuid_entry2 *ej = &vcpu->arch.cpuid_entries[j]; if (ej->function = e->function) { ej->flags |= KVM_CPUID_FLAG_STATE_READ_NEXT;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Gleb Natapov <gleb@kernel.org> Cc: Paolo Bonzini <pbonzini@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, kvm@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch RFC] kvm, cpuid: silence a buffer overflow warning Date: Thu, 20 Feb 2014 15:34:19 +0300 [thread overview] Message-ID: <20140220123419.GA10110@elgon.mountain> (raw) This seems like a harmless off by one overflow if "i" is the last element in the vcpu->arch.cpuid_entries[] array. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- Not tested. I always wonder if it's worth fixing these or if it's worth reporting them? Either of those seem like a lot of work for something harmless. diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index c6976257eff5..7d02c0fc768c 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -660,7 +660,7 @@ static int move_to_next_stateful_cpuid_entry(struct kvm_vcpu *vcpu, int i) e->flags &= ~KVM_CPUID_FLAG_STATE_READ_NEXT; /* when no next entry is found, the current entry[i] is reselected */ - for (j = i + 1; ; j = (j + 1) % nent) { + for (j = (i + 1) % nent; ; j = (j + 1) % nent) { struct kvm_cpuid_entry2 *ej = &vcpu->arch.cpuid_entries[j]; if (ej->function == e->function) { ej->flags |= KVM_CPUID_FLAG_STATE_READ_NEXT;
next reply other threads:[~2014-02-20 12:34 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-20 12:34 Dan Carpenter [this message] 2014-02-20 12:34 ` [patch RFC] kvm, cpuid: silence a buffer overflow warning Dan Carpenter 2014-02-20 13:07 ` Paolo Bonzini 2014-02-20 13:07 ` Paolo Bonzini 2014-02-20 13:18 ` walter harms 2014-02-20 13:18 ` walter harms 2014-02-20 13:19 ` Paolo Bonzini 2014-02-20 13:19 ` Paolo Bonzini 2014-02-20 13:23 ` Dan Carpenter 2014-02-20 13:23 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140220123419.GA10110@elgon.mountain \ --to=dan.carpenter@oracle.com \ --cc=gleb@kernel.org \ --cc=hpa@zytor.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=kvm@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=pbonzini@redhat.com \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.