From: Chuck Lever <chuck.lever@oracle.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 3/4] nfsd: Mark back channel down if SESSION4_BACK_CHAN is clear
Date: Fri, 22 Aug 2014 15:11:07 -0400 [thread overview]
Message-ID: <20140822191107.3883.84107.stgit@klimt.1015granger.net> (raw)
In-Reply-To: <20140822190835.3883.7581.stgit@klimt.1015granger.net>
If a client indicates via CREATE_SESSION that no back channel
should be used on the existing connection, mark the client's
cl_cb_state DOWN instead of leaving it UNKNOWN.
Otherwise, a fresh session is created without an operational
backchannel, but the server never asserts SEQ4_STATUS_CB_PATH_DOWN.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfs4state.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index a45f244..d7cfd8b 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1429,6 +1429,9 @@ static void init_session(struct svc_rqst *rqstp, struct nfsd4_session *new, stru
list_add(&new->se_perclnt, &clp->cl_sessions);
spin_unlock(&clp->cl_lock);
+ if (!(cses->flags & SESSION4_BACK_CHAN))
+ clp->cl_cb_state = NFSD4_CB_DOWN;
+
{
struct sockaddr *sa = svc_addr(rqstp);
/*
next prev parent reply other threads:[~2014-08-22 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:10 [PATCH 0/4] Simple-minded server fixes for sidecar backchannel Chuck Lever
2014-08-22 19:10 ` [PATCH 1/4] sunrpc: fix byte-swapping of displayed XID Chuck Lever
2014-08-27 21:16 ` J. Bruce Fields
2014-08-22 19:10 ` [PATCH 2/4] NFSD: Always initialize cl_cb_addr Chuck Lever
2014-10-02 19:53 ` J. Bruce Fields
2014-08-22 19:11 ` Chuck Lever [this message]
2014-08-22 19:11 ` [PATCH 4/4] nfsd: Assert SEQ4_STATUS_CB_PATH_DOWN_SESSION Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822191107.3883.84107.stgit@klimt.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.