From: Chuck Lever <chuck.lever@oracle.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 4/4] nfsd: Assert SEQ4_STATUS_CB_PATH_DOWN_SESSION
Date: Fri, 22 Aug 2014 15:11:16 -0400 [thread overview]
Message-ID: <20140822191116.3883.65056.stgit@klimt.1015granger.net> (raw)
In-Reply-To: <20140822190835.3883.7581.stgit@klimt.1015granger.net>
The NFS server should assert both CB_PATH_DOWN and CB_PATH_DOWN_SESSION
when there is no backchannel.
RFC 5661 section 18.46.3:
SEQ4_STATUS_CB_PATH_DOWN
When set, indicates that the client has no operational backchannel
path for any session associated with the client ID, making it
necessary for the client to re-establish one. This bit remains
set on all SEQUENCE responses on all sessions associated with the
client ID until at least one backchannel is available on any
session associated with the client ID.
SEQ4_STATUS_CB_PATH_DOWN_SESSION
When set, indicates that the session has no operational
backchannel. . .
. . . The SEQ4_STATUS_CB_PATH_DOWN_SESSION bit is the
indication to the client that it needs to associate a connection
to the session’s backchannel. This bit remains set on all
SEQUENCE responses of the session until a connection is associated
with the session’s a backchannel.
The Linux server doesn't currently make a distinction between these
cases, so both flags should be asserted unconditionally.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfs4state.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index d7cfd8b..ea50ac0 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2805,7 +2805,8 @@ nfsd4_sequence(struct svc_rqst *rqstp,
out:
switch (clp->cl_cb_state) {
case NFSD4_CB_DOWN:
- seq->status_flags = SEQ4_STATUS_CB_PATH_DOWN;
+ seq->status_flags = SEQ4_STATUS_CB_PATH_DOWN |
+ SEQ4_STATUS_CB_PATH_DOWN_SESSION;
break;
case NFSD4_CB_FAULT:
seq->status_flags = SEQ4_STATUS_BACKCHANNEL_FAULT;
prev parent reply other threads:[~2014-08-22 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:10 [PATCH 0/4] Simple-minded server fixes for sidecar backchannel Chuck Lever
2014-08-22 19:10 ` [PATCH 1/4] sunrpc: fix byte-swapping of displayed XID Chuck Lever
2014-08-27 21:16 ` J. Bruce Fields
2014-08-22 19:10 ` [PATCH 2/4] NFSD: Always initialize cl_cb_addr Chuck Lever
2014-10-02 19:53 ` J. Bruce Fields
2014-08-22 19:11 ` [PATCH 3/4] nfsd: Mark back channel down if SESSION4_BACK_CHAN is clear Chuck Lever
2014-08-22 19:11 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822191116.3883.65056.stgit@klimt.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.