All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Tero Kristo" <t-kristo@ti.com>, "Paul Walmsley" <paul@pwsan.com>,
	"Kevin Hilman" <khilman@deeprootsystems.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, Keerthy <j-keerthy@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	devicetree@vger.kernel.org, "Dave Gerlach" <d-gerlach@ti.com>
Subject: Re: [PATCH 1/3] pinctrl: bindings: Add OMAP pinctrl binding
Date: Mon, 25 Aug 2014 14:03:12 -0500	[thread overview]
Message-ID: <20140825190311.GA21871@kahuna> (raw)
In-Reply-To: <20140825172506.GM17254@atomide.com>

On 10:25-20140825, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140822 07:03]:
> > Add basic skeleton of OMAP pinctrl bindings. This is compatible with
> > pinctrl,single bindings and is meant purely as a reference point.
> > 
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> 
> Looks like you have ti,omap2420-padconf and ti,omap2430-padconf missing
> but after adding those too:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

I now see why I missed them:
arch/arm/boot/dts/omap2420.dtsi:                        compatible = "ti,omap2420-padconf", "pinctrl-single";
arch/arm/boot/dts/omap2430.dtsi:                        compatible = "ti,omap2430-padconf", "pinctrl-single";

These are the only two references to the compatible, there is no driver
matching being done, had missed it hence :( - Updated revision below
(with your ack). Unless there are anymore review comments OR you'd want
me to explicitly, I dont plan on reposting the following again.

---8<---
>From 74121c6a2524048eb02c3b33a25e13261edd2e99 Mon Sep 17 00:00:00 2001
From: Nishanth Menon <nm@ti.com>
Date: Thu, 22 May 2014 23:32:09 -0500
Subject: [PATCH V2] pinctrl: bindings: Add OMAP pinctrl binding

Add basic skeleton of OMAP pinctrl bindings. This is compatible with
pinctrl,single bindings and is meant purely as a reference point.

Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 .../bindings/pinctrl/ti,omap-pinctrl.txt           |   11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt

diff --git a/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
new file mode 100644
index 0000000..b3b57fc
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
@@ -0,0 +1,11 @@
+OMAP Pinctrl definitions
+
+Required properties:
+- compatible : Should be one of:
+  "ti,omap2420-padconf" - OMAP2420 compatible pinctrl
+  "ti,omap2430-padconf" - OMAP2430 compatible pinctrl
+  "ti,omap3-padconf" - OMAP3 compatible pinctrl
+  "ti,omap4-padconf" - OMAP4 compatible pinctrl
+  "ti,omap5-padconf" - OMAP5 compatible pinctrl
+
+See Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt for further details.
-- 
1.7.9.5

-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pinctrl: bindings: Add OMAP pinctrl binding
Date: Mon, 25 Aug 2014 14:03:12 -0500	[thread overview]
Message-ID: <20140825190311.GA21871@kahuna> (raw)
In-Reply-To: <20140825172506.GM17254@atomide.com>

On 10:25-20140825, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [140822 07:03]:
> > Add basic skeleton of OMAP pinctrl bindings. This is compatible with
> > pinctrl,single bindings and is meant purely as a reference point.
> > 
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> 
> Looks like you have ti,omap2420-padconf and ti,omap2430-padconf missing
> but after adding those too:
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

I now see why I missed them:
arch/arm/boot/dts/omap2420.dtsi:                        compatible = "ti,omap2420-padconf", "pinctrl-single";
arch/arm/boot/dts/omap2430.dtsi:                        compatible = "ti,omap2430-padconf", "pinctrl-single";

These are the only two references to the compatible, there is no driver
matching being done, had missed it hence :( - Updated revision below
(with your ack). Unless there are anymore review comments OR you'd want
me to explicitly, I dont plan on reposting the following again.

---8<---
>From 74121c6a2524048eb02c3b33a25e13261edd2e99 Mon Sep 17 00:00:00 2001
From: Nishanth Menon <nm@ti.com>
Date: Thu, 22 May 2014 23:32:09 -0500
Subject: [PATCH V2] pinctrl: bindings: Add OMAP pinctrl binding

Add basic skeleton of OMAP pinctrl bindings. This is compatible with
pinctrl,single bindings and is meant purely as a reference point.

Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 .../bindings/pinctrl/ti,omap-pinctrl.txt           |   11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt

diff --git a/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
new file mode 100644
index 0000000..b3b57fc
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/ti,omap-pinctrl.txt
@@ -0,0 +1,11 @@
+OMAP Pinctrl definitions
+
+Required properties:
+- compatible : Should be one of:
+  "ti,omap2420-padconf" - OMAP2420 compatible pinctrl
+  "ti,omap2430-padconf" - OMAP2430 compatible pinctrl
+  "ti,omap3-padconf" - OMAP3 compatible pinctrl
+  "ti,omap4-padconf" - OMAP4 compatible pinctrl
+  "ti,omap5-padconf" - OMAP5 compatible pinctrl
+
+See Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt for further details.
-- 
1.7.9.5

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2014-08-25 19:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 14:00 [PATCH 0/3] pinctrl: Add DRA7/AM437x pinctrl compatibility Nishanth Menon
2014-08-22 14:00 ` Nishanth Menon
2014-08-22 14:00 ` Nishanth Menon
2014-08-22 14:01 ` [PATCH 1/3] pinctrl: bindings: Add OMAP pinctrl binding Nishanth Menon
2014-08-22 14:01   ` Nishanth Menon
2014-08-22 14:01   ` Nishanth Menon
2014-08-25 17:25   ` Tony Lindgren
2014-08-25 17:25     ` Tony Lindgren
2014-08-25 17:25     ` Tony Lindgren
2014-08-25 19:03     ` Nishanth Menon [this message]
2014-08-25 19:03       ` Nishanth Menon
2014-08-29  7:27       ` Linus Walleij
2014-08-29  7:27         ` Linus Walleij
2014-08-22 14:01 ` [PATCH 2/3] pinctrl: single: Add DRA7 pinctrl compatibility Nishanth Menon
2014-08-22 14:01   ` Nishanth Menon
2014-08-25 17:26   ` Tony Lindgren
2014-08-25 17:26     ` Tony Lindgren
2014-08-25 17:26     ` Tony Lindgren
2014-08-29  7:29   ` Linus Walleij
2014-08-29  7:29     ` Linus Walleij
2014-08-22 14:01 ` [PATCH 3/3] pinctrl: single: AM437x: Add " Nishanth Menon
2014-08-22 14:01   ` Nishanth Menon
2014-08-22 14:01   ` Nishanth Menon
2014-08-25 17:26   ` Tony Lindgren
2014-08-25 17:26     ` Tony Lindgren
2014-08-25 17:26     ` Tony Lindgren
2014-08-29  7:29   ` Linus Walleij
2014-08-29  7:29     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825190311.GA21871@kahuna \
    --to=nm@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.