From: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> To: Stephan Mueller <smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org> Cc: Steffen Klassert <steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org>, Daniel Borkmann <dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, quentin.gouchet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ABI/API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: crypto: user - Allow get request with empty driver name Date: Thu, 20 Nov 2014 12:46:50 +0800 [thread overview] Message-ID: <20141120044650.GA28691@gondor.apana.org.au> (raw) In-Reply-To: <3538055.XH2t7HNEVj-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> On Thu, Nov 20, 2014 at 05:23:23AM +0100, Stephan Mueller wrote: > > Here is the code: > > static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, > struct nlattr **attrs) > { > ... > if (!p->cru_driver_name[0]) > return -EINVAL; OK let's fix this. crypto: user - Allow get request with empty driver name Currently all get requests with an empty driver name fail with EINVAL. Since most users actually want to supply an empty driver name this patch removes this check. Signed-off-by: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index e2a34fe..0bb30ac 100644 --- a/crypto/crypto_user.c +++ b/crypto/crypto_user.c @@ -201,10 +201,7 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, if (!null_terminated(p->cru_name) || !null_terminated(p->cru_driver_name)) return -EINVAL; - if (!p->cru_driver_name[0]) - return -EINVAL; - - alg = crypto_alg_match(p, 1); + alg = crypto_alg_match(p, 0); if (!alg) return -ENOENT; Cheers, -- Email: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au> To: Stephan Mueller <smueller@chronox.de> Cc: Steffen Klassert <steffen.klassert@secunet.com>, Daniel Borkmann <dborkman@redhat.com>, quentin.gouchet@gmail.com, LKML <linux-kernel@vger.kernel.org>, linux-crypto@vger.kernel.org, ABI/API <linux-api@vger.kernel.org> Subject: crypto: user - Allow get request with empty driver name Date: Thu, 20 Nov 2014 12:46:50 +0800 [thread overview] Message-ID: <20141120044650.GA28691@gondor.apana.org.au> (raw) In-Reply-To: <3538055.XH2t7HNEVj@tachyon.chronox.de> On Thu, Nov 20, 2014 at 05:23:23AM +0100, Stephan Mueller wrote: > > Here is the code: > > static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, > struct nlattr **attrs) > { > ... > if (!p->cru_driver_name[0]) > return -EINVAL; OK let's fix this. crypto: user - Allow get request with empty driver name Currently all get requests with an empty driver name fail with EINVAL. Since most users actually want to supply an empty driver name this patch removes this check. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c index e2a34fe..0bb30ac 100644 --- a/crypto/crypto_user.c +++ b/crypto/crypto_user.c @@ -201,10 +201,7 @@ static int crypto_report(struct sk_buff *in_skb, struct nlmsghdr *in_nlh, if (!null_terminated(p->cru_name) || !null_terminated(p->cru_driver_name)) return -EINVAL; - if (!p->cru_driver_name[0]) - return -EINVAL; - - alg = crypto_alg_match(p, 1); + alg = crypto_alg_match(p, 0); if (!alg) return -ENOENT; Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2014-11-20 4:46 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-16 2:23 [PATCH v2 00/10] crypto: AF_ALG: add AEAD and RNG support Stephan Mueller 2014-11-16 2:23 ` [PATCH v2 01/10] crypto: AF_ALG: add user space interface for AEAD Stephan Mueller 2014-11-18 14:06 ` Herbert Xu [not found] ` <20141118140631.GA12100-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-19 0:34 ` Stephan Mueller 2014-11-19 0:34 ` Stephan Mueller 2014-11-19 4:20 ` Stephan Mueller [not found] ` <2398701.sGeMzIcHaz-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-19 4:27 ` Herbert Xu 2014-11-19 4:27 ` Herbert Xu [not found] ` <20141119042704.GA19258-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-19 6:30 ` Stephan Mueller 2014-11-19 6:30 ` Stephan Mueller [not found] ` <12318471.ucMNmAKX0e-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-19 6:45 ` Herbert Xu 2014-11-19 6:45 ` Herbert Xu 2014-11-16 2:24 ` [PATCH v2 02/10] crypto: AF_ALG: user space interface for cipher info Stephan Mueller 2014-11-18 14:08 ` Herbert Xu 2014-11-19 1:02 ` Stephan Mueller 2014-11-19 1:05 ` Herbert Xu [not found] ` <20141118140822.GB12100-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-20 4:03 ` Stephan Mueller 2014-11-20 4:03 ` Stephan Mueller 2014-11-20 6:32 ` Steffen Klassert 2014-11-20 6:32 ` Steffen Klassert [not found] ` <16101836.sTaxopCThb-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-20 4:07 ` Herbert Xu 2014-11-20 4:07 ` Herbert Xu [not found] ` <20141120040748.GB28420-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-20 4:14 ` Stephan Mueller 2014-11-20 4:14 ` Stephan Mueller [not found] ` <1886827.KUDIsNtfuk-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-20 4:18 ` Herbert Xu 2014-11-20 4:18 ` Herbert Xu [not found] ` <20141120041824.GA28612-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-20 4:23 ` Stephan Mueller 2014-11-20 4:23 ` Stephan Mueller [not found] ` <3538055.XH2t7HNEVj-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-20 4:46 ` Herbert Xu [this message] 2014-11-20 4:46 ` crypto: user - Allow get request with empty driver name Herbert Xu 2014-11-20 7:11 ` Steffen Klassert 2014-11-20 7:11 ` Steffen Klassert 2014-11-20 7:45 ` Herbert Xu [not found] ` <20141120074526.GB29544-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-20 8:04 ` Steffen Klassert 2014-11-20 8:04 ` Steffen Klassert 2014-11-20 8:04 ` Steffen Klassert [not found] ` <20141120080406.GV6390-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org> 2014-11-20 13:07 ` Stephan Mueller 2014-11-20 13:07 ` Stephan Mueller [not found] ` <20141120044650.GA28691-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-20 13:02 ` Stephan Mueller 2014-11-20 13:02 ` Stephan Mueller 2014-11-20 13:10 ` Stephan Mueller [not found] ` <2283056.kKnMJs7Bfg-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-20 13:40 ` Herbert Xu 2014-11-20 13:40 ` Herbert Xu 2014-11-20 16:08 ` Stephan Mueller [not found] ` <6655976.jRkjMUZ19x-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-21 2:31 ` Herbert Xu 2014-11-21 2:31 ` Herbert Xu [not found] ` <20141121023131.GA3873-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org> 2014-11-21 2:42 ` Stephan Mueller 2014-11-21 2:42 ` Stephan Mueller 2014-11-21 4:40 ` Stephan Mueller 2014-11-20 7:05 ` [PATCH v2 02/10] crypto: AF_ALG: user space interface for cipher info Steffen Klassert 2014-11-20 7:05 ` Steffen Klassert 2014-11-20 7:05 ` Steffen Klassert 2014-11-16 2:25 ` [PATCH v2 03/10] crypto: AF_ALG: extend data structuers for AEAD Stephan Mueller 2014-11-16 2:25 ` [PATCH v2 04/10] crypto: AF_ALG: crypto API calls to inline functions Stephan Mueller 2014-11-16 2:26 ` [PATCH v2 05/10] crypto: AF_ALG: add AEAD support Stephan Mueller 2014-11-16 2:27 ` [PATCH v2 07/10] crypto: AF_ALG: add random number generator support Stephan Mueller [not found] ` <5365136.g8vbXlhRyC-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org> 2014-11-16 2:26 ` [PATCH v2 06/10] crypto: AF_ALG: make setkey optional Stephan Mueller 2014-11-16 2:26 ` Stephan Mueller 2014-11-18 14:10 ` Herbert Xu 2014-11-19 2:36 ` Stephan Mueller 2014-11-16 2:28 ` [PATCH v2 08/10] crypto: AF_ALG: enable RNG interface compilation Stephan Mueller 2014-11-16 2:28 ` Stephan Mueller 2014-11-16 2:28 ` [PATCH v2 09/10] crypto: AF_ALG: user space interface for hash info Stephan Mueller 2014-11-16 2:29 ` [PATCH v2 10/10] crypto: AF_ALG: document the user space interface Stephan Mueller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141120044650.GA28691@gondor.apana.org.au \ --to=herbert-loam2ak0srrlbo1qdeomrrpzq4s04n8q@public.gmane.org \ --cc=dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=quentin.gouchet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org \ --cc=steffen.klassert-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.