From: Gustavo Padovan <gustavo@padovan.org> To: Ajay Kumar <ajaykumar.rs@samsung.com> Cc: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kgene.kim@samsung.com, inki.dae@samsung.com, thierry.reding@gmail.com, daniel.vetter@ffwll.ch, seanpaul@google.com, ajaynumb@gmail.com, jg1.han@samsung.com, bhushan.r@samsung.com, prashanth.g@samsung.com Subject: Re: [PATCH V9 04/14] drm/bridge: ptn3460: Convert to i2c driver model Date: Thu, 29 Jan 2015 12:29:19 -0200 [thread overview] Message-ID: <20150129142919.GN2001@joana> (raw) In-Reply-To: <1421771935-31618-5-git-send-email-ajaykumar.rs@samsung.com> Hi Ajay, 2015-01-20 Ajay Kumar <ajaykumar.rs@samsung.com>: > Use drm_bridge helpers to modify the driver to support > i2c driver model. > > Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> > Acked-by: Inki Dae <inki.dae@samsung.com> > Tested-by: Rahul Sharma <rahul.sharma@samsung.com> > Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Tested-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > Tested-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > --- > drivers/gpu/drm/bridge/Kconfig | 2 + > drivers/gpu/drm/bridge/ptn3460.c | 124 +++++++++++++++++++++---------- > drivers/gpu/drm/exynos/exynos_dp_core.c | 22 ------ > 3 files changed, 86 insertions(+), 62 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 884923f..4254c2b 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -1,5 +1,7 @@ > config DRM_PTN3460 > tristate "PTN3460 DP/LVDS bridge" > depends on DRM > + depends on OF && I2C Adding I2C here is causing this circular dependency: scripts/kconfig/conf --silentoldconfig Kconfig drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER drivers/gpu/drm/Kconfig:28: symbol DRM_KMS_HELPER is selected by DRM_PTN3460 drivers/gpu/drm/bridge/Kconfig:1: symbol DRM_PTN3460 depends on I2C drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362: symbol FB_CYBER2000 depends on FB To solve this we just need to remove I2C from depends as DRM already selects I2C. This was already fixed by: commit 90bde571ad194adb039cb92a11a5b346f15eb610 Author: Arnd Bergmann <arnd@arndb.de> Date: Tue Mar 25 12:06:46 2014 +0100 drm/bridge: PTN3460 needs DRM_KMS_HELPER The recently added PTN3460 device driver uses interfaces that are provided by the KMS helper infrastructure, so we should explicitly select that to avoid this linker error: ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! We have to drop the I2C dependency to avoid a circular dependency chain, but that's ok because DRM already selects I2C. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Dave Airlie <airlied@redhat.com> But you may have introduced it again on a rebase. The following patch fixes it: diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 990b4b2..946d1ef 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -1,7 +1,6 @@ config DRM_PTN3460 tristate "PTN3460 DP/LVDS bridge" - depends on DRM - depends on OF && I2C + depends on DRM && OF select DRM_KMS_HELPER select DRM_PANEL ---help--- Gustavo
WARNING: multiple messages have this Message-ID (diff)
From: gustavo@padovan.org (Gustavo Padovan) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V9 04/14] drm/bridge: ptn3460: Convert to i2c driver model Date: Thu, 29 Jan 2015 12:29:19 -0200 [thread overview] Message-ID: <20150129142919.GN2001@joana> (raw) In-Reply-To: <1421771935-31618-5-git-send-email-ajaykumar.rs@samsung.com> Hi Ajay, 2015-01-20 Ajay Kumar <ajaykumar.rs@samsung.com>: > Use drm_bridge helpers to modify the driver to support > i2c driver model. > > Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> > Acked-by: Inki Dae <inki.dae@samsung.com> > Tested-by: Rahul Sharma <rahul.sharma@samsung.com> > Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Tested-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > Tested-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > --- > drivers/gpu/drm/bridge/Kconfig | 2 + > drivers/gpu/drm/bridge/ptn3460.c | 124 +++++++++++++++++++++---------- > drivers/gpu/drm/exynos/exynos_dp_core.c | 22 ------ > 3 files changed, 86 insertions(+), 62 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 884923f..4254c2b 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -1,5 +1,7 @@ > config DRM_PTN3460 > tristate "PTN3460 DP/LVDS bridge" > depends on DRM > + depends on OF && I2C Adding I2C here is causing this circular dependency: scripts/kconfig/conf --silentoldconfig Kconfig drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER drivers/gpu/drm/Kconfig:28: symbol DRM_KMS_HELPER is selected by DRM_PTN3460 drivers/gpu/drm/bridge/Kconfig:1: symbol DRM_PTN3460 depends on I2C drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC drivers/video/fbdev/Kconfig:374: symbol FB_CYBER2000_DDC depends on FB_CYBER2000 drivers/video/fbdev/Kconfig:362: symbol FB_CYBER2000 depends on FB To solve this we just need to remove I2C from depends as DRM already selects I2C. This was already fixed by: commit 90bde571ad194adb039cb92a11a5b346f15eb610 Author: Arnd Bergmann <arnd@arndb.de> Date: Tue Mar 25 12:06:46 2014 +0100 drm/bridge: PTN3460 needs DRM_KMS_HELPER The recently added PTN3460 device driver uses interfaces that are provided by the KMS helper infrastructure, so we should explicitly select that to avoid this linker error: ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined! We have to drop the I2C dependency to avoid a circular dependency chain, but that's ok because DRM already selects I2C. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Dave Airlie <airlied@redhat.com> But you may have introduced it again on a rebase. The following patch fixes it: diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 990b4b2..946d1ef 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -1,7 +1,6 @@ config DRM_PTN3460 tristate "PTN3460 DP/LVDS bridge" - depends on DRM - depends on OF && I2C + depends on DRM && OF select DRM_KMS_HELPER select DRM_PANEL ---help--- Gustavo
next prev parent reply other threads:[~2015-01-29 14:29 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-20 16:38 [PATCH V9 00/14] drm/exynos: few patches to enhance bridge chip support Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 01/14] drm/bridge: ptn3460: Few trivial cleanups Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 02/14] drm/bridge: do not pass drm_bridge_funcs to drm_bridge_init Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 04/14] drm/bridge: ptn3460: Convert to i2c driver model Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-29 14:29 ` Gustavo Padovan [this message] 2015-01-29 14:29 ` Gustavo Padovan 2015-01-29 14:39 ` Ajay kumar 2015-01-29 14:39 ` Ajay kumar 2015-01-20 16:38 ` [PATCH V9 06/14] drm/bridge: ptn3460: support drm_panel Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 07/14] drm/bridge: ptn3460: probe connector at the end of bridge attach Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 08/14] drm/bridge: ptn3460: use gpiod interface Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 09/14] Documentation: drm: bridge: move to video/bridge Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 10/14] Documentation: devicetree: Add vendor prefix for parade Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-02-04 15:12 ` Rob Herring 2015-02-04 15:12 ` Rob Herring 2015-01-20 16:38 ` [PATCH V9 12/14] drm/bridge: Add i2c based driver for ps8622/ps8625 bridge Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-29 14:42 ` Ajay kumar 2015-01-29 14:42 ` Ajay kumar [not found] ` <CAEC9eQMv_qbQJ=DKz=KznxkGbE2O08DUTwSDtpcfZeHtesEewA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-01-30 11:43 ` Thierry Reding 2015-01-30 11:43 ` Thierry Reding 2015-01-20 16:38 ` [PATCH V9 13/14] ARM: dts: snow: represent the connection between bridge and panel using videoport and endpoints Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar [not found] ` <1421771935-31618-14-git-send-email-ajaykumar.rs-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2015-01-23 7:01 ` Kukjin Kim 2015-01-23 7:01 ` Kukjin Kim 2015-01-27 4:27 ` Ajay kumar 2015-01-27 4:27 ` Ajay kumar 2015-02-04 15:30 ` Kukjin Kim 2015-02-04 15:30 ` Kukjin Kim [not found] ` <1421771935-31618-1-git-send-email-ajaykumar.rs-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2015-01-20 16:38 ` [PATCH 03/14] drm/bridge: make bridge registration independent of drm flow Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-30 15:37 ` Rob Clark 2015-01-30 15:37 ` Rob Clark [not found] ` <CAF6AEGs8GbgYMLmaPjGnXAv=Gsf6gMhNj+Zt0-2GKHOnHv4d4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-01-30 15:59 ` Russell King - ARM Linux 2015-01-30 15:59 ` Russell King - ARM Linux 2015-02-02 9:16 ` Ajay kumar 2015-02-02 9:16 ` Ajay kumar 2015-01-30 16:08 ` Daniel Stone 2015-01-30 16:08 ` Daniel Stone 2015-02-02 9:14 ` Ajay kumar 2015-02-02 9:14 ` Ajay kumar 2015-02-03 12:03 ` Thierry Reding 2015-02-03 12:03 ` Thierry Reding 2015-01-20 16:38 ` [PATCH V9 05/14] drm/exynos: dp: support drm_bridge Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 11/14] Documentation: bridge: Add documentation for ps8622 DT properties Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar 2015-01-20 16:38 ` [PATCH V9 14/14] ARM: dts: peach-pit: represent the connection between bridge and panel using videoport and endpoints Ajay Kumar 2015-01-20 16:38 ` Ajay Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150129142919.GN2001@joana \ --to=gustavo@padovan.org \ --cc=ajaykumar.rs@samsung.com \ --cc=ajaynumb@gmail.com \ --cc=bhushan.r@samsung.com \ --cc=daniel.vetter@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=inki.dae@samsung.com \ --cc=jg1.han@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=prashanth.g@samsung.com \ --cc=seanpaul@google.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.