Re: [PATCH] proc: show locks in /proc/pid/fdinfo/X

From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Vagin <avagin@parallels.com>
Cc: Andrey Vagin <avagin@openvz.org>, <linux-kernel@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jeff Layton <jlayton@poochiereds.net>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	"Cyrill Gorcunov" <gorcunov@openvz.org>,
	Pavel Emelyanov <xemul@parallels.com>,
	"Joe Perches" <joe@perches.com>
Subject: Re: [PATCH] proc: show locks in /proc/pid/fdinfo/X
Date: Thu, 12 Mar 2015 12:23:31 -0700	[thread overview]
Message-ID: <20150312122331.d8c27baf40d56e764f223193@linux-foundation.org> (raw)
In-Reply-To: <20150312155441.GA19139@paralelels.com>

On Thu, 12 Mar 2015 18:54:42 +0300 Andrew Vagin <avagin@parallels.com> wrote:

> v2: use seq_has_overflowed() properly

--- a/fs/proc/fd.c~proc-show-locks-in-proc-pid-fdinfo-x-v2
+++ a/fs/proc/fd.c
@@ -57,17 +57,15 @@ static int seq_show(struct seq_file *m,
 		   real_mount(file->f_path.mnt)->mnt_id);
 
 	show_fd_locks(m, file, files);
-	ret = seq_has_overflowed(m);
-	if (ret)
+	if (seq_has_overflowed(m))
 		goto out;
 
 	if (file->f_op->show_fdinfo)
 		file->f_op->show_fdinfo(m, file);
-	ret = seq_has_overflowed(m);
 
 out:
 	fput(file);
-	return ret;
+	return 0;
 }
 
 static int seq_fdinfo_open(struct inode *inode, struct file *file)


So it returns "success" when the output has overflowed?  Why this,
rather than returning an error?

