All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Tadeusz Struk <tadeusz.struk@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] crypto: algif - signedness bug in skcipher_recvmsg_async()
Date: Thu, 26 Mar 2015 12:13:12 +0300	[thread overview]
Message-ID: <20150326091312.GA21084@mwanda> (raw)

This needs to be signed because af_alg_make_sg() returns negative error
codes.

Fixes: a596999b7ddf ('crypto: algif - change algif_skcipher to be asynchronous')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c
index 506eb5f..142430f 100644
--- a/crypto/algif_skcipher.c
+++ b/crypto/algif_skcipher.c
@@ -537,7 +537,7 @@ static int skcipher_recvmsg_async(struct socket *sock, struct msghdr *msg,
 
 	while (iov_iter_count(&msg->msg_iter)) {
 		struct skcipher_async_rsgl *rsgl;
-		unsigned long used;
+		long used;
 
 		if (!ctx->used) {
 			err = skcipher_wait_for_data(sk, flags);

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Tadeusz Struk <tadeusz.struk@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] crypto: algif - signedness bug in skcipher_recvmsg_async()
Date: Thu, 26 Mar 2015 09:13:12 +0000	[thread overview]
Message-ID: <20150326091312.GA21084@mwanda> (raw)

This needs to be signed because af_alg_make_sg() returns negative error
codes.

Fixes: a596999b7ddf ('crypto: algif - change algif_skcipher to be asynchronous')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/crypto/algif_skcipher.c b/crypto/algif_skcipher.c
index 506eb5f..142430f 100644
--- a/crypto/algif_skcipher.c
+++ b/crypto/algif_skcipher.c
@@ -537,7 +537,7 @@ static int skcipher_recvmsg_async(struct socket *sock, struct msghdr *msg,
 
 	while (iov_iter_count(&msg->msg_iter)) {
 		struct skcipher_async_rsgl *rsgl;
-		unsigned long used;
+		long used;
 
 		if (!ctx->used) {
 			err = skcipher_wait_for_data(sk, flags);

             reply	other threads:[~2015-03-26  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  9:13 Dan Carpenter [this message]
2015-03-26  9:13 ` [patch -next] crypto: algif - signedness bug in skcipher_recvmsg_async() Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150326091312.GA21084@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=tadeusz.struk@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.