From: kbuild test robot <fengguang.wu@intel.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: kbuild-all@01.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Jie Yang <yang.jie@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings
Date: Mon, 13 Apr 2015 03:06:26 +0800 [thread overview]
Message-ID: <20150412190626.GA28170@athens.lkp.intel.com> (raw)
In-Reply-To: <201504130318.BufQJB8v%fengguang.wu@intel.com>
sound/soc/intel/common/sst-ipc.c:287:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Jin Yao <yao.jin@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
sst-ipc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/sound/soc/intel/common/sst-ipc.c
+++ b/sound/soc/intel/common/sst-ipc.c
@@ -283,8 +283,7 @@ void sst_ipc_fini(struct sst_generic_ipc
if (ipc->tx_thread)
kthread_stop(ipc->tx_thread);
- if (ipc->msg)
- kfree(ipc->msg);
+ kfree(ipc->msg);
}
EXPORT_SYMBOL_GPL(sst_ipc_fini);
next parent reply other threads:[~2015-04-12 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201504130318.BufQJB8v%fengguang.wu@intel.com>
2015-04-12 19:06 ` kbuild test robot [this message]
2015-04-13 1:03 ` [alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings Jin, Yao
2015-04-13 10:38 ` Mark Brown
2015-04-13 10:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150412190626.GA28170@athens.lkp.intel.com \
--to=fengguang.wu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kbuild-all@01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=yang.jie@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.