All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wei-Ning Huang <wnhuang@google.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
	Stephen Warren <swarren@wwwdotorg.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eduardo Valentin <edubezval@gmail.com>,
	Mikko Perttunen <mikko.perttunen@kapsi.fi>,
	linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
	Zhang Rui <rui.zhang@intel.com>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 14/15] thermal: Add Mediatek thermal controller support
Date: Fri, 15 May 2015 08:12:22 +0200	[thread overview]
Message-ID: <20150515061222.GK6325@pengutronix.de> (raw)
In-Reply-To: <CABicQ-XxXbMMnYyFAst=Xk1HMOXc6N1-J1bvyutMFY_=iNd0fg@mail.gmail.com>

Hi Wei-Ning,

On Fri, May 15, 2015 at 01:33:02PM +0800, Wei-Ning Huang wrote:
>    Hi Sascha,
>    I tried these patches but I didn't see any entries under
>    '/sys/class/thermal', am I missing something?
>    Wei-Ning

Please write a mail to me rather than to Paul if you want me to react.

You'll need a dts snippet that registers a thermal zone. Try the
attached patch. I haven't posted it because it only contains my testing
code which registers a fake gpio controlled fan.

Sascha

-----------------------------8<-----------------------------

>From 2ea6d94fe430c317064d06b46a8d0d2036ca4236 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Tue, 12 May 2015 09:24:25 +0200
Subject: [PATCH] ARM64: dts: mt8173-evb: debugging: Add fake thermal zone

This adds a thermal zone for the CPU which is controlled by a fan. No
fan exists on this board and the temperatures are bogus. This is only
for debugging purposes until the cpufreq driver is available.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 39 +++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index 43d5401..0a1f905 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -14,6 +14,7 @@
 
 /dts-v1/;
 #include "mt8173.dtsi"
+#include <dt-bindings/thermal/thermal.h>
 
 / {
 	model = "mediatek,mt8173-evb";
@@ -31,6 +32,44 @@
 	};
 
 	chosen { };
+
+	fan: gpio_fan {
+		compatible = "gpio-fan";
+		gpios = <&pio 24 0>;
+		gpio-fan,speed-map = <0    0
+				      4500 1>;
+		#cooling-cells = <2>;
+	};
+
+	thermal-zones {
+		cpu_thermal: cpu_thermal {
+			polling-delay-passive = <1000>; /* milliseconds */
+			polling-delay = <0>; /* milliseconds */
+
+			thermal-sensors = <&thermal 0>;
+
+			trips {
+				cpu_passive: cpu_passive {
+					temperature = <47000>; /* millicelsius */
+					hysteresis = <2000>; /* millicelsius */
+					type = "passive";
+				};
+
+				cpu_crit {
+					temperature = <90000>; /* millicelsius */
+					hysteresis = <2000>; /* millicelsius */
+					type = "critical";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cpu_passive>;
+					cooling-device = <&fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+	};
 };
 
 &uart0 {
-- 
2.1.4


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/15] thermal: Add Mediatek thermal controller support
Date: Fri, 15 May 2015 08:12:22 +0200	[thread overview]
Message-ID: <20150515061222.GK6325@pengutronix.de> (raw)
In-Reply-To: <CABicQ-XxXbMMnYyFAst=Xk1HMOXc6N1-J1bvyutMFY_=iNd0fg@mail.gmail.com>

Hi Wei-Ning,

On Fri, May 15, 2015 at 01:33:02PM +0800, Wei-Ning Huang wrote:
>    Hi Sascha,
>    I tried these patches but I didn't see any entries under
>    '/sys/class/thermal', am I missing something?
>    Wei-Ning

Please write a mail to me rather than to Paul if you want me to react.

You'll need a dts snippet that registers a thermal zone. Try the
attached patch. I haven't posted it because it only contains my testing
code which registers a fake gpio controlled fan.

Sascha

-----------------------------8<-----------------------------

>From 2ea6d94fe430c317064d06b46a8d0d2036ca4236 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Tue, 12 May 2015 09:24:25 +0200
Subject: [PATCH] ARM64: dts: mt8173-evb: debugging: Add fake thermal zone

This adds a thermal zone for the CPU which is controlled by a fan. No
fan exists on this board and the temperatures are bogus. This is only
for debugging purposes until the cpufreq driver is available.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 39 +++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index 43d5401..0a1f905 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
@@ -14,6 +14,7 @@
 
 /dts-v1/;
 #include "mt8173.dtsi"
+#include <dt-bindings/thermal/thermal.h>
 
 / {
 	model = "mediatek,mt8173-evb";
@@ -31,6 +32,44 @@
 	};
 
 	chosen { };
+
+	fan: gpio_fan {
+		compatible = "gpio-fan";
+		gpios = <&pio 24 0>;
+		gpio-fan,speed-map = <0    0
+				      4500 1>;
+		#cooling-cells = <2>;
+	};
+
+	thermal-zones {
+		cpu_thermal: cpu_thermal {
+			polling-delay-passive = <1000>; /* milliseconds */
+			polling-delay = <0>; /* milliseconds */
+
+			thermal-sensors = <&thermal 0>;
+
+			trips {
+				cpu_passive: cpu_passive {
+					temperature = <47000>; /* millicelsius */
+					hysteresis = <2000>; /* millicelsius */
+					type = "passive";
+				};
+
+				cpu_crit {
+					temperature = <90000>; /* millicelsius */
+					hysteresis = <2000>; /* millicelsius */
+					type = "critical";
+				};
+			};
+
+			cooling-maps {
+				map0 {
+					trip = <&cpu_passive>;
+					cooling-device = <&fan THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+				};
+			};
+		};
+	};
 };
 
 &uart0 {
-- 
2.1.4


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2015-05-15  6:12 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  8:52 [PATCH v3] Thermal hardware trip points and Mediatek thermal driver Sascha Hauer
2015-05-13  8:52 ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 01/15] thermal: consistently use int for temperatures Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-20  7:12   ` Mikko Perttunen
2015-05-20  7:12     ` Mikko Perttunen
2015-05-20  8:34     ` Sascha Hauer
2015-05-20  8:34       ` Sascha Hauer
2015-05-20  8:42       ` Mikko Perttunen
2015-05-20  8:42         ` Mikko Perttunen
2015-05-13  8:52 ` [PATCH 02/15] thermal: trivial: fix typo in comment Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 03/15] thermal: remove useless call to thermal_zone_device_set_polling Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 04/15] thermal: Use IS_ENABLED instead of #ifdef Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 05/15] thermal: Add comment explaining test for critical temperature Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-20  7:18   ` Mikko Perttunen
2015-05-20  7:18     ` Mikko Perttunen
2015-05-13  8:52 ` [PATCH 06/15] thermal: inline only once used function Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-20  7:28   ` Mikko Perttunen
2015-05-20  7:28     ` Mikko Perttunen
2015-05-13  8:52 ` [PATCH 07/15] thermal: streamline get_trend callbacks Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 08/15] thermal: Allow sensor ops to fail with -ENOSYS Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 09/15] thermal: of: always set sensor related callbacks Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 10/15] thermal: Make struct thermal_zone_device_ops const Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 11/15] thermal: thermal: Add support for hardware-tracked trip points Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-18  9:06   ` Mikko Perttunen
2015-05-18  9:06     ` Mikko Perttunen
2015-05-18 12:09     ` Sascha Hauer
2015-05-18 12:09       ` Sascha Hauer
2015-05-18 18:44       ` Brian Norris
2015-05-18 18:44         ` Brian Norris
2015-05-18 19:13         ` Mikko Perttunen
2015-05-18 19:13           ` Mikko Perttunen
2015-05-18 20:28           ` Brian Norris
2015-05-18 20:28             ` Brian Norris
2015-05-19 12:43             ` Mikko Perttunen
2015-05-19 12:43               ` Mikko Perttunen
2015-05-19 14:05         ` Sascha Hauer
2015-05-19 14:05           ` Sascha Hauer
2015-05-19 13:58       ` Sascha Hauer
2015-05-19 13:58         ` Sascha Hauer
2015-05-19 14:05         ` Mikko Perttunen
2015-05-19 14:05           ` Mikko Perttunen
2015-05-20 13:21           ` Sascha Hauer
2015-05-20 13:21             ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 12/15] thermal: of: implement .set_trips for device tree thermal zones Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-18  9:09   ` Mikko Perttunen
2015-05-18  9:09     ` Mikko Perttunen
2015-05-13  8:52 ` [PATCH 13/15] dt-bindings: thermal: Add binding document for Mediatek thermal controller Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 14/15] thermal: Add Mediatek thermal controller support Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-14  9:52   ` Paul Bolle
2015-05-14  9:52     ` Paul Bolle
     [not found]     ` <CABicQ-XxXbMMnYyFAst=Xk1HMOXc6N1-J1bvyutMFY_=iNd0fg@mail.gmail.com>
2015-05-15  6:12       ` Sascha Hauer [this message]
2015-05-15  6:12         ` Sascha Hauer
2015-05-13  8:52 ` [PATCH 15/15] ARM64: dts: mt8173: Add thermal/auxadc device nodes Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer
2015-05-13  8:52   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150515061222.GK6325@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=computersforpeace@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mikko.perttunen@kapsi.fi \
    --cc=pebolle@tiscali.nl \
    --cc=rui.zhang@intel.com \
    --cc=swarren@wwwdotorg.org \
    --cc=wnhuang@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.