From: Dan Williams <dan.j.williams@intel.com> To: axboe@kernel.dk Cc: linux-nvdimm@lists.01.org, neilb@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, Ross Zwisler <ross.zwisler@linux.intel.com>, hch@lst.de Subject: [PATCH v3 10/21] pmem: Dynamically allocate partition numbers Date: Wed, 20 May 2015 16:57:06 -0400 [thread overview] Message-ID: <20150520205706.32249.99479.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <20150520205536.32249.89779.stgit@dwillia2-desk3.amr.corp.intel.com> From: Ross Zwisler <ross.zwisler@linux.intel.com> Dynamically allocate minor numbers for partitions instead of statically preallocating them. It gives us a simpler minors scheme, and makes it so we get a consistent major when moving past partition 16. Here's what happens with the current code: pmem0 249:0 0 63.5G 0 rom ├─pmem0p1 249:1 0 1G 0 part ├─pmem0p2 249:2 0 1G 0 part ├─pmem0p3 249:3 0 1G 0 part ├─pmem0p4 249:4 0 1G 0 part ├─pmem0p5 249:5 0 1G 0 part ├─pmem0p6 249:6 0 1G 0 part ├─pmem0p7 249:7 0 1G 0 part ├─pmem0p8 249:8 0 1G 0 part ├─pmem0p9 249:9 0 1G 0 part ├─pmem0p10 249:10 0 1G 0 part ├─pmem0p11 249:11 0 1G 0 part ├─pmem0p12 249:12 0 1G 0 part ├─pmem0p13 249:13 0 1G 0 part ├─pmem0p14 249:14 0 1G 0 part ├─pmem0p15 249:15 0 1G 0 part ├─pmem0p16 259:0 0 1G 0 part ├─pmem0p17 259:1 0 1G 0 part └─pmem0p18 259:2 0 1G 0 part Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/block/nd/pmem.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/nd/pmem.c b/drivers/block/nd/pmem.c index 529a1444a918..fc34677d0f48 100644 --- a/drivers/block/nd/pmem.c +++ b/drivers/block/nd/pmem.c @@ -26,8 +26,6 @@ #include <linux/nd.h> #include "nd.h" -#define PMEM_MINORS 16 - struct pmem_device { struct request_queue *pmem_queue; struct gendisk *pmem_disk; @@ -156,12 +154,12 @@ static struct pmem_device *pmem_alloc(struct device *dev, struct resource *res, blk_queue_max_hw_sectors(pmem->pmem_queue, 1024); blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); - disk = alloc_disk(PMEM_MINORS); + disk = alloc_disk(0); if (!disk) goto out_free_queue; disk->major = pmem_major; - disk->first_minor = PMEM_MINORS * id; + disk->first_minor = 0; disk->fops = &pmem_fops; disk->private_data = pmem; disk->queue = pmem->pmem_queue;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: axboe@kernel.dk Cc: linux-nvdimm@ml01.01.org, neilb@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, Ross Zwisler <ross.zwisler@linux.intel.com>, hch@lst.de Subject: [PATCH v3 10/21] pmem: Dynamically allocate partition numbers Date: Wed, 20 May 2015 16:57:06 -0400 [thread overview] Message-ID: <20150520205706.32249.99479.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <20150520205536.32249.89779.stgit@dwillia2-desk3.amr.corp.intel.com> From: Ross Zwisler <ross.zwisler@linux.intel.com> Dynamically allocate minor numbers for partitions instead of statically preallocating them. It gives us a simpler minors scheme, and makes it so we get a consistent major when moving past partition 16. Here's what happens with the current code: pmem0 249:0 0 63.5G 0 rom ├─pmem0p1 249:1 0 1G 0 part ├─pmem0p2 249:2 0 1G 0 part ├─pmem0p3 249:3 0 1G 0 part ├─pmem0p4 249:4 0 1G 0 part ├─pmem0p5 249:5 0 1G 0 part ├─pmem0p6 249:6 0 1G 0 part ├─pmem0p7 249:7 0 1G 0 part ├─pmem0p8 249:8 0 1G 0 part ├─pmem0p9 249:9 0 1G 0 part ├─pmem0p10 249:10 0 1G 0 part ├─pmem0p11 249:11 0 1G 0 part ├─pmem0p12 249:12 0 1G 0 part ├─pmem0p13 249:13 0 1G 0 part ├─pmem0p14 249:14 0 1G 0 part ├─pmem0p15 249:15 0 1G 0 part ├─pmem0p16 259:0 0 1G 0 part ├─pmem0p17 259:1 0 1G 0 part └─pmem0p18 259:2 0 1G 0 part Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/block/nd/pmem.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/nd/pmem.c b/drivers/block/nd/pmem.c index 529a1444a918..fc34677d0f48 100644 --- a/drivers/block/nd/pmem.c +++ b/drivers/block/nd/pmem.c @@ -26,8 +26,6 @@ #include <linux/nd.h> #include "nd.h" -#define PMEM_MINORS 16 - struct pmem_device { struct request_queue *pmem_queue; struct gendisk *pmem_disk; @@ -156,12 +154,12 @@ static struct pmem_device *pmem_alloc(struct device *dev, struct resource *res, blk_queue_max_hw_sectors(pmem->pmem_queue, 1024); blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); - disk = alloc_disk(PMEM_MINORS); + disk = alloc_disk(0); if (!disk) goto out_free_queue; disk->major = pmem_major; - disk->first_minor = PMEM_MINORS * id; + disk->first_minor = 0; disk->fops = &pmem_fops; disk->private_data = pmem; disk->queue = pmem->pmem_queue;
next prev parent reply other threads:[~2015-05-20 20:57 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-20 20:56 [PATCH v3 00/21] libnd: non-volatile memory device support Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:56 ` [PATCH v3 01/21] e820, efi: add ACPI 6.0 persistent memory types Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:56 ` [PATCH v3 02/21] libnd, nfit: initial libnd infrastructure and NFIT support Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-21 13:55 ` Toshi Kani 2015-05-21 13:55 ` Toshi Kani 2015-05-21 15:56 ` Dan Williams 2015-05-21 15:56 ` Dan Williams 2015-05-21 17:25 ` Toshi Kani 2015-05-21 17:25 ` Toshi Kani 2015-05-21 17:49 ` Moore, Robert 2015-05-21 17:49 ` Moore, Robert 2015-05-21 18:01 ` Toshi Kani 2015-05-21 18:01 ` Toshi Kani 2015-05-21 19:06 ` Dan Williams 2015-05-21 19:06 ` Dan Williams 2015-05-21 19:44 ` Toshi Kani 2015-05-21 19:44 ` Toshi Kani 2015-05-21 19:44 ` Toshi Kani 2015-05-21 19:59 ` Toshi Kani 2015-05-21 19:59 ` Toshi Kani 2015-05-21 19:59 ` Toshi Kani 2015-05-21 20:59 ` Linda Knippers 2015-05-21 20:59 ` Linda Knippers 2015-05-21 20:59 ` Linda Knippers 2015-05-21 21:34 ` Dan Williams 2015-05-21 21:34 ` Dan Williams 2015-05-21 21:34 ` Dan Williams 2015-05-21 22:11 ` Toshi Kani 2015-05-21 22:11 ` Toshi Kani 2015-05-22 14:58 ` Moore, Robert 2015-05-22 14:58 ` Moore, Robert 2015-05-22 15:21 ` Toshi Kani 2015-05-22 15:21 ` Toshi Kani 2015-05-22 16:12 ` Moore, Robert 2015-05-22 16:12 ` Moore, Robert 2015-05-20 20:56 ` [PATCH v3 03/21] libnd: control character device and libnd bus sysfs attributes Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:56 ` [PATCH v3 04/21] libnd, nfit: dimm/memory-devices Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:56 ` [PATCH v3 05/21] libnd: control (ioctl) messages for libnd bus and dimm devices Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:56 ` [PATCH v3 06/21] libnd, nd_dimm: dimm driver and base libnd device-driver infrastructure Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:56 ` [PATCH v3 07/21] libnd, nfit: regions (block-data-window, persistent memory, volatile memory) Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:56 ` [PATCH v3 08/21] libnd: support for legacy (non-aliasing) nvdimms Dan Williams 2015-05-20 20:56 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 09/21] libnd, nd_pmem: add libnd support to the pmem driver Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-23 14:39 ` Christoph Hellwig 2015-05-23 16:59 ` Dan Williams 2015-05-20 20:57 ` Dan Williams [this message] 2015-05-20 20:57 ` [PATCH v3 10/21] pmem: Dynamically allocate partition numbers Dan Williams 2015-05-20 20:57 ` [PATCH v3 11/21] libnd, nfit: add interleave-set state-tracking infrastructure Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 12/21] libnd: namespace indices: read and validate Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 13/21] libnd: pmem label sets and namespace instantiation Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 14/21] libnd: blk labels " Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-22 18:37 ` Elliott, Robert (Server Storage) 2015-05-22 18:37 ` Elliott, Robert (Server Storage) 2015-05-22 18:37 ` Elliott, Robert (Server Storage) 2015-05-22 18:51 ` Dan Williams 2015-05-22 18:51 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 15/21] libnd: write pmem label set Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 16/21] libnd: write blk " Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 17/21] libnd: infrastructure for btt devices Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 18/21] nd_btt: atomic sector updates Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-22 21:16 ` Elliott, Robert (Server Storage) 2015-05-22 21:16 ` Elliott, Robert (Server Storage) 2015-05-22 21:39 ` Dan Williams 2015-05-22 21:39 ` Dan Williams 2015-05-20 20:57 ` [PATCH v3 19/21] libnd, nfit, nd_blk: driver for BLK-mode access persistent memory Dan Williams 2015-05-20 20:57 ` Dan Williams 2015-05-20 20:58 ` [PATCH v3 20/21] nfit-test: manufactured NFITs for interface development Dan Williams 2015-05-20 20:58 ` Dan Williams 2015-05-25 7:02 ` Elliott, Robert (Server Storage) 2015-05-25 7:02 ` Elliott, Robert (Server Storage) 2015-05-20 20:58 ` [PATCH v3 21/21] libnd: Non-Volatile Devices Dan Williams 2015-05-20 20:58 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150520205706.32249.99479.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=axboe@kernel.dk \ --cc=gregkh@linuxfoundation.org \ --cc=hch@lst.de \ --cc=jmoyer@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mingo@kernel.org \ --cc=neilb@suse.de \ --cc=ross.zwisler@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.