From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sverd Johnsen <sverd.johnsen@googlemail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: kernel BUG at fs/9p/acl.c:96! 4.1.1 bz #94531
Date: Sat, 11 Jul 2015 19:55:25 +0100 [thread overview]
Message-ID: <20150711185524.GI17109@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAGmahrS76st=YUrysd+hi3Obnmggr_7dLNAUJDjNTtQXObFgng@mail.gmail.com>
On Wed, Jul 08, 2015 at 03:58:54PM +0200, Sverd Johnsen wrote:
> I filed this a few months ago and can still be reproduced easily with
> kernel 4.1.1:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=94531
>
> [ 224.248568] ------------[ cut here ]------------
> [ 224.252792] kernel BUG at fs/9p/acl.c:96!
See if this fixes the sucker on your setup; it should've removed the
inode from hash, since leaving it there means that the next attempt
to look it up via iget5_locked() will just succeed, with no indication
of failed inode setup...
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c
index 09e4433..e8aa57d 100644
--- a/fs/9p/vfs_inode_dotl.c
+++ b/fs/9p/vfs_inode_dotl.c
@@ -149,8 +149,7 @@ static struct inode *v9fs_qid_iget_dotl(struct super_block *sb,
unlock_new_inode(inode);
return inode;
error:
- unlock_new_inode(inode);
- iput(inode);
+ iget_failed(inode);
return ERR_PTR(retval);
}
prev parent reply other threads:[~2015-07-11 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 13:58 kernel BUG at fs/9p/acl.c:96! 4.1.1 bz #94531 Sverd Johnsen
2015-07-11 18:55 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150711185524.GI17109@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sverd.johnsen@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.