All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: Punit Agrawal <punit.agrawal@arm.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Eduardo Valentin <edubezval@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.de>, Peter Feuerer <peter@piie.net>,
	Heiko Stuebner <heiko@sntech.de>,
	Lukasz Majewski <l.majewski@samsung.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Maxime Ripard <maxime.ripard>
Subject: Re: [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 12:37:58 +0200	[thread overview]
Message-ID: <20150723103758.GI18700@pengutronix.de> (raw)
In-Reply-To: <744357E9AAD1214791ACBA4B0B9092630153E699@SHSMSX101.ccr.corp.intel.com>

Hi Zhang,

On Tue, Jul 21, 2015 at 01:35:31PM +0000, Zhang, Rui wrote:
> > >
> Patch applied.

Thanks for applying. I missed to convert another place, so we get a new
compiler warning. The attached patch fixes this (suitable for git rebase
--autosquash). Please let me know if you can handle this or if you
prefer a new patch instead.

Thanks
 Sascha


-----------------------------8<-------------------------------------

From 4907a7c32fd16eaf9f31d9f904276c9a0176b717 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Thu, 23 Jul 2015 12:32:31 +0200
Subject: [PATCH] fixup! thermal: consistently use int for temperatures
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

fixes:
drivers/power/charger-manager.c: In function ‘cm_get_battery_temperature’:
drivers/power/charger-manager.c:622:45: warning: passing argument 2 of ‘thermal_zone_get_temp’ from incompatible pointer type
   ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp);

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/power/charger-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
index 1c202cc..907293e 100644
--- a/drivers/power/charger-manager.c
+++ b/drivers/power/charger-manager.c
@@ -619,7 +619,7 @@ static int cm_get_battery_temperature(struct charger_manager *cm,
 
 #ifdef CONFIG_THERMAL
 	if (cm->tzd_batt) {
-		ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp);
+		ret = thermal_zone_get_temp(cm->tzd_batt, temp);
 		if (!ret)
 			/* Calibrate temperature unit */
 			*temp /= 100;
-- 
2.1.4


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: Punit Agrawal <punit.agrawal@arm.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Eduardo Valentin <edubezval@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.de>, Peter Feuerer <peter@piie.net>,
	Heiko Stuebner <heiko@sntech.de>,
	Lukasz Majewski <l.majewski@samsung.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Darren Hart <dvhart@infradead.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 12:37:58 +0200	[thread overview]
Message-ID: <20150723103758.GI18700@pengutronix.de> (raw)
In-Reply-To: <744357E9AAD1214791ACBA4B0B9092630153E699@SHSMSX101.ccr.corp.intel.com>

Hi Zhang,

On Tue, Jul 21, 2015 at 01:35:31PM +0000, Zhang, Rui wrote:
> > >
> Patch applied.

Thanks for applying. I missed to convert another place, so we get a new
compiler warning. The attached patch fixes this (suitable for git rebase
--autosquash). Please let me know if you can handle this or if you
prefer a new patch instead.

Thanks
 Sascha


-----------------------------8<-------------------------------------

>From 4907a7c32fd16eaf9f31d9f904276c9a0176b717 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Thu, 23 Jul 2015 12:32:31 +0200
Subject: [PATCH] fixup! thermal: consistently use int for temperatures
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

fixes:
drivers/power/charger-manager.c: In function ‘cm_get_battery_temperature’:
drivers/power/charger-manager.c:622:45: warning: passing argument 2 of ‘thermal_zone_get_temp’ from incompatible pointer type
   ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp);

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/power/charger-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
index 1c202cc..907293e 100644
--- a/drivers/power/charger-manager.c
+++ b/drivers/power/charger-manager.c
@@ -619,7 +619,7 @@ static int cm_get_battery_temperature(struct charger_manager *cm,
 
 #ifdef CONFIG_THERMAL
 	if (cm->tzd_batt) {
-		ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp);
+		ret = thermal_zone_get_temp(cm->tzd_batt, temp);
 		if (!ret)
 			/* Calibrate temperature unit */
 			*temp /= 100;
-- 
2.1.4


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 12:37:58 +0200	[thread overview]
Message-ID: <20150723103758.GI18700@pengutronix.de> (raw)
In-Reply-To: <744357E9AAD1214791ACBA4B0B9092630153E699@SHSMSX101.ccr.corp.intel.com>

Hi Zhang,

On Tue, Jul 21, 2015 at 01:35:31PM +0000, Zhang, Rui wrote:
> > >
> Patch applied.

Thanks for applying. I missed to convert another place, so we get a new
compiler warning. The attached patch fixes this (suitable for git rebase
--autosquash). Please let me know if you can handle this or if you
prefer a new patch instead.

Thanks
 Sascha


-----------------------------8<-------------------------------------

>From 4907a7c32fd16eaf9f31d9f904276c9a0176b717 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Thu, 23 Jul 2015 12:32:31 +0200
Subject: [PATCH] fixup! thermal: consistently use int for temperatures
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

fixes:
drivers/power/charger-manager.c: In function ?cm_get_battery_temperature?:
drivers/power/charger-manager.c:622:45: warning: passing argument 2 of ?thermal_zone_get_temp? from incompatible pointer type
   ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp);

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/power/charger-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
index 1c202cc..907293e 100644
--- a/drivers/power/charger-manager.c
+++ b/drivers/power/charger-manager.c
@@ -619,7 +619,7 @@ static int cm_get_battery_temperature(struct charger_manager *cm,
 
 #ifdef CONFIG_THERMAL
 	if (cm->tzd_batt) {
-		ret = thermal_zone_get_temp(cm->tzd_batt, (unsigned long *)temp);
+		ret = thermal_zone_get_temp(cm->tzd_batt, temp);
 		if (!ret)
 			/* Calibrate temperature unit */
 			*temp /= 100;
-- 
2.1.4


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: Punit Agrawal <punit.agrawal@arm.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Eduardo Valentin <edubezval@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.de>, Peter Feuerer <peter@piie.net>,
	Heiko Stuebner <heiko@sntech.de>,
	Lukasz Majewski <l.majewski@samsung.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Maxime Ripard <maxime.ripard>
Subject: Re: [lm-sensors] [PATCH v2] thermal: consistently use int for temperatures
Date: Thu, 23 Jul 2015 10:37:58 +0000	[thread overview]
Message-ID: <20150723103758.GI18700@pengutronix.de> (raw)
In-Reply-To: <744357E9AAD1214791ACBA4B0B9092630153E699@SHSMSX101.ccr.corp.intel.com>

SGkgWmhhbmcsCgpPbiBUdWUsIEp1bCAyMSwgMjAxNSBhdCAwMTozNTozMVBNICswMDAwLCBaaGFu
ZywgUnVpIHdyb3RlOgo+ID4gPgo+IFBhdGNoIGFwcGxpZWQuCgpUaGFua3MgZm9yIGFwcGx5aW5n
LiBJIG1pc3NlZCB0byBjb252ZXJ0IGFub3RoZXIgcGxhY2UsIHNvIHdlIGdldCBhIG5ldwpjb21w
aWxlciB3YXJuaW5nLiBUaGUgYXR0YWNoZWQgcGF0Y2ggZml4ZXMgdGhpcyAoc3VpdGFibGUgZm9y
IGdpdCByZWJhc2UKLS1hdXRvc3F1YXNoKS4gUGxlYXNlIGxldCBtZSBrbm93IGlmIHlvdSBjYW4g
aGFuZGxlIHRoaXMgb3IgaWYgeW91CnByZWZlciBhIG5ldyBwYXRjaCBpbnN0ZWFkLgoKVGhhbmtz
CiBTYXNjaGEKCgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLTg8LS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQoKRnJvbSA0OTA3YTdjMzJmZDE2ZWFmOWYzMWQ5ZjkwNDI3
NmM5YTAxNzZiNzE3IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBTYXNjaGEgSGF1ZXIg
PHMuaGF1ZXJAcGVuZ3V0cm9uaXguZGU+CkRhdGU6IFRodSwgMjMgSnVsIDIwMTUgMTI6MzI6MzEg
KzAyMDAKU3ViamVjdDogW1BBVENIXSBmaXh1cCEgdGhlcm1hbDogY29uc2lzdGVudGx5IHVzZSBp
bnQgZm9yIHRlbXBlcmF0dXJlcwpNSU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQv
cGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKZml4
ZXM6CmRyaXZlcnMvcG93ZXIvY2hhcmdlci1tYW5hZ2VyLmM6IEluIGZ1bmN0aW9uIOKAmGNtX2dl
dF9iYXR0ZXJ5X3RlbXBlcmF0dXJl4oCZOgpkcml2ZXJzL3Bvd2VyL2NoYXJnZXItbWFuYWdlci5j
OjYyMjo0NTogd2FybmluZzogcGFzc2luZyBhcmd1bWVudCAyIG9mIOKAmHRoZXJtYWxfem9uZV9n
ZXRfdGVtcOKAmSBmcm9tIGluY29tcGF0aWJsZSBwb2ludGVyIHR5cGUKICAgcmV0ID0gdGhlcm1h
bF96b25lX2dldF90ZW1wKGNtLT50emRfYmF0dCwgKHVuc2lnbmVkIGxvbmcgKil0ZW1wKTsKClNp
Z25lZC1vZmYtYnk6IFNhc2NoYSBIYXVlciA8cy5oYXVlckBwZW5ndXRyb25peC5kZT4KLS0tCiBk
cml2ZXJzL3Bvd2VyL2NoYXJnZXItbWFuYWdlci5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEg
aW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wb3dlci9j
aGFyZ2VyLW1hbmFnZXIuYyBiL2RyaXZlcnMvcG93ZXIvY2hhcmdlci1tYW5hZ2VyLmMKaW5kZXgg
MWMyMDJjYy4uOTA3MjkzZSAxMDA2NDQKLS0tIGEvZHJpdmVycy9wb3dlci9jaGFyZ2VyLW1hbmFn
ZXIuYworKysgYi9kcml2ZXJzL3Bvd2VyL2NoYXJnZXItbWFuYWdlci5jCkBAIC02MTksNyArNjE5
LDcgQEAgc3RhdGljIGludCBjbV9nZXRfYmF0dGVyeV90ZW1wZXJhdHVyZShzdHJ1Y3QgY2hhcmdl
cl9tYW5hZ2VyICpjbSwKIAogI2lmZGVmIENPTkZJR19USEVSTUFMCiAJaWYgKGNtLT50emRfYmF0
dCkgewotCQlyZXQgPSB0aGVybWFsX3pvbmVfZ2V0X3RlbXAoY20tPnR6ZF9iYXR0LCAodW5zaWdu
ZWQgbG9uZyAqKXRlbXApOworCQlyZXQgPSB0aGVybWFsX3pvbmVfZ2V0X3RlbXAoY20tPnR6ZF9i
YXR0LCB0ZW1wKTsKIAkJaWYgKCFyZXQpCiAJCQkvKiBDYWxpYnJhdGUgdGVtcGVyYXR1cmUgdW5p
dCAqLwogCQkJKnRlbXAgLz0gMTAwOwotLSAKMi4xLjQKCgotLSAKUGVuZ3V0cm9uaXggZS5LLiAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwK
SW5kdXN0cmlhbCBMaW51eCBTb2x1dGlvbnMgICAgICAgICAgICAgICAgIHwgaHR0cDovL3d3dy5w
ZW5ndXRyb25peC5kZS8gIHwKUGVpbmVyIFN0ci4gNi04LCAzMTEzNyBIaWxkZXNoZWltLCBHZXJt
YW55IHwgUGhvbmU6ICs0OS01MTIxLTIwNjkxNy0wICAgIHwKQW10c2dlcmljaHQgSGlsZGVzaGVp
bSwgSFJBIDI2ODYgICAgICAgICAgIHwgRmF4OiAgICs0OS01MTIxLTIwNjkxNy01NTU1IHwKCl9f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMg
bWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNl
bnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw=

  reply	other threads:[~2015-07-23 10:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21  7:21 [PATCH v2] thermal: consistently use int for temperatures Sascha Hauer
2015-07-21  7:21 ` [lm-sensors] " Sascha Hauer
2015-07-21  7:21 ` Sascha Hauer
2015-07-21 10:52 ` Punit Agrawal
2015-07-21 10:52   ` [lm-sensors] " Punit Agrawal
2015-07-21 10:52   ` Punit Agrawal
2015-07-21 10:52   ` Punit Agrawal
2015-07-21 13:35   ` Zhang, Rui
2015-07-21 13:35     ` [lm-sensors] " Zhang, Rui
2015-07-21 13:35     ` Zhang, Rui
2015-07-21 13:35     ` Zhang, Rui
2015-07-23 10:37     ` Sascha Hauer [this message]
2015-07-23 10:37       ` [lm-sensors] " Sascha Hauer
2015-07-23 10:37       ` Sascha Hauer
2015-07-23 10:37       ` Sascha Hauer
2015-07-24  1:31       ` Zhang, Rui
2015-07-24  1:31         ` [lm-sensors] " Zhang, Rui
2015-07-24  1:31         ` Zhang, Rui
2015-07-24  1:31         ` Zhang, Rui
2015-07-24  6:12         ` [PATCH v3] " Sascha Hauer
2015-07-24  6:12           ` [lm-sensors] " Sascha Hauer
2015-07-24  6:12           ` Sascha Hauer
2015-07-23 12:07 ` [PATCH v2] " Pavel Machek
2015-07-23 12:07   ` [lm-sensors] " Pavel Machek
2015-07-23 12:07   ` Pavel Machek
2015-07-23 12:07   ` Pavel Machek
2015-07-24  6:29   ` Sascha Hauer
2015-07-24  6:29     ` [lm-sensors] " Sascha Hauer
2015-07-24  6:29     ` Sascha Hauer
2015-07-24 13:59     ` Guenter Roeck
2015-07-24 13:59       ` [lm-sensors] " Guenter Roeck
2015-07-24 13:59       ` Guenter Roeck
2015-07-24 22:11       ` Pavel Machek
2015-07-24 22:11         ` [lm-sensors] " Pavel Machek
2015-07-24 22:11         ` Pavel Machek
2015-07-24 22:49         ` Guenter Roeck
2015-07-24 22:49           ` [lm-sensors] " Guenter Roeck
2015-07-24 22:49           ` Guenter Roeck
2015-07-24 22:49           ` Guenter Roeck
2015-07-25  7:01           ` Pavel Machek
2015-07-25  7:01             ` [lm-sensors] " Pavel Machek
2015-07-25  7:01             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150723103758.GI18700@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=edubezval@gmail.com \
    --cc=heiko@sntech.de \
    --cc=jdelvare@suse.de \
    --cc=l.majewski@samsung.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=peter@piie.net \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=punit.agrawal@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.