From: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> To: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: "Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>, "Sascha Hauer" <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, "Dawei Chien (錢大衛)" <Dawei.Chien-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "Sasha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, "Matthias Brugger" <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Subject: Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver Date: Thu, 17 Dec 2015 10:16:17 -0500 [thread overview] Message-ID: <20151217151617.GY2772@windriver.com> (raw) In-Reply-To: <CAGS+omA1mgmFH_JXffUTC-aq3rOy7dRYsdveiJ8LcnB5gg0ELw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> [Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver] On 17/12/2015 (Thu 10:52) Daniel Kurtz wrote: [...] > > Also, since scpsys' Kconfig is "bool" not "tristate" it isn't a real > module so I think we should use: > builtin_platform_driver not module_platform_driver > > CC'ing Paul Gortmaker who seems to be on a mass > builtin_platform_driver conversion at the moment, see: > https://lkml.org/lkml/2015/12/9/952 > Good guess. In my giant queue I have that change. I just haven't got around to the requisite triple check and multi arch rebuild tests and put out a series for soc yet. Here is the short list for soc: drivers-soc-make-mediatek-mtk-scpsys.c-explicitly-no.patch drivers-soc-make-qcom-spm.c-explicitly-non-modular.patch drivers-soc-make-samsung-exynos-srom.c.c-explicitly-.patch drivers-soc-make-sunxi_sram.c-explicitly-non-modular.patch drivers-soc-tegra-make-fuse-tegra.c-explicitly-non-m.patch ...and here is the patch you predicted. If someone wants to fold the change into their work then great; I'll be happy to drop mine and be with one less patch to herd along. Paul. -- From eb32cc2c1db8192c08dd64af69cb172b3be4c98b Mon Sep 17 00:00:00 2001 From: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> Date: Fri, 4 Sep 2015 19:33:54 -0400 Subject: [PATCH] drivers/soc: make mediatek/mtk-scpsys.c explicitly non-modular The Kconfig currently controlling compilation of this code is: drivers/soc/mediatek/Kconfig:config MTK_SCPSYS drivers/soc/mediatek/Kconfig: bool "MediaTek SCPSYS Support" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Cc: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Signed-off-by: Paul Gortmaker <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index 164a7d8439b1..ae0ca34e64dd 100644 --- a/drivers/soc/mediatek/mtk-scpsys.c +++ b/drivers/soc/mediatek/mtk-scpsys.c @@ -15,7 +15,7 @@ #include <linux/io.h> #include <linux/kernel.h> #include <linux/mfd/syscon.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> @@ -484,5 +484,4 @@ static struct platform_driver scpsys_drv = { .of_match_table = of_match_ptr(of_scpsys_match_tbl), }, }; - -module_platform_driver_probe(scpsys_drv, scpsys_probe); +builtin_platform_driver_probe(scpsys_drv, scpsys_probe); -- 2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: paul.gortmaker@windriver.com (Paul Gortmaker) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver Date: Thu, 17 Dec 2015 10:16:17 -0500 [thread overview] Message-ID: <20151217151617.GY2772@windriver.com> (raw) In-Reply-To: <CAGS+omA1mgmFH_JXffUTC-aq3rOy7dRYsdveiJ8LcnB5gg0ELw@mail.gmail.com> [Re: [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver] On 17/12/2015 (Thu 10:52) Daniel Kurtz wrote: [...] > > Also, since scpsys' Kconfig is "bool" not "tristate" it isn't a real > module so I think we should use: > builtin_platform_driver not module_platform_driver > > CC'ing Paul Gortmaker who seems to be on a mass > builtin_platform_driver conversion at the moment, see: > https://lkml.org/lkml/2015/12/9/952 > Good guess. In my giant queue I have that change. I just haven't got around to the requisite triple check and multi arch rebuild tests and put out a series for soc yet. Here is the short list for soc: drivers-soc-make-mediatek-mtk-scpsys.c-explicitly-no.patch drivers-soc-make-qcom-spm.c-explicitly-non-modular.patch drivers-soc-make-samsung-exynos-srom.c.c-explicitly-.patch drivers-soc-make-sunxi_sram.c-explicitly-non-modular.patch drivers-soc-tegra-make-fuse-tegra.c-explicitly-non-m.patch ...and here is the patch you predicted. If someone wants to fold the change into their work then great; I'll be happy to drop mine and be with one less patch to herd along. Paul. -- From eb32cc2c1db8192c08dd64af69cb172b3be4c98b Mon Sep 17 00:00:00 2001 From: Paul Gortmaker <paul.gortmaker@windriver.com> Date: Fri, 4 Sep 2015 19:33:54 -0400 Subject: [PATCH] drivers/soc: make mediatek/mtk-scpsys.c explicitly non-modular The Kconfig currently controlling compilation of this code is: drivers/soc/mediatek/Kconfig:config MTK_SCPSYS drivers/soc/mediatek/Kconfig: bool "MediaTek SCPSYS Support" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the driver there is no doubt it is builtin-only. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Cc: Matthias Brugger <matthias.bgg@gmail.com> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Daniel Kurtz <djkurtz@chromium.org> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: Olof Johansson <olof@lixom.net> Cc: linux-arm-kernel at lists.infradead.org Cc: linux-mediatek at lists.infradead.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c index 164a7d8439b1..ae0ca34e64dd 100644 --- a/drivers/soc/mediatek/mtk-scpsys.c +++ b/drivers/soc/mediatek/mtk-scpsys.c @@ -15,7 +15,7 @@ #include <linux/io.h> #include <linux/kernel.h> #include <linux/mfd/syscon.h> -#include <linux/module.h> +#include <linux/init.h> #include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> @@ -484,5 +484,4 @@ static struct platform_driver scpsys_drv = { .of_match_table = of_match_ptr(of_scpsys_match_tbl), }, }; - -module_platform_driver_probe(scpsys_drv, scpsys_probe); +builtin_platform_driver_probe(scpsys_drv, scpsys_probe); -- 2.5.0
next prev parent reply other threads:[~2015-12-17 15:16 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-16 11:00 [PATCH v2] soc: mediatek: SCPSYS: use module_platform_driver Sascha Hauer 2015-12-16 11:22 ` Arnd Bergmann 2015-12-16 11:55 ` Matthias Brugger [not found] ` <56715136.3060908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-12-17 2:52 ` Daniel Kurtz 2015-12-17 2:52 ` Daniel Kurtz [not found] ` <CAGS+omA1mgmFH_JXffUTC-aq3rOy7dRYsdveiJ8LcnB5gg0ELw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-12-17 15:16 ` Paul Gortmaker [this message] 2015-12-17 15:16 ` Paul Gortmaker [not found] ` <20151217151617.GY2772-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> 2015-12-18 8:33 ` Matthias Brugger 2015-12-18 8:33 ` Matthias Brugger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151217151617.GY2772@windriver.com \ --to=paul.gortmaker-cwa4wttnnzf54taoqtywwq@public.gmane.org \ --cc=Dawei.Chien-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \ --cc=arnd-r2nGTMty4D4@public.gmane.org \ --cc=djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.