All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: kbuild-all@01.org,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Peter Huewe <peterhuewe@gmx.de>
Subject: [PATCH] tpm_crb: fix ptr_ret.cocci warnings
Date: Fri, 8 Jan 2016 10:04:41 +0800	[thread overview]
Message-ID: <20160108020441.GA12462@lkp-nex06> (raw)
In-Reply-To: <1452213386-21460-8-git-send-email-jgunthorpe@obsidianresearch.com>

drivers/char/tpm/tpm_crb.c:297:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 tpm_crb.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -294,9 +294,7 @@ static int crb_map_io(struct acpi_device
 	memcpy_fromio(&pa, &priv->cca->rsp_pa, 8);
 	pa = le64_to_cpu(pa);
 	priv->rsp = crb_access(dev, priv, pa, ioread32(&priv->cca->rsp_size));
-	if (IS_ERR(priv->rsp))
-		return PTR_ERR(priv->rsp);
-	return 0;
+	return PTR_ERR_OR_ZERO(priv->rsp);
 }
 
 static int crb_acpi_add(struct acpi_device *device)

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	kbuild-all-JC7UmRfGjtg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] tpm_crb: fix ptr_ret.cocci warnings
Date: Fri, 8 Jan 2016 10:04:41 +0800	[thread overview]
Message-ID: <20160108020441.GA12462@lkp-nex06> (raw)
In-Reply-To: <1452213386-21460-8-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

drivers/char/tpm/tpm_crb.c:297:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---

 tpm_crb.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -294,9 +294,7 @@ static int crb_map_io(struct acpi_device
 	memcpy_fromio(&pa, &priv->cca->rsp_pa, 8);
 	pa = le64_to_cpu(pa);
 	priv->rsp = crb_access(dev, priv, pa, ioread32(&priv->cca->rsp_size));
-	if (IS_ERR(priv->rsp))
-		return PTR_ERR(priv->rsp);
-	return 0;
+	return PTR_ERR_OR_ZERO(priv->rsp);
 }
 
 static int crb_acpi_add(struct acpi_device *device)

------------------------------------------------------------------------------

  parent reply	other threads:[~2016-01-08  2:05 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08  0:36 [PATCH v4 0/7] tpm_tis: Clean up force module parameter Jason Gunthorpe
2016-01-08  0:36 ` Jason Gunthorpe
2016-01-08  0:36 ` [PATCH v4 1/7] tpm_crb: Use the common ACPI definition of struct acpi_tpm2 Jason Gunthorpe
2016-01-08  0:36   ` Jason Gunthorpe
2016-01-08 12:01   ` Jarkko Sakkinen
2016-01-08 12:01     ` Jarkko Sakkinen
2016-01-08  0:36 ` [PATCH v4 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe
2016-01-08  0:36   ` Jason Gunthorpe
2016-01-08  0:36 ` [PATCH v4 3/7] tpm_tis: Do not fall back to a hardcoded address for TPM2 Jason Gunthorpe
2016-01-08  0:36   ` Jason Gunthorpe
2016-01-08 12:01   ` Jarkko Sakkinen
2016-01-08 12:01     ` Jarkko Sakkinen
2016-01-08  0:36 ` [PATCH v4 4/7] tpm_tis: Use devm_ioremap_resource Jason Gunthorpe
2016-01-08  0:36   ` Jason Gunthorpe
2016-01-08  0:36 ` [PATCH v4 5/7] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe
2016-01-08  0:36   ` Jason Gunthorpe
2016-01-08 12:01   ` Jarkko Sakkinen
2016-01-08  0:36 ` [PATCH v4 6/7] tpm_crb: Drop le32_to_cpu(ioread32(..)) Jason Gunthorpe
2016-01-08  0:36   ` Jason Gunthorpe
2016-01-08  0:36 ` [PATCH v4 7/7] tpm_crb: Use devm_ioremap_resource Jason Gunthorpe
2016-01-08  0:36   ` Jason Gunthorpe
2016-01-08  2:04   ` kbuild test robot
2016-01-08  2:04   ` kbuild test robot [this message]
2016-01-08  2:04     ` [PATCH] tpm_crb: fix ptr_ret.cocci warnings kbuild test robot
2016-01-08 12:00   ` [PATCH v4 7/7] tpm_crb: Use devm_ioremap_resource Jarkko Sakkinen
2016-01-08 12:00     ` Jarkko Sakkinen
2016-01-08 12:02   ` Jarkko Sakkinen
2016-01-08 12:02     ` Jarkko Sakkinen
2016-01-08 15:12 ` [PATCH v4 0/7] tpm_tis: Clean up force module parameter Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160108020441.GA12462@lkp-nex06 \
    --to=lkp@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.