All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Whitney <enwlinux@gmail.com>,
	linux-ext4@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfstests-bld: add exclude file for ext3 tests
Date: Sun, 21 Feb 2016 00:45:30 -0500	[thread overview]
Message-ID: <20160221054530.GB15641@thunk.org> (raw)
In-Reply-To: <20160221025754.GA15641@thunk.org>

On Sat, Feb 20, 2016 at 09:57:54PM -0500, Theodore Ts'o wrote:
> 
> So probably the right answer here is to change _require_defrag so that
> for EXT4, to also add the assertion:
> 
> _require_xfs_io_command "falloc"

So like this...  (BTW what's up with my other pending xfstests
patches?  Would you like me to resend a whole back with the
reviewed-by lines merged in?)

						- Ted

>From a1cd89ca74d8e8cd345b88e62a5eabab70aed62e Mon Sep 17 00:00:00 2001
From: Theodore Ts'o <tytso@mit.edu>
Date: Sun, 21 Feb 2016 00:12:00 -0500
Subject: [PATCH] defrag: require falloc support for ext4 defrag

The e4defrag program requires the use of fallocate.  Certain ext4 file
system configurations which don't enable extents do not support
fallocate, so we should skip the defrag tests in that case.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 common/defrag | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/defrag b/common/defrag
index 942593e..f3d9e43 100644
--- a/common/defrag
+++ b/common/defrag
@@ -28,6 +28,7 @@ _require_defrag()
 	;;
     ext4|ext4dev)
         DEFRAG_PROG="$E4DEFRAG_PROG"
+	_require_xfs_io_command "falloc"
 	;;
     btrfs)
 	DEFRAG_PROG="$BTRFS_UTIL_PROG filesystem defragment"
-- 
2.5.0


  reply	other threads:[~2016-02-21 17:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20 15:51 [PATCH] xfstests-bld: add exclude file for ext3 tests Eric Whitney
2016-02-21  0:34 ` Dave Chinner
2016-02-21  2:57   ` Theodore Ts'o
2016-02-21  5:45     ` Theodore Ts'o [this message]
2016-02-21  6:23     ` Dave Chinner
2016-02-21 16:58       ` Theodore Ts'o
2016-02-22  0:26         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221054530.GB15641@thunk.org \
    --to=tytso@mit.edu \
    --cc=david@fromorbit.com \
    --cc=enwlinux@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.