From: Stephen Boyd <sboyd@codeaurora.org> To: Tony Lindgren <tony@atomide.com> Cc: Tero Kristo <t-kristo@ti.com>, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv2] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate Date: Mon, 22 Feb 2016 14:05:14 -0800 [thread overview] Message-ID: <20160222220514.GZ4847@codeaurora.org> (raw) In-Reply-To: <20160222165252.GF13417@atomide.com> On 02/22, Tony Lindgren wrote: > * Tero Kristo <t-kristo@ti.com> [160220 03:12]: > > As the code in this file is being executed within irq context in some > > cases, we must avoid the clk_get_rate which uses mutex internally. > > Switch the code to use clk_hw_get_rate instead which is non-locking. > > > > This fixes an issue where PM runtime will hang the system if enabled > > with a serial console before a suspend-resume cycle. > > Can you please add the "Fixes: " line here? > > And when applying, please tag this one Cc stable. > > Other than that, please feel free to add: > > Tested-by: Tony Lindgren <tony@atomide.com> > This is what I got. "Fixes" should take care of stable. From: Tero Kristo <t-kristo@ti.com> Subject: [PATCH] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate As the code in this file is being executed within irq context in some cases, we must avoid the clk_get_rate which uses mutex internally. Switch the code to use clk_hw_get_rate instead which is non-locking. This fixes an issue where PM runtime will hang the system if enabled with a serial console before a suspend-resume cycle. Signed-off-by: Tero Kristo <t-kristo@ti.com> Tested-by: Tony Lindgren <tony@atomide.com> Fixes: a53ad8ef3dcc ("clk: ti: Convert to clk_hw based provider APIs") Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/clk/ti/dpll3xxx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/ti/dpll3xxx.c b/drivers/clk/ti/dpll3xxx.c index 1c300388782b..cc739291a3ce 100644 --- a/drivers/clk/ti/dpll3xxx.c +++ b/drivers/clk/ti/dpll3xxx.c @@ -460,7 +460,8 @@ int omap3_noncore_dpll_enable(struct clk_hw *hw) parent = clk_hw_get_parent(hw); - if (clk_hw_get_rate(hw) == clk_get_rate(dd->clk_bypass)) { + if (clk_hw_get_rate(hw) == + clk_hw_get_rate(__clk_get_hw(dd->clk_bypass))) { WARN_ON(parent != __clk_get_hw(dd->clk_bypass)); r = _omap3_noncore_dpll_bypass(clk); } else { -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv2] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate Date: Mon, 22 Feb 2016 14:05:14 -0800 [thread overview] Message-ID: <20160222220514.GZ4847@codeaurora.org> (raw) In-Reply-To: <20160222165252.GF13417@atomide.com> On 02/22, Tony Lindgren wrote: > * Tero Kristo <t-kristo@ti.com> [160220 03:12]: > > As the code in this file is being executed within irq context in some > > cases, we must avoid the clk_get_rate which uses mutex internally. > > Switch the code to use clk_hw_get_rate instead which is non-locking. > > > > This fixes an issue where PM runtime will hang the system if enabled > > with a serial console before a suspend-resume cycle. > > Can you please add the "Fixes: " line here? > > And when applying, please tag this one Cc stable. > > Other than that, please feel free to add: > > Tested-by: Tony Lindgren <tony@atomide.com> > This is what I got. "Fixes" should take care of stable. From: Tero Kristo <t-kristo@ti.com> Subject: [PATCH] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate As the code in this file is being executed within irq context in some cases, we must avoid the clk_get_rate which uses mutex internally. Switch the code to use clk_hw_get_rate instead which is non-locking. This fixes an issue where PM runtime will hang the system if enabled with a serial console before a suspend-resume cycle. Signed-off-by: Tero Kristo <t-kristo@ti.com> Tested-by: Tony Lindgren <tony@atomide.com> Fixes: a53ad8ef3dcc ("clk: ti: Convert to clk_hw based provider APIs") Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/clk/ti/dpll3xxx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/ti/dpll3xxx.c b/drivers/clk/ti/dpll3xxx.c index 1c300388782b..cc739291a3ce 100644 --- a/drivers/clk/ti/dpll3xxx.c +++ b/drivers/clk/ti/dpll3xxx.c @@ -460,7 +460,8 @@ int omap3_noncore_dpll_enable(struct clk_hw *hw) parent = clk_hw_get_parent(hw); - if (clk_hw_get_rate(hw) == clk_get_rate(dd->clk_bypass)) { + if (clk_hw_get_rate(hw) == + clk_hw_get_rate(__clk_get_hw(dd->clk_bypass))) { WARN_ON(parent != __clk_get_hw(dd->clk_bypass)); r = _omap3_noncore_dpll_bypass(clk); } else { -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-02-22 22:05 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-20 11:12 [PATCHv2] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate Tero Kristo 2016-02-20 11:12 ` Tero Kristo 2016-02-20 11:12 ` Tero Kristo 2016-02-22 16:52 ` Tony Lindgren 2016-02-22 16:52 ` Tony Lindgren 2016-02-22 22:05 ` Stephen Boyd [this message] 2016-02-22 22:05 ` Stephen Boyd 2016-02-22 22:10 ` Tony Lindgren 2016-02-22 22:10 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160222220514.GZ4847@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=t-kristo@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.