From: Kalle Valo <kvalo@qca.qualcomm.com> To: <ath10k@lists.infradead.org> Cc: <linux-wireless@vger.kernel.org> Subject: [PATCH v2 4/5] ath10k: prefer ether_addr_copy() over memcpy() Date: Wed, 13 Apr 2016 14:14:02 +0300 [thread overview] Message-ID: <20160413111402.18823.24437.stgit@potku.adurom.net> (raw) In-Reply-To: <20160413111247.18823.15952.stgit@potku.adurom.net> Fixes checkpatch warning: drivers/net/wireless/ath/ath10k/wmi.c:5800: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index e92ac26865ff..adb31e188ebd 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -5827,9 +5827,8 @@ ath10k_wmi_put_start_scan_tlvs(struct wmi_start_scan_tlvs *tlvs, bssids->num_bssid = __cpu_to_le32(arg->n_bssids); for (i = 0; i < arg->n_bssids; i++) - memcpy(&bssids->bssid_list[i], - arg->bssids[i].bssid, - ETH_ALEN); + ether_addr_copy(bssids->bssid_list[i].addr, + arg->bssids[i].bssid); ptr += sizeof(*bssids); ptr += sizeof(struct wmi_mac_addr) * arg->n_bssids;
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com> To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH v2 4/5] ath10k: prefer ether_addr_copy() over memcpy() Date: Wed, 13 Apr 2016 14:14:02 +0300 [thread overview] Message-ID: <20160413111402.18823.24437.stgit@potku.adurom.net> (raw) In-Reply-To: <20160413111247.18823.15952.stgit@potku.adurom.net> Fixes checkpatch warning: drivers/net/wireless/ath/ath10k/wmi.c:5800: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index e92ac26865ff..adb31e188ebd 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -5827,9 +5827,8 @@ ath10k_wmi_put_start_scan_tlvs(struct wmi_start_scan_tlvs *tlvs, bssids->num_bssid = __cpu_to_le32(arg->n_bssids); for (i = 0; i < arg->n_bssids; i++) - memcpy(&bssids->bssid_list[i], - arg->bssids[i].bssid, - ETH_ALEN); + ether_addr_copy(bssids->bssid_list[i].addr, + arg->bssids[i].bssid); ptr += sizeof(*bssids); ptr += sizeof(struct wmi_mac_addr) * arg->n_bssids; _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-04-13 11:14 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-13 11:13 [PATCH v2 0/5] ath10k: fix recent checkpatch warnings Kalle Valo 2016-04-13 11:13 ` Kalle Valo 2016-04-13 11:13 ` [PATCH v2 1/5] ath10k: fix checkpatch warnings related to spaces Kalle Valo 2016-04-13 11:13 ` Kalle Valo 2016-04-14 7:47 ` Joe Perches 2016-04-14 7:47 ` Joe Perches 2016-04-13 11:13 ` [PATCH v2 2/5] ath10k: prefer kernel type 'u64' over 'u_int64_t' Kalle Valo 2016-04-13 11:13 ` Kalle Valo 2016-04-13 11:13 ` [PATCH v2 3/5] ath10k: prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() Kalle Valo 2016-04-13 11:13 ` Kalle Valo 2016-04-13 11:14 ` Kalle Valo [this message] 2016-04-13 11:14 ` [PATCH v2 4/5] ath10k: prefer ether_addr_copy() over memcpy() Kalle Valo 2016-04-13 11:14 ` [PATCH v2 5/5] ath10k: fix parenthesis alignment Kalle Valo 2016-04-13 11:14 ` Kalle Valo 2016-04-19 15:44 ` [PATCH v2 0/5] ath10k: fix recent checkpatch warnings Valo, Kalle 2016-04-19 15:44 ` Valo, Kalle
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160413111402.18823.24437.stgit@potku.adurom.net \ --to=kvalo@qca.qualcomm.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.