All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: linux-kernel@vger.kernel.org
Cc: Eric Engestrom <eric@engestrom.ch>,
	Eric Engestrom <eric.engestrom@imgtec.com>,
	linux-nvdimm@lists.01.org
Subject: [PATCH 1/2] libnvdimm: add missing macros
Date: Fri, 8 Jul 2016 17:29:10 +0100	[thread overview]
Message-ID: <20160708162911.18756-1-eric.engestrom@imgtec.com> (raw)

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---

This can't compile without these macros… Is this header really used by anyone?
Should it be removed, to avoid bit-rot?

---
 include/uapi/linux/ndctl.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
index 309915f..50ae5e7 100644
--- a/include/uapi/linux/ndctl.h
+++ b/include/uapi/linux/ndctl.h
@@ -15,6 +15,14 @@
 
 #include <linux/types.h>
 
+#ifdef __GNUC__
+#define __packed __attribute__((packed))
+#else
+#define __packed
+#endif
+
+#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr)[0])
+
 struct nd_cmd_smart {
 	__u32 status;
 	__u8 data[128];
-- 
2.9.0

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: <linux-kernel@vger.kernel.org>
Cc: Eric Engestrom <eric@engestrom.ch>,
	Eric Engestrom <eric.engestrom@imgtec.com>,
	Dan Williams <dan.j.williams@intel.com>,
	<linux-nvdimm@ml01.01.org>
Subject: [PATCH 1/2] libnvdimm: add missing macros
Date: Fri, 8 Jul 2016 17:29:10 +0100	[thread overview]
Message-ID: <20160708162911.18756-1-eric.engestrom@imgtec.com> (raw)

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---

This can't compile without these macros… Is this header really used by anyone?
Should it be removed, to avoid bit-rot?

---
 include/uapi/linux/ndctl.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
index 309915f..50ae5e7 100644
--- a/include/uapi/linux/ndctl.h
+++ b/include/uapi/linux/ndctl.h
@@ -15,6 +15,14 @@
 
 #include <linux/types.h>
 
+#ifdef __GNUC__
+#define __packed __attribute__((packed))
+#else
+#define __packed
+#endif
+
+#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr)[0])
+
 struct nd_cmd_smart {
 	__u32 status;
 	__u8 data[128];
-- 
2.9.0

             reply	other threads:[~2016-07-08 16:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 16:29 Eric Engestrom [this message]
2016-07-08 16:29 ` [PATCH 1/2] libnvdimm: add missing macros Eric Engestrom
2016-07-08 16:29 ` [PATCH 2/2] netfilter: add missing macro Eric Engestrom
2016-07-08 17:00   ` kbuild test robot
2016-07-11 10:41   ` Pablo Neira Ayuso
2016-07-11 10:41     ` Pablo Neira Ayuso
2016-07-08 17:25 ` [PATCH 1/2] libnvdimm: add missing macros kbuild test robot
2016-07-08 17:25   ` kbuild test robot
2016-07-08 19:32 ` Dan Williams
2016-07-08 19:32   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708162911.18756-1-eric.engestrom@imgtec.com \
    --to=eric.engestrom@imgtec.com \
    --cc=eric@engestrom.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.