All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: xen-devel@lists.xen.org
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v6 07/14] hvmloader: Grab the hvm_start_info pointer
Date: Tue, 12 Jul 2016 15:42:44 +0100	[thread overview]
Message-ID: <20160712144251.558-8-anthony.perard@citrix.com> (raw)
In-Reply-To: <20160712144251.558-1-anthony.perard@citrix.com>

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Jan Beulich <jbeulich@suse.com>

---
Changes in V6:
- include xen/arch-x86/hvm/start_info.h

Change in V4:
- remove struct hvm_info_start redefinition, as it's moved to
  public/xen.h in a previous patch.

Change in V3:
- remove cmdline parser
- load hvm_start_info pointer earlier, before calling main().
- Add struct hvm_start_info definition to hvmloader.
---
 tools/firmware/hvmloader/hvmloader.c | 6 ++++++
 tools/firmware/hvmloader/util.h      | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/tools/firmware/hvmloader/hvmloader.c b/tools/firmware/hvmloader/hvmloader.c
index 716d03c..77c70e0 100644
--- a/tools/firmware/hvmloader/hvmloader.c
+++ b/tools/firmware/hvmloader/hvmloader.c
@@ -28,6 +28,9 @@
 #include "vnuma.h"
 #include <xen/version.h>
 #include <xen/hvm/params.h>
+#include <xen/arch-x86/hvm/start_info.h>
+
+const struct hvm_start_info *hvm_start_info;
 
 asm (
     "    .text                       \n"
@@ -46,6 +49,8 @@ asm (
     "    ljmp $"STR(SEL_CODE32)",$1f \n"
     "1:  movl $stack_top,%esp        \n"
     "    movl %esp,%ebp              \n"
+    /* store HVM start info ptr */
+    "    mov  %ebx, hvm_start_info   \n"
     "    call main                   \n"
     /* Relocate real-mode trampoline to 0x0. */
     "    mov  $trampoline_start,%esi \n"
@@ -258,6 +263,7 @@ int main(void)
     memset((void *)HYPERCALL_PHYSICAL_ADDRESS, 0xc3 /* RET */, PAGE_SIZE);
 
     printf("HVM Loader\n");
+    BUG_ON(hvm_start_info->magic != XEN_HVM_START_MAGIC_VALUE);
 
     init_hypercalls();
 
diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h
index 3126817..9808016 100644
--- a/tools/firmware/hvmloader/util.h
+++ b/tools/firmware/hvmloader/util.h
@@ -158,6 +158,9 @@ static inline void cpu_relax(void)
 struct hvm_info_table *get_hvm_info_table(void) __attribute__ ((const));
 #define hvm_info (get_hvm_info_table())
 
+/* HVM start info */
+extern const struct hvm_start_info *hvm_start_info;
+
 /* String and memory functions */
 int strcmp(const char *cs, const char *ct);
 int strncmp(const char *s1, const char *s2, uint32_t n);
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-07-12 14:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 14:42 [PATCH v6 00/14] Load BIOS via toolstack instead of been embedded in hvmloader Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 01/14] libxc: Rework extra module initialisation Anthony PERARD
2016-07-12 15:01   ` Wei Liu
2016-07-12 14:42 ` [PATCH v6 02/14] libxc: Prepare a start info structure for hvmloader Anthony PERARD
2016-07-12 15:01   ` Wei Liu
2016-07-12 14:42 ` [PATCH v6 03/14] configure: #define SEABIOS_PATH and OVMF_PATH Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 04/14] firmware/makefile: install BIOS blob Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 05/14] libxl: Load guest BIOS from file Anthony PERARD
2016-07-12 15:01   ` Wei Liu
2016-07-12 14:42 ` [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h Anthony PERARD
2016-07-12 14:57   ` Wei Liu
2016-07-12 15:09   ` Andrew Cooper
2016-07-12 15:36     ` Anthony PERARD
2016-07-12 16:07       ` Andrew Cooper
2016-07-14 15:55         ` Anthony PERARD
2016-07-12 14:42 ` Anthony PERARD [this message]
2016-07-12 14:42 ` [PATCH v6 08/14] hvmloader: Locate the BIOS blob Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 09/14] hvmloader: Check modules whereabouts in perform_tests Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 10/14] hvmloader: Load SeaBIOS from hvm_start_info modules Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 11/14] hvmloader: Load OVMF from modules Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 12/14] hvmloader: bios->bios_load() now needs to be defined Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 13/14] hvmloader: Always build-in SeaBIOS and OVMF loader Anthony PERARD
2016-07-12 14:42 ` [PATCH v6 14/14] configure: do not depend on SEABIOS_PATH or OVMF_PATH Anthony PERARD
2016-07-12 15:03 ` [PATCH v6 00/14] Load BIOS via toolstack instead of been embedded in hvmloader Wei Liu
2016-07-12 15:04   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712144251.558-8-anthony.perard@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.