From: Andre Przywara <andre.przywara@arm.com> To: Marc Zyngier <marc.zyngier@arm.com>, Christoffer Dall <christoffer.dall@linaro.org>, Eric Auger <eric.auger@redhat.com> Cc: linux-arm-kernel@lists.infradead.org, Andre Przywara <andre.przywara@arm.com>, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Subject: [PATCH v9 14/17] KVM: arm64: allow updates of LPI configuration table Date: Wed, 13 Jul 2016 02:59:06 +0100 [thread overview] Message-ID: <20160713015909.28793-15-andre.przywara@arm.com> (raw) In-Reply-To: <20160713015909.28793-1-andre.przywara@arm.com> The (system-wide) LPI configuration table is held in a table in (guest) memory. To achieve reasonable performance, we cache this data in our struct vgic_irq. If the guest updates the configuration data (which consists of the enable bit and the priority value), it issues an INV or INVALL command to allow us to update our information. Provide functions that update that information for one LPI or all LPIs mapped to a specific collection. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- virt/kvm/arm/vgic/vgic-its.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index f400ef1..60108f8 100644 --- a/virt/kvm/arm/vgic/vgic-its.c +++ b/virt/kvm/arm/vgic/vgic-its.c @@ -64,6 +64,45 @@ struct its_itte { #define CBASER_ADDRESS(x) ((x) & GENMASK_ULL(51, 12)) #define PENDBASER_ADDRESS(x) ((x) & GENMASK_ULL(51, 16)) +#define PROPBASER_ADDRESS(x) ((x) & GENMASK_ULL(51, 12)) + +#define GIC_LPI_OFFSET 8192 + +#define LPI_PROP_ENABLE_BIT(p) ((p) & LPI_PROP_ENABLED) +#define LPI_PROP_PRIORITY(p) ((p) & 0xfc) + +/* + * Reads the configuration data for a given LPI from guest memory and + * updates the fields in struct vgic_irq. + * If filter_vcpu is not NULL, applies only if the IRQ is targeting this + * VCPU. Unconditionally applies if filter_vcpu is NULL. + */ +static int update_lpi_config(struct kvm *kvm, struct vgic_irq *irq, + struct kvm_vcpu *filter_vcpu) +{ + u64 propbase = PROPBASER_ADDRESS(kvm->arch.vgic.propbaser); + u8 prop; + int ret; + + ret = kvm_read_guest(kvm, propbase + irq->intid - GIC_LPI_OFFSET, + &prop, 1); + + if (ret) + return ret; + + spin_lock(&irq->irq_lock); + + if (!filter_vcpu || filter_vcpu == irq->target_vcpu) { + irq->priority = LPI_PROP_PRIORITY(prop); + irq->enabled = LPI_PROP_ENABLE_BIT(prop); + + vgic_queue_irq_unlock(kvm, irq); + } else { + spin_unlock(&irq->irq_lock); + } + + return 0; +} /* * Create a snapshot of the current LPI list, so that we can enumerate all -- 2.9.0
WARNING: multiple messages have this Message-ID (diff)
From: andre.przywara@arm.com (Andre Przywara) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v9 14/17] KVM: arm64: allow updates of LPI configuration table Date: Wed, 13 Jul 2016 02:59:06 +0100 [thread overview] Message-ID: <20160713015909.28793-15-andre.przywara@arm.com> (raw) In-Reply-To: <20160713015909.28793-1-andre.przywara@arm.com> The (system-wide) LPI configuration table is held in a table in (guest) memory. To achieve reasonable performance, we cache this data in our struct vgic_irq. If the guest updates the configuration data (which consists of the enable bit and the priority value), it issues an INV or INVALL command to allow us to update our information. Provide functions that update that information for one LPI or all LPIs mapped to a specific collection. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- virt/kvm/arm/vgic/vgic-its.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index f400ef1..60108f8 100644 --- a/virt/kvm/arm/vgic/vgic-its.c +++ b/virt/kvm/arm/vgic/vgic-its.c @@ -64,6 +64,45 @@ struct its_itte { #define CBASER_ADDRESS(x) ((x) & GENMASK_ULL(51, 12)) #define PENDBASER_ADDRESS(x) ((x) & GENMASK_ULL(51, 16)) +#define PROPBASER_ADDRESS(x) ((x) & GENMASK_ULL(51, 12)) + +#define GIC_LPI_OFFSET 8192 + +#define LPI_PROP_ENABLE_BIT(p) ((p) & LPI_PROP_ENABLED) +#define LPI_PROP_PRIORITY(p) ((p) & 0xfc) + +/* + * Reads the configuration data for a given LPI from guest memory and + * updates the fields in struct vgic_irq. + * If filter_vcpu is not NULL, applies only if the IRQ is targeting this + * VCPU. Unconditionally applies if filter_vcpu is NULL. + */ +static int update_lpi_config(struct kvm *kvm, struct vgic_irq *irq, + struct kvm_vcpu *filter_vcpu) +{ + u64 propbase = PROPBASER_ADDRESS(kvm->arch.vgic.propbaser); + u8 prop; + int ret; + + ret = kvm_read_guest(kvm, propbase + irq->intid - GIC_LPI_OFFSET, + &prop, 1); + + if (ret) + return ret; + + spin_lock(&irq->irq_lock); + + if (!filter_vcpu || filter_vcpu == irq->target_vcpu) { + irq->priority = LPI_PROP_PRIORITY(prop); + irq->enabled = LPI_PROP_ENABLE_BIT(prop); + + vgic_queue_irq_unlock(kvm, irq); + } else { + spin_unlock(&irq->irq_lock); + } + + return 0; +} /* * Create a snapshot of the current LPI list, so that we can enumerate all -- 2.9.0
next prev parent reply other threads:[~2016-07-13 1:59 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-13 1:58 [PATCH v9 00/17] KVM: arm64: GICv3 ITS emulation Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 1:58 ` [PATCH v9 01/17] KVM: arm/arm64: move redistributor kvm_io_devices Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 1:58 ` [PATCH v9 02/17] KVM: arm/arm64: check return value for kvm_register_vgic_device Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 1:58 ` [PATCH v9 03/17] KVM: extend struct kvm_msi to hold a 32-bit device ID Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 10:28 ` Paolo Bonzini 2016-07-13 10:28 ` Paolo Bonzini 2016-07-13 1:58 ` [PATCH v9 04/17] KVM: arm/arm64: extend arch CAP checks to allow per-VM capabilities Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 1:58 ` [PATCH v9 05/17] KVM: kvm_io_bus: add kvm_io_bus_get_dev() call Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 10:29 ` Paolo Bonzini 2016-07-13 10:29 ` Paolo Bonzini 2016-07-13 1:58 ` [PATCH v9 06/17] KVM: arm/arm64: VGIC: add refcounting for IRQs Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 12:15 ` Marc Zyngier 2016-07-13 12:15 ` Marc Zyngier 2016-07-13 13:50 ` Andre Przywara 2016-07-13 13:50 ` Andre Przywara 2016-07-13 1:58 ` [PATCH v9 07/17] irqchip: refactor and add GICv3 definitions Andre Przywara 2016-07-13 1:58 ` Andre Przywara 2016-07-13 12:28 ` Marc Zyngier 2016-07-13 12:28 ` Marc Zyngier 2016-07-13 1:59 ` [PATCH v9 08/17] KVM: arm64: handle ITS related GICv3 redistributor registers Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-13 1:59 ` [PATCH v9 09/17] KVM: arm64: introduce ITS emulation file with MMIO framework Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-13 1:59 ` [PATCH v9 10/17] KVM: arm64: introduce new KVM ITS device Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-14 8:36 ` Marc Zyngier 2016-07-14 8:36 ` Marc Zyngier 2016-07-14 11:11 ` Andre Przywara 2016-07-14 11:11 ` Andre Przywara 2016-07-14 12:57 ` Marc Zyngier 2016-07-14 12:57 ` Marc Zyngier 2016-07-15 9:33 ` Andre Przywara 2016-07-15 9:33 ` Andre Przywara 2016-07-13 1:59 ` [PATCH v9 11/17] KVM: arm64: implement basic ITS register handlers Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-14 9:13 ` Marc Zyngier 2016-07-14 9:13 ` Marc Zyngier 2016-07-13 1:59 ` [PATCH v9 12/17] KVM: arm64: connect LPIs to the VGIC emulation Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-13 1:59 ` [PATCH v9 13/17] KVM: arm64: read initial LPI pending table Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-14 9:34 ` Marc Zyngier 2016-07-14 9:34 ` Marc Zyngier 2016-07-14 10:16 ` Andre Przywara 2016-07-14 10:16 ` Andre Przywara 2016-07-13 1:59 ` Andre Przywara [this message] 2016-07-13 1:59 ` [PATCH v9 14/17] KVM: arm64: allow updates of LPI configuration table Andre Przywara 2016-07-14 9:46 ` Marc Zyngier 2016-07-14 9:46 ` Marc Zyngier 2016-07-14 10:00 ` Andre Przywara 2016-07-14 10:00 ` Andre Przywara 2016-07-14 10:10 ` Marc Zyngier 2016-07-14 10:10 ` Marc Zyngier 2016-07-13 1:59 ` [PATCH v9 15/17] KVM: arm64: implement ITS command queue command handlers Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-14 10:38 ` Marc Zyngier 2016-07-14 10:38 ` Marc Zyngier 2016-07-14 15:35 ` Andre Przywara 2016-07-14 15:35 ` Andre Przywara 2016-07-14 16:33 ` Marc Zyngier 2016-07-14 16:33 ` Marc Zyngier 2016-07-15 8:19 ` Marc Zyngier 2016-07-15 8:19 ` Marc Zyngier 2016-07-13 1:59 ` [PATCH v9 16/17] KVM: arm64: implement MSI injection in ITS emulation Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-13 1:59 ` [PATCH v9 17/17] KVM: arm64: enable ITS emulation as a virtual MSI controller Andre Przywara 2016-07-13 1:59 ` Andre Przywara 2016-07-13 7:57 ` [PATCH v9 00/17] KVM: arm64: GICv3 ITS emulation Diana Madalina Craciun 2016-07-13 7:57 ` Diana Madalina Craciun 2016-07-13 8:15 ` Andre Przywara 2016-07-13 8:15 ` Andre Przywara 2016-07-14 10:52 ` Marc Zyngier 2016-07-14 10:52 ` Marc Zyngier 2016-07-14 11:01 ` Paolo Bonzini 2016-07-14 11:01 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160713015909.28793-15-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=eric.auger@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.