From: Dan Carpenter <dan.carpenter@oracle.com> To: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Robert Jarzmik <robert.jarzmik@free.fr> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Viresh Kumar <viresh.kumar@linaro.org>, "Luis R. Rodriguez" <mcgrof@suse.com>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] video: fbdev: pxafb: potential NULL dereference on error Date: Fri, 15 Jul 2016 14:07:32 +0300 [thread overview] Message-ID: <20160715110732.GC9258@mwanda> (raw) If we "goto out;" then it calls display_timings_release(timings); Since "timings" is NULL, that's going to oops. Just return directly. Fixes: 420a488278e8 ('video: fbdev: pxafb: initial devicetree conversion') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 2c0487f..ed41fdb 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2125,7 +2125,7 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, timings = of_get_display_timings(disp); if (!timings) - goto out; + return -EINVAL; ret = -ENOMEM; info->modes = kmalloc_array(timings->num_timings,
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Robert Jarzmik <robert.jarzmik@free.fr> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Viresh Kumar <viresh.kumar@linaro.org>, "Luis R. Rodriguez" <mcgrof@suse.com>, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] video: fbdev: pxafb: potential NULL dereference on error Date: Fri, 15 Jul 2016 11:07:32 +0000 [thread overview] Message-ID: <20160715110732.GC9258@mwanda> (raw) If we "goto out;" then it calls display_timings_release(timings); Since "timings" is NULL, that's going to oops. Just return directly. Fixes: 420a488278e8 ('video: fbdev: pxafb: initial devicetree conversion') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 2c0487f..ed41fdb 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2125,7 +2125,7 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, timings = of_get_display_timings(disp); if (!timings) - goto out; + return -EINVAL; ret = -ENOMEM; info->modes = kmalloc_array(timings->num_timings,
next reply other threads:[~2016-07-15 11:10 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-15 11:07 Dan Carpenter [this message] 2016-07-15 11:07 ` [patch] video: fbdev: pxafb: potential NULL dereference on error Dan Carpenter 2016-07-17 15:20 ` Robert Jarzmik 2016-07-17 15:20 ` Robert Jarzmik 2016-08-10 10:56 ` Tomi Valkeinen 2016-08-10 10:56 ` Tomi Valkeinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160715110732.GC9258@mwanda \ --to=dan.carpenter@oracle.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mcgrof@suse.com \ --cc=plagnioj@jcrosoft.com \ --cc=rafael.j.wysocki@intel.com \ --cc=robert.jarzmik@free.fr \ --cc=tomi.valkeinen@ti.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.