From: Baole Ni <baolex.ni@intel.com> To: konrad.wilk@oracle.com, roger.pau@citrix.com, pavel@ucw.cz, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, martin.petersen@oracle.com, kent.overstreet@gmail.com Subject: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:40:21 +0800 [thread overview] Message-ID: <20160802104021.20157-1-baolex.ni@intel.com> (raw) I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- drivers/block/xen-blkback/blkback.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 4809c15..73251ce 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -63,7 +63,7 @@ */ static int xen_blkif_max_buffer_pages = 1024; -module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, 0644); +module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_buffer_pages, "Maximum number of free pages to keep in each block backend buffer"); @@ -79,7 +79,7 @@ MODULE_PARM_DESC(max_buffer_pages, */ static int xen_blkif_max_pgrants = 1056; -module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, 0644); +module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_persistent_grants, "Maximum number of grants to map persistently"); @@ -88,7 +88,7 @@ MODULE_PARM_DESC(max_persistent_grants, * are CPUs if user has not specified a value. */ unsigned int xenblk_max_queues; -module_param_named(max_queues, xenblk_max_queues, uint, 0644); +module_param_named(max_queues, xenblk_max_queues, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_queues, "Maximum number of hardware queues per virtual disk." \ "By default it is the number of online CPUs."); @@ -116,7 +116,7 @@ MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used for the /* Run-time switchable: /sys/module/blkback/parameters/ */ static unsigned int log_stats; -module_param(log_stats, int, 0644); +module_param(log_stats, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define BLKBACK_INVALID_HANDLE (~0) -- 2.9.2
WARNING: multiple messages have this Message-ID (diff)
From: Baole Ni <baolex.ni@intel.com> To: konrad.wilk@oracle.com, roger.pau@citrix.com, pavel@ucw.cz, gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org Cc: martin.petersen@oracle.com, linux-kernel@vger.kernel.org, baolex.ni@intel.com, xen-devel@lists.xenproject.org, chuansheng.liu@intel.com, kent.overstreet@gmail.com Subject: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:40:21 +0800 [thread overview] Message-ID: <20160802104021.20157-1-baolex.ni@intel.com> (raw) I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- drivers/block/xen-blkback/blkback.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 4809c15..73251ce 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -63,7 +63,7 @@ */ static int xen_blkif_max_buffer_pages = 1024; -module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, 0644); +module_param_named(max_buffer_pages, xen_blkif_max_buffer_pages, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_buffer_pages, "Maximum number of free pages to keep in each block backend buffer"); @@ -79,7 +79,7 @@ MODULE_PARM_DESC(max_buffer_pages, */ static int xen_blkif_max_pgrants = 1056; -module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, 0644); +module_param_named(max_persistent_grants, xen_blkif_max_pgrants, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_persistent_grants, "Maximum number of grants to map persistently"); @@ -88,7 +88,7 @@ MODULE_PARM_DESC(max_persistent_grants, * are CPUs if user has not specified a value. */ unsigned int xenblk_max_queues; -module_param_named(max_queues, xenblk_max_queues, uint, 0644); +module_param_named(max_queues, xenblk_max_queues, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_queues, "Maximum number of hardware queues per virtual disk." \ "By default it is the number of online CPUs."); @@ -116,7 +116,7 @@ MODULE_PARM_DESC(max_ring_page_order, "Maximum order of pages to be used for the /* Run-time switchable: /sys/module/blkback/parameters/ */ static unsigned int log_stats; -module_param(log_stats, int, 0644); +module_param(log_stats, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define BLKBACK_INVALID_HANDLE (~0) -- 2.9.2 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next reply other threads:[~2016-08-02 12:09 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-02 10:40 Baole Ni [this message] 2016-08-02 10:40 ` [PATCH 0096/1285] Replace numeric parameter like 0444 with macro Baole Ni 2016-08-02 13:09 ` Roger Pau Monné 2016-08-02 13:09 ` Roger Pau Monné
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160802104021.20157-1-baolex.ni@intel.com \ --to=baolex.ni@intel.com \ --cc=chuansheng.liu@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hpa@zytor.com \ --cc=kent.overstreet@gmail.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=pavel@ucw.cz \ --cc=roger.pau@citrix.com \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.