From: Baole Ni <baolex.ni@intel.com>
To: fenghua.yu@intel.com, jdelvare@suse.com, linux@roeck-us.net,
airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com,
dougthompson@xmission.com, bp@alien8.de
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com, baolex.ni@intel.com,
aduggan@synaptics.com, dianders@chromium.org
Subject: [PATCH 0237/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 18:52:12 +0800 [thread overview]
Message-ID: <20160802105212.29546-1-baolex.ni@intel.com> (raw)
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/hwmon/coretemp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 6a27eb2..83ba05c 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -48,7 +48,7 @@
* When set, it replaces the driver's suboptimal heuristic.
*/
static int force_tjmax;
-module_param_named(tjmax, force_tjmax, int, 0444);
+module_param_named(tjmax, force_tjmax, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
#define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */
--
2.9.2
reply other threads:[~2016-08-02 11:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802105212.29546-1-baolex.ni@intel.com \
--to=baolex.ni@intel.com \
--cc=aduggan@synaptics.com \
--cc=airlied@linux.ie \
--cc=bp@alien8.de \
--cc=chuansheng.liu@intel.com \
--cc=dianders@chromium.org \
--cc=dougthompson@xmission.com \
--cc=fenghua.yu@intel.com \
--cc=jdelvare@suse.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.