From: Jean Delvare <jdelvare@suse.de>
To: Alexander Kapshuk <alexander.kapshuk@gmail.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER
Date: Mon, 29 Aug 2016 12:06:34 +0200 [thread overview]
Message-ID: <20160829120634.039204a6@endymion> (raw)
In-Reply-To: <CAJ1xhMXZNMYMew4N2SZdhJm9FaiRjr=T63+72UdYpYfC+api_A@mail.gmail.com>
Hello Alexander,
On Sat, 27 Aug 2016 18:52:42 +0300, Alexander Kapshuk wrote:
> I get an Oops when loading it87.ko on a 4.7.2 kernel. See below for details:
it87_attributes_in lacks its NULL terminator, looks suspicious to me.
Can you try the following quick fix?
---
drivers/hwmon/it87.c | 1 +
1 file changed, 1 insertion(+)
--- linux-4.7.orig/drivers/hwmon/it87.c 2016-07-04 08:01:00.000000000 +0200
+++ linux-4.7/drivers/hwmon/it87.c 2016-08-29 12:04:52.926911625 +0200
@@ -2015,6 +2015,7 @@ static struct attribute *it87_attributes
&sensor_dev_attr_in10_input.dev_attr.attr, /* 41 */
&sensor_dev_attr_in11_input.dev_attr.attr, /* 41 */
&sensor_dev_attr_in12_input.dev_attr.attr, /* 41 */
+ NULL
};
static const struct attribute_group it87_group_in = {
I'm trying to find when the bug was introduced. I have a hard time
believing it went unnoticed for long. If it fixes your problem I'll
send a clean patch.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-08-29 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 15:52 [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Alexander Kapshuk
2016-08-29 10:06 ` Jean Delvare [this message]
2016-08-29 10:11 ` Jean Delvare
2016-08-29 10:16 ` Alexander Kapshuk
2016-08-29 14:46 ` Guenter Roeck
2016-08-29 16:05 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829120634.039204a6@endymion \
--to=jdelvare@suse.de \
--cc=alexander.kapshuk@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.