From: Sudip Midya <midya.sudip@gmail.com>
To: xfs@oss.sgi.com, david@fromorbit.com, hch@infradead.org
Subject: [PATCH] mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged lockless function. The function queue_delayed_work is already protected with interrupts disabled, hence no need to add rcu_lock/unlock.
Date: Mon, 26 Sep 2016 00:50:06 +0530 [thread overview]
Message-ID: <20160925192005.GA6517@sudip-Dell-System-Vostro-3450> (raw)
Signed-off-by: Sudip Midya <midya.sudip@gmail.com>
---
fs/xfs/xfs_icache.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index fb39a66..887c868 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -153,12 +153,10 @@ xfs_reclaim_work_queue(
struct xfs_mount *mp)
{
- rcu_read_lock();
if (radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_RECLAIM_TAG)) {
queue_delayed_work(mp->m_reclaim_workqueue, &mp->m_reclaim_work,
msecs_to_jiffies(xfs_syncd_centisecs / 6 * 10));
}
- rcu_read_unlock();
}
/*
--
1.9.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-09-25 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 19:20 Sudip Midya [this message]
2016-09-25 21:45 ` [PATCH] mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged lockless function. The function queue_delayed_work is already protected with interrupts disabled, hence no need to add rcu_lock/unlock Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925192005.GA6517@sudip-Dell-System-Vostro-3450 \
--to=midya.sudip@gmail.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.