From: Jiri Slaby <jslaby@suse.cz>
To: dmitry.torokhov@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH -resend] Input: i8042, lower log level when controller_init fails
Date: Mon, 3 Oct 2016 10:56:52 +0200 [thread overview]
Message-ID: <20161003085652.15810-1-jslaby@suse.cz> (raw)
There are a lot of machines without i8042 controller nowadays.
Sometimes i8042_controller_check returns 0 because i8042_flush does
nothing (read from the port returns 0 and the while loop does not
execute).
In that case, the probe method is called and fails with this error
output to console:
i8042: Can't read CTR while initializing i8042
i8042: probe of i8042 failed with error -5
Lower the former error message to be KERN_INFO and make the function
in that case return -ENODEV instead of -EIO. This will suppress the
latter.
There is also an IBM support page about these messages:
https://www-947.ibm.com/support/entry/portal/docdisplay?lndocid=migr-5082417
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/input/serio/i8042.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 405252a884dd..15c87b98d70b 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -950,8 +950,8 @@ static int i8042_controller_init(void)
udelay(50);
if (i8042_command(&ctr[n++ % 2], I8042_CMD_CTL_RCTR)) {
- pr_err("Can't read CTR while initializing i8042\n");
- return -EIO;
+ pr_info("Can't read CTR while initializing i8042. Either i8042 controller is not present or it does not respond.\n");
+ return -ENODEV;
}
} while (n < 2 || ctr[0] != ctr[1]);
--
2.10.0
next reply other threads:[~2016-10-03 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 8:56 Jiri Slaby [this message]
2016-10-24 9:05 ` [PATCH -resend] Input: i8042, lower log level when controller_init fails Jiri Slaby
2016-10-24 17:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003085652.15810-1-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.