From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> Cc: "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "Marek Vasut" <marex-ynQEQJNshbs@public.gmane.org>, "Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Jörg Krause" <joerg.krause-L1vi/lXTdtsfGbAt6QbQcg@public.gmane.org>, "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Sascha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>, "Fabio Estevam" <fabio.estevam-3arQi8VN3Tc@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "Lothar Waßmann" <lw-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org> Subject: Re: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM Date: Fri, 21 Oct 2016 23:03:36 +0800 [thread overview] Message-ID: <20161021150336.GJ30578@tiger> (raw) In-Reply-To: <9bf7c925-bdc2-d0b8-9886-70d46383d1e0-eS4NqCHxEME@public.gmane.org> On Fri, Oct 21, 2016 at 04:05:59PM +0200, Stefan Wahren wrote: > Am 21.10.2016 um 15:53 schrieb Shawn Guo: > > On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: > >> The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary > >> for suspend to RAM and standby mode. But before we need to remove the fake reg > >> properties of all internal bus nodes as discussed in this thread [1]. > >> > >> This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: > >> Remove skeleton.dtsi inclusion" [2]. > >> > >> [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 > > The page cannot be reached. I would like to understand the > > background for this change. > > Strange, because i don't have any problems while clicking on the URL. > > It's an older discussion on the devicetree / kernel newbie mailing list > with subject "strange dtc errors after adding sram node". Arnd suggested > in the discussion to remove the reg property from the ahb node. > > Please try this one: http://www.spinics.net/lists/newbies/msg57652.html If you go through 'Table 4-1. Address Map for i.MX28' of MCIMX28RM, you should be able to find there are 3 AHB buses: ahb@0, ahb@80080000 and ahb@c0000000. The ocram goes to ahb@0. The following change should be the right one for ocram addition. diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 0ad893bf5f43..8e5718df06b2 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -47,6 +47,19 @@ }; }; + ahb@0 { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x0 0x80000000>; + ranges; + + ocram: sram@0 { + compatible = "mmio-sram"; + reg = <0x0 0x20000>; + }; + }; + apb@80000000 { compatible = "simple-bus"; #address-cells = <1>; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM Date: Fri, 21 Oct 2016 23:03:36 +0800 [thread overview] Message-ID: <20161021150336.GJ30578@tiger> (raw) In-Reply-To: <9bf7c925-bdc2-d0b8-9886-70d46383d1e0@i2se.com> On Fri, Oct 21, 2016 at 04:05:59PM +0200, Stefan Wahren wrote: > Am 21.10.2016 um 15:53 schrieb Shawn Guo: > > On Tue, Sep 13, 2016 at 05:51:02PM +0000, Stefan Wahren wrote: > >> The i.MX23 / i.MX28 have a small amount of On-Chip RAM which is also necessary > >> for suspend to RAM and standby mode. But before we need to remove the fake reg > >> properties of all internal bus nodes as discussed in this thread [1]. > >> > >> This patch series requires Fabio Estevam's recent series "ARM: dts: imx23: > >> Remove skeleton.dtsi inclusion" [2]. > >> > >> [1] - https://marc.info/?l=devicetree&m=146139948426520&w=2 > > The page cannot be reached. I would like to understand the > > background for this change. > > Strange, because i don't have any problems while clicking on the URL. > > It's an older discussion on the devicetree / kernel newbie mailing list > with subject "strange dtc errors after adding sram node". Arnd suggested > in the discussion to remove the reg property from the ahb node. > > Please try this one: http://www.spinics.net/lists/newbies/msg57652.html If you go through 'Table 4-1. Address Map for i.MX28' of MCIMX28RM, you should be able to find there are 3 AHB buses: ahb at 0, ahb at 80080000 and ahb at c0000000. The ocram goes to ahb at 0. The following change should be the right one for ocram addition. diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 0ad893bf5f43..8e5718df06b2 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -47,6 +47,19 @@ }; }; + ahb at 0 { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x0 0x80000000>; + ranges; + + ocram: sram at 0 { + compatible = "mmio-sram"; + reg = <0x0 0x20000>; + }; + }; + apb at 80000000 { compatible = "simple-bus"; #address-cells = <1>;
next prev parent reply other threads:[~2016-10-21 15:03 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-13 17:51 [PATCH 0/4] ARM: boot: mxs: Add On-Chip RAM Stefan Wahren 2016-09-13 17:51 ` Stefan Wahren [not found] ` <1473789066-8955-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> 2016-09-13 17:51 ` [PATCH 1/4] ARM: dts: imx23: Remove fake "reg" properties from bus nodes Stefan Wahren 2016-09-13 17:51 ` Stefan Wahren 2016-09-13 17:51 ` [PATCH 2/4] ARM: dts: imx28: " Stefan Wahren 2016-09-13 17:51 ` Stefan Wahren 2016-09-13 17:51 ` [PATCH 3/4] ARM: dts: imx23: add On-Chip RAM Stefan Wahren 2016-09-13 17:51 ` Stefan Wahren 2016-09-13 17:51 ` [PATCH 4/4] ARM: dts: imx28: " Stefan Wahren 2016-09-13 17:51 ` Stefan Wahren 2016-10-20 15:33 ` [PATCH 0/4] ARM: boot: mxs: Add " Stefan Wahren 2016-10-20 15:33 ` Stefan Wahren 2016-10-21 13:53 ` Shawn Guo 2016-10-21 13:53 ` Shawn Guo 2016-10-21 14:05 ` Stefan Wahren 2016-10-21 14:05 ` Stefan Wahren [not found] ` <9bf7c925-bdc2-d0b8-9886-70d46383d1e0-eS4NqCHxEME@public.gmane.org> 2016-10-21 15:03 ` Shawn Guo [this message] 2016-10-21 15:03 ` Shawn Guo 2016-10-21 15:24 ` Stefan Wahren 2016-10-21 15:24 ` Stefan Wahren [not found] ` <e472fb62-00d2-359d-2126-ce2727fe3bed-eS4NqCHxEME@public.gmane.org> 2016-10-21 15:30 ` Stefan Wahren 2016-10-21 15:30 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161021150336.GJ30578@tiger \ --to=shawnguo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=arnd-r2nGTMty4D4@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=fabio.estevam-3arQi8VN3Tc@public.gmane.org \ --cc=joerg.krause-L1vi/lXTdtsfGbAt6QbQcg@public.gmane.org \ --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=lw-AvR2QvxeiV7DiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org \ --cc=marex-ynQEQJNshbs@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.