All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: [PATCH 1/4] btrfs-progs: check: Fix assert when using lowmem on fs with tree reloc tree
Date: Mon,  5 Dec 2016 17:07:53 +0800	[thread overview]
Message-ID: <20161205090756.7960-2-quwenruo@cn.fujitsu.com> (raw)
In-Reply-To: <20161205090756.7960-1-quwenruo@cn.fujitsu.com>

When using lowmem mode, btrfs check will report ASSERT for calling
btrfs_read_fs_root() on tree reloc tree.

Fix it by checking objectid and call btrfs_read_fs_root_no_cache() for
tree reloc tree.

Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
---
 cmds-check.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/cmds-check.c b/cmds-check.c
index 30eabb2..30847a0 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -11411,7 +11411,11 @@ static int check_chunks_and_extents_v2(struct btrfs_root *root)
 			goto next;
 		key.offset = (u64)-1;
 
-		cur_root = btrfs_read_fs_root(root->fs_info, &key);
+		if (key.objectid == BTRFS_TREE_RELOC_OBJECTID)
+			cur_root = btrfs_read_fs_root_no_cache(root->fs_info,
+					&key);
+		else
+			cur_root = btrfs_read_fs_root(root->fs_info, &key);
 		if (IS_ERR(cur_root) || !cur_root) {
 			error("failed to read tree: %lld", key.objectid);
 			goto next;
@@ -11420,6 +11424,8 @@ static int check_chunks_and_extents_v2(struct btrfs_root *root)
 		ret = traverse_tree_block(cur_root, cur_root->node);
 		err |= ret;
 
+		if (key.objectid == BTRFS_TREE_RELOC_OBJECTID)
+			btrfs_free_fs_root(cur_root);
 next:
 		ret = btrfs_next_item(root1, &path);
 		if (ret)
-- 
2.10.2




  reply	other threads:[~2016-12-05  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05  9:07 [PATCH 0/4] Lowmem fsck false alert fixes Qu Wenruo
2016-12-05  9:07 ` Qu Wenruo [this message]
2016-12-05  9:07 ` [PATCH 2/4] btrfs-progs: check: Fix lowmem mode stack overflow caused by fsck/023 Qu Wenruo
2016-12-05  9:07 ` [PATCH 3/4] btrfs-progs: check: Fix lowmem false alert on tree reloc tree Qu Wenruo
2016-12-05  9:07 ` [PATCH 4/4] btrfs-progs: check: Fix false alert on generation mismatch for " Qu Wenruo
2016-12-14 13:15 ` [PATCH 0/4] Lowmem fsck false alert fixes David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161205090756.7960-2-quwenruo@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.