From: Jouni Malinen <j@w1.fi> To: Jean-Pierre Tosoni <jp.tosoni@acksys.fr> Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Cedric VONCKEN <cedric.voncken@acksys.fr> Subject: Re: ath10k firmware sends probes on DFS channels without radar detection Date: Wed, 14 Dec 2016 21:58:05 +0200 [thread overview] Message-ID: <20161214195805.GA15022@w1.fi> (raw) In-Reply-To: <004a01d24fe2$94da8dc0$be8fa940$@acksys.fr> On Tue, Dec 06, 2016 at 06:02:52PM +0100, Jean-Pierre Tosoni wrote: > This follows on the previous discussion > "Client station sends probes on DFS channels" > > Problem: > The combination of QCA988X firmware v10.2.4.70-2 + ath10k + > wpa_supplicant do not comply with the norm ETSI/EN 301-893 > section 4.7; because they can send probes for 600s when no > AP is around. > > Analysis: > The problem seems to lie in the firmware, which regards the presence > of *any* beacon as a proof that the channel is radar-clean for 600s. I don't think this is really firmware, but cfg80211 regulatory code and how it interacts with ath10k.. > - there is no obvious fix working in ath10k. > - the issue does not show up with other mac80211 devices like ath9k. > - wpa_supplicant considers this is a kernel issue [2] There seems to be a difference between ath9k (mac80211-based Probe Request frame sending) and ath10k (firmware) in this area for active scanning. mac80211 uses IEEE80211_CHAN_NO_IR | IEEE80211_CHAN_RADAR while ath10k uses IEEE80211_CHAN_NO_IR. I'd assume this difference results in ath10k using cfg80211 beacon hints (etc.) to update the NO_IR flag and that might be behind the difference you see. Could you check whether the following change gets you the behavior you want to see here? I have not had a chance to test this yet, but based on code review, it looks like something that brings the same behavior to ath10k that ath9k has for this through mac80211. diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index aa545a1..758dbbd 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2973,7 +2973,8 @@ static int ath10k_update_channel_list(struct ath10k *ar) ch->chan_radar = !!(channel->flags & IEEE80211_CHAN_RADAR); - passive = channel->flags & IEEE80211_CHAN_NO_IR; + passive = channel->flags & (IEEE80211_CHAN_NO_IR | + IEEE80211_CHAN_RADAR); ch->passive = passive; ch->freq = channel->center_freq; -- Jouni Malinen PGP id EFC895FA
WARNING: multiple messages have this Message-ID (diff)
From: Jouni Malinen <j@w1.fi> To: Jean-Pierre Tosoni <jp.tosoni@acksys.fr> Cc: linux-wireless@vger.kernel.org, Cedric VONCKEN <cedric.voncken@acksys.fr>, ath10k@lists.infradead.org Subject: Re: ath10k firmware sends probes on DFS channels without radar detection Date: Wed, 14 Dec 2016 21:58:05 +0200 [thread overview] Message-ID: <20161214195805.GA15022@w1.fi> (raw) In-Reply-To: <004a01d24fe2$94da8dc0$be8fa940$@acksys.fr> On Tue, Dec 06, 2016 at 06:02:52PM +0100, Jean-Pierre Tosoni wrote: > This follows on the previous discussion > "Client station sends probes on DFS channels" > > Problem: > The combination of QCA988X firmware v10.2.4.70-2 + ath10k + > wpa_supplicant do not comply with the norm ETSI/EN 301-893 > section 4.7; because they can send probes for 600s when no > AP is around. > > Analysis: > The problem seems to lie in the firmware, which regards the presence > of *any* beacon as a proof that the channel is radar-clean for 600s. I don't think this is really firmware, but cfg80211 regulatory code and how it interacts with ath10k.. > - there is no obvious fix working in ath10k. > - the issue does not show up with other mac80211 devices like ath9k. > - wpa_supplicant considers this is a kernel issue [2] There seems to be a difference between ath9k (mac80211-based Probe Request frame sending) and ath10k (firmware) in this area for active scanning. mac80211 uses IEEE80211_CHAN_NO_IR | IEEE80211_CHAN_RADAR while ath10k uses IEEE80211_CHAN_NO_IR. I'd assume this difference results in ath10k using cfg80211 beacon hints (etc.) to update the NO_IR flag and that might be behind the difference you see. Could you check whether the following change gets you the behavior you want to see here? I have not had a chance to test this yet, but based on code review, it looks like something that brings the same behavior to ath10k that ath9k has for this through mac80211. diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index aa545a1..758dbbd 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2973,7 +2973,8 @@ static int ath10k_update_channel_list(struct ath10k *ar) ch->chan_radar = !!(channel->flags & IEEE80211_CHAN_RADAR); - passive = channel->flags & IEEE80211_CHAN_NO_IR; + passive = channel->flags & (IEEE80211_CHAN_NO_IR | + IEEE80211_CHAN_RADAR); ch->passive = passive; ch->freq = channel->center_freq; -- Jouni Malinen PGP id EFC895FA _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-12-14 19:58 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-06 17:02 ath10k firmware sends probes on DFS channels without radar detection Jean-Pierre Tosoni 2016-12-06 17:02 ` Jean-Pierre Tosoni 2016-12-06 19:36 ` Ben Greear 2016-12-06 19:36 ` Ben Greear 2016-12-14 18:14 ` Jean-Pierre Tosoni 2016-12-14 18:14 ` Jean-Pierre Tosoni 2016-12-14 18:28 ` Ben Greear 2016-12-14 18:28 ` Ben Greear 2016-12-14 19:58 ` Jouni Malinen [this message] 2016-12-14 19:58 ` Jouni Malinen 2016-12-15 15:22 ` Jean-Pierre Tosoni 2016-12-15 15:22 ` Jean-Pierre Tosoni 2016-12-15 16:32 ` Ben Greear 2016-12-15 16:32 ` Ben Greear 2016-12-15 17:53 ` Jean-Pierre Tosoni 2016-12-15 17:53 ` Jean-Pierre Tosoni 2016-12-15 22:58 ` Jouni Malinen 2016-12-15 22:58 ` Jouni Malinen 2016-12-26 11:15 ` Jean-Pierre Tosoni 2016-12-26 11:15 ` Jean-Pierre Tosoni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161214195805.GA15022@w1.fi \ --to=j@w1.fi \ --cc=ath10k@lists.infradead.org \ --cc=cedric.voncken@acksys.fr \ --cc=jp.tosoni@acksys.fr \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.