All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org,
	Pawel Osciak <posciak@chromium.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Rob Clark <robdclark@gmail.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Laura Abbott <labbott@redhat.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: [RFC v2 01/11] vb2: Rename confusingly named internal buffer preparation functions
Date: Fri, 16 Dec 2016 03:24:15 +0200	[thread overview]
Message-ID: <20161216012425.11179-2-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <20161216012425.11179-1-laurent.pinchart+renesas@ideasonboard.com>

From: Sakari Ailus <sakari.ailus@linux.intel.com>

Rename __qbuf_*() functions which are specific to a buffer type as
__prepare_*() which matches with what they do. The naming was there for
historical reasons; the purpose of the functions was changed without
renaming them.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/v4l2-core/videobuf2-core.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index 7c1d390ea438..5379c8718010 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -956,9 +956,9 @@ void vb2_discard_done(struct vb2_queue *q)
 EXPORT_SYMBOL_GPL(vb2_discard_done);
 
 /**
- * __qbuf_mmap() - handle qbuf of an MMAP buffer
+ * __prepare_mmap() - prepare an MMAP buffer
  */
-static int __qbuf_mmap(struct vb2_buffer *vb, const void *pb)
+static int __prepare_mmap(struct vb2_buffer *vb, const void *pb)
 {
 	int ret = 0;
 
@@ -969,9 +969,9 @@ static int __qbuf_mmap(struct vb2_buffer *vb, const void *pb)
 }
 
 /**
- * __qbuf_userptr() - handle qbuf of a USERPTR buffer
+ * __prepare_userptr() - prepare a USERPTR buffer
  */
-static int __qbuf_userptr(struct vb2_buffer *vb, const void *pb)
+static int __prepare_userptr(struct vb2_buffer *vb, const void *pb)
 {
 	struct vb2_plane planes[VB2_MAX_PLANES];
 	struct vb2_queue *q = vb->vb2_queue;
@@ -1086,9 +1086,9 @@ static int __qbuf_userptr(struct vb2_buffer *vb, const void *pb)
 }
 
 /**
- * __qbuf_dmabuf() - handle qbuf of a DMABUF buffer
+ * __prepare_dmabuf() - prepare a DMABUF buffer
  */
-static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb)
+static int __prepare_dmabuf(struct vb2_buffer *vb, const void *pb)
 {
 	struct vb2_plane planes[VB2_MAX_PLANES];
 	struct vb2_queue *q = vb->vb2_queue;
@@ -1253,13 +1253,13 @@ static int __buf_prepare(struct vb2_buffer *vb, const void *pb)
 
 	switch (q->memory) {
 	case VB2_MEMORY_MMAP:
-		ret = __qbuf_mmap(vb, pb);
+		ret = __prepare_mmap(vb, pb);
 		break;
 	case VB2_MEMORY_USERPTR:
-		ret = __qbuf_userptr(vb, pb);
+		ret = __prepare_userptr(vb, pb);
 		break;
 	case VB2_MEMORY_DMABUF:
-		ret = __qbuf_dmabuf(vb, pb);
+		ret = __prepare_dmabuf(vb, pb);
 		break;
 	default:
 		WARN(1, "Invalid queue type\n");
-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2016-12-16  1:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16  1:24 [RFC v2 00/11] vb2: Handle user cache hints, allow drivers to choose cache coherency Laurent Pinchart
2016-12-16  1:24 ` Laurent Pinchart
2016-12-16  1:24 ` Laurent Pinchart [this message]
2016-12-16  1:24 ` [RFC v2 02/11] vb2: Move buffer cache synchronisation to prepare from queue Laurent Pinchart
2016-12-16  1:24 ` [RFC v2 03/11] vb2: Move cache synchronisation from buffer done to dqbuf handler Laurent Pinchart
2017-03-27 21:27   ` Shuah Khan
2017-03-28 12:31     ` Laurent Pinchart
2017-03-28 12:31       ` Laurent Pinchart
2016-12-16  1:24 ` [RFC v2 04/11] v4l: Unify cache management hint buffer flags Laurent Pinchart
2016-12-16  1:24 ` [RFC v2 05/11] v4l2-core: Don't sync cache for a buffer if so requested Laurent Pinchart
2017-03-27 22:08   ` Shuah Khan
2016-12-16  1:24 ` [RFC v2 06/11] vb2: Improve struct vb2_mem_ops documentation; alloc and put are for MMAP Laurent Pinchart
2016-12-16  1:24 ` [RFC v2 07/11] vb2: dma-contig: Remove redundant sgt_base field Laurent Pinchart
2017-03-27 22:51   ` Shuah Khan
2017-04-07 12:37     ` Sakari Ailus
2016-12-16  1:24 ` [RFC v2 08/11] vb2: dma-contig: Don't warn on failure in obtaining scatterlist Laurent Pinchart
2016-12-16  1:24   ` Laurent Pinchart
2016-12-16  1:24 ` [RFC v2 09/11] vb2: dma-contig: Move vb2_dc_get_base_sgt() up Laurent Pinchart
2016-12-16  1:24 ` [RFC v2 10/11] vb2: dma-contig: Let drivers decide DMA attrs of MMAP and USERPTR bufs Laurent Pinchart
2016-12-26  7:58   ` [RFC, v2, " Ricky Liang
2017-04-05 13:13     ` Sakari Ailus
2017-04-07 11:42     ` Laurent Pinchart
2016-12-16  1:24 ` [RFC v2 11/11] vb2: dma-contig: Add WARN_ON_ONCE() to check for potential bugs Laurent Pinchart
2016-12-16 12:06 ` [RFC v2 00/11] vb2: Handle user cache hints, allow drivers to choose cache coherency Hans Verkuil
2016-12-16 12:06   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161216012425.11179-2-laurent.pinchart+renesas@ideasonboard.com \
    --to=laurent.pinchart+renesas@ideasonboard.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil@xs4all.nl \
    --cc=kyungmin.park@samsung.com \
    --cc=labbott@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=posciak@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.