All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Daniel Vetter" <daniel.vetter@intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
	"Wolfram Sang" <wsa@the-dreams.de>, "Len Brown" <lenb@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel@lists.freedesktop.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Takashi Iwai <tiwai@suse.de>,
	"russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
	linux-i2c@vger.kernel.org
Subject: [PATCH 3/7] i2c: designware-baytrail: Take punit lock on bus acquire
Date: Sun,  8 Jan 2017 14:44:23 +0100	[thread overview]
Message-ID: <20170108134427.8392-4-hdegoede@redhat.com> (raw)
In-Reply-To: <20170108134427.8392-1-hdegoede@redhat.com>

Take the punit lock to stop others from accessing the punit while the
pmic i2c bus is in use. This is necessary because accessing the punit
from the kernel may result in the punit trying to access the pmic i2c
bus, which results in a hang when it happens while we own the pmic i2c
bus semaphore.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=155241
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: tagorereddy <tagore.chandan@gmail.com>
---
 drivers/i2c/busses/i2c-designware-baytrail.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/i2c/busses/i2c-designware-baytrail.c b/drivers/i2c/busses/i2c-designware-baytrail.c
index 3effc9a..cf7a2a0 100644
--- a/drivers/i2c/busses/i2c-designware-baytrail.c
+++ b/drivers/i2c/busses/i2c-designware-baytrail.c
@@ -62,6 +62,8 @@ static void reset_semaphore(struct dw_i2c_dev *dev)
 		dev_err(dev->dev, "iosf failed to reset punit semaphore during write\n");
 
 	pm_qos_update_request(&dev->pm_qos, PM_QOS_DEFAULT_VALUE);
+
+	iosf_mbi_punit_unlock();
 }
 
 static int baytrail_i2c_acquire(struct dw_i2c_dev *dev)
@@ -79,6 +81,8 @@ static int baytrail_i2c_acquire(struct dw_i2c_dev *dev)
 	if (!dev->release_lock)
 		return 0;
 
+	iosf_mbi_punit_lock();
+
 	/*
 	 * Disallow the CPU to enter C6 or C7 state, entering these states
 	 * requires the punit to talk to the pmic and if this happens while
-- 
2.9.3

  parent reply	other threads:[~2017-01-08 13:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-08 13:44 [PATCH 0/7] coordinate cht i2c-pmic and i915-punit accesses Hans de Goede
2017-01-08 13:44 ` [PATCH 1/7] x86/platform/intel/iosf_mbi: Add a mutex for punit access Hans de Goede
2017-01-08 15:16   ` Andy Shevchenko
2017-01-08 15:30     ` Hans de Goede
2017-01-08 15:35       ` Andy Shevchenko
2017-01-08 13:44 ` [PATCH 2/7] x86/platform/intel/iosf_mbi: Add a pmic bus access notifier Hans de Goede
2017-01-08 15:21   ` Andy Shevchenko
2017-01-08 13:44 ` Hans de Goede [this message]
2017-01-08 15:27   ` [PATCH 3/7] i2c: designware-baytrail: Take punit lock on bus acquire Andy Shevchenko
2017-01-08 15:39     ` Hans de Goede
2017-01-12 18:45   ` Wolfram Sang
2017-01-15 11:21     ` Hans de Goede
2017-01-15 11:45       ` Wolfram Sang
2017-01-15 15:11         ` Hans de Goede
2017-01-15 15:17           ` Wolfram Sang
2017-01-08 13:44 ` [PATCH 4/7] i2c: designware-baytrail: Call pmic_bus_access_notifier_chain Hans de Goede
2017-01-08 15:23   ` Andy Shevchenko
2017-01-12 18:45   ` Wolfram Sang
2017-01-08 13:44 ` [PATCH 5/7] drm/i915: Add intel_uncore_suspend / resume functions Hans de Goede
2017-01-08 13:44 ` [PATCH 6/7] drm/i915: Listen for pmic bus access notifications Hans de Goede
2017-01-08 13:44 ` [PATCH 7/7] drm/i915: Take punit lock when modifying punit settings Hans de Goede
2017-01-08 15:34   ` Andy Shevchenko
2017-01-08 15:42     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170108134427.8392-4-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=russianneuromancer@ya.ru \
    --cc=tiwai@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.