From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
Cc: linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org,
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6] DAX: enable iostat for read/write
Date: Fri, 13 Jan 2017 14:54:06 -0800 [thread overview]
Message-ID: <20170113145406.b1f065fb7fda67fd18830969@linux-foundation.org> (raw)
In-Reply-To: <20170113233418.32252-1-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
On Fri, 13 Jan 2017 16:34:18 -0700 Toshi Kani <toshi.kani-ZPxbGqLxI0U@public.gmane.org> wrote:
> DAX IO path does not support iostat, but its metadata IO path does.
> Therefore, iostat shows metadata IO statistics only, which has been
> confusing to users.
>
> Add iostat support to the DAX read/write path.
>
> Note, iostat still does not support the DAX mmap path as it allows
> user applications to access directly.
>
> ...
>
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1058,12 +1058,24 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter,
> {
> struct address_space *mapping = iocb->ki_filp->f_mapping;
> struct inode *inode = mapping->host;
> + struct gendisk *disk = inode->i_sb->s_bdev->bd_disk;
> loff_t pos = iocb->ki_pos, ret = 0, done = 0;
> unsigned flags = 0;
> + unsigned long start = 0;
> + int do_acct = blk_queue_io_stat(disk->queue);
(The poorly named) blk_queue_io_stat() actually returns a bool. This
is well concealed because blk_queue_io_stat() is unnecessarily
implemented as a macro (why oh why).
--- a/fs/dax.c~dax-enable-iostat-for-read-write-fix
+++ a/fs/dax.c
@@ -1085,7 +1085,7 @@ dax_iomap_rw(struct kiocb *iocb, struct
loff_t pos = iocb->ki_pos, ret = 0, done = 0;
unsigned flags = 0;
unsigned long start = 0;
- int do_acct = blk_queue_io_stat(disk->queue);
+ bool do_acct = blk_queue_io_stat(disk->queue);
if (iov_iter_rw(iter) == WRITE)
flags |= IOMAP_WRITE;
_
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: dan.j.williams@intel.com, david@fromorbit.com,
viro@zeniv.linux.org.uk, ross.zwisler@linux.intel.com,
linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v6] DAX: enable iostat for read/write
Date: Fri, 13 Jan 2017 14:54:06 -0800 [thread overview]
Message-ID: <20170113145406.b1f065fb7fda67fd18830969@linux-foundation.org> (raw)
In-Reply-To: <20170113233418.32252-1-toshi.kani@hpe.com>
On Fri, 13 Jan 2017 16:34:18 -0700 Toshi Kani <toshi.kani@hpe.com> wrote:
> DAX IO path does not support iostat, but its metadata IO path does.
> Therefore, iostat shows metadata IO statistics only, which has been
> confusing to users.
>
> Add iostat support to the DAX read/write path.
>
> Note, iostat still does not support the DAX mmap path as it allows
> user applications to access directly.
>
> ...
>
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1058,12 +1058,24 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter,
> {
> struct address_space *mapping = iocb->ki_filp->f_mapping;
> struct inode *inode = mapping->host;
> + struct gendisk *disk = inode->i_sb->s_bdev->bd_disk;
> loff_t pos = iocb->ki_pos, ret = 0, done = 0;
> unsigned flags = 0;
> + unsigned long start = 0;
> + int do_acct = blk_queue_io_stat(disk->queue);
(The poorly named) blk_queue_io_stat() actually returns a bool. This
is well concealed because blk_queue_io_stat() is unnecessarily
implemented as a macro (why oh why).
--- a/fs/dax.c~dax-enable-iostat-for-read-write-fix
+++ a/fs/dax.c
@@ -1085,7 +1085,7 @@ dax_iomap_rw(struct kiocb *iocb, struct
loff_t pos = iocb->ki_pos, ret = 0, done = 0;
unsigned flags = 0;
unsigned long start = 0;
- int do_acct = blk_queue_io_stat(disk->queue);
+ bool do_acct = blk_queue_io_stat(disk->queue);
if (iov_iter_rw(iter) == WRITE)
flags |= IOMAP_WRITE;
_
next prev parent reply other threads:[~2017-01-13 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 23:34 [PATCH v6] DAX: enable iostat for read/write Toshi Kani
2017-01-13 23:34 ` Toshi Kani
2017-01-13 23:34 ` Toshi Kani
[not found] ` <20170113233418.32252-1-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
2017-01-13 22:54 ` Andrew Morton [this message]
2017-01-13 22:54 ` Andrew Morton
[not found] ` <20170113145406.b1f065fb7fda67fd18830969-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2017-01-13 23:09 ` Kani, Toshimitsu
2017-01-13 23:09 ` Kani, Toshimitsu
[not found] ` <1484352338.2029.7.camel-ZPxbGqLxI0U@public.gmane.org>
2017-01-13 23:16 ` Andrew Morton
2017-01-13 23:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113145406.b1f065fb7fda67fd18830969@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \
--cc=toshi.kani-ZPxbGqLxI0U@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.