All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: <linux-fsdevel@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-block@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: [PATCH 05/24] fs: Get proper reference for s_bdi
Date: Thu,  2 Feb 2017 18:34:03 +0100	[thread overview]
Message-ID: <20170202173422.3240-6-jack@suse.cz> (raw)
In-Reply-To: <20170202173422.3240-1-jack@suse.cz>

So far we just relied on block device to hold a bdi reference for us
while the filesystem is mounted. While that works perfectly fine, it is
a bit awkward that we have a pointer to a refcounted structure in the
superblock without proper reference. So make s_bdi hold a proper
reference to block device's BDI. No filesystem using mount_bdev()
actually changes s_bdi so this is safe and will make bdev filesystems
work the same way as filesystems needing to set up their private bdi.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/super.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/super.c b/fs/super.c
index 31dc4c6450ef..dfb95ccd4351 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -1047,12 +1047,9 @@ static int set_bdev_super(struct super_block *s, void *data)
 {
 	s->s_bdev = data;
 	s->s_dev = s->s_bdev->bd_dev;
+	s->s_bdi = bdi_get(s->s_bdev->bd_bdi);
+	s->s_iflags |= SB_I_DYNBDI;
 
-	/*
-	 * We set the bdi here to the queue backing, file systems can
-	 * overwrite this in ->fill_super()
-	 */
-	s->s_bdi = bdev_get_queue(s->s_bdev)->backing_dev_info;
 	return 0;
 }
 
-- 
2.10.2

  parent reply	other threads:[~2017-02-02 17:34 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 17:33 [PATCH 0/24 RFC] fs: Convert all embedded bdis into separate ones Jan Kara
2017-02-02 17:33 ` [Cluster-devel] " Jan Kara
2017-02-02 17:33 ` [lustre-devel] " Jan Kara
2017-02-02 17:33 ` Jan Kara
2017-02-02 17:33 ` Jan Kara
2017-02-02 17:33 ` Jan Kara
2017-02-02 17:33 ` [PATCH 01/24] block: Provide bdi_alloc() Jan Kara
2017-02-02 17:34 ` [PATCH 02/24] bdi: Provide bdi_register_va() Jan Kara
2017-02-02 17:34 ` [PATCH 03/24] block: Unregister bdi on last reference drop Jan Kara
2017-02-02 17:34 ` [PATCH 04/24] fs: Provide infrastructure for dynamic BDIs in filesystems Jan Kara
2017-02-02 17:34   ` [Cluster-devel] " Jan Kara
2017-02-02 17:34   ` [lustre-devel] " Jan Kara
2017-02-02 17:34   ` Jan Kara
2017-02-02 17:34   ` Jan Kara
2017-02-02 19:28   ` Liu Bo
2017-02-02 19:28     ` [Cluster-devel] " Liu Bo
2017-02-03 13:50     ` Jan Kara
2017-02-03 13:50       ` [Cluster-devel] " Jan Kara
2017-02-03 13:50       ` [lustre-devel] " Jan Kara
2017-02-03 18:31       ` Liu Bo
2017-02-03 18:31         ` [Cluster-devel] " Liu Bo
2017-02-03 18:31         ` Liu Bo
2017-02-08  0:38   ` [lustre-devel] " Dilger, Andreas
2017-02-08  0:38     ` [Cluster-devel] " Dilger, Andreas
2017-02-08  0:38     ` Dilger, Andreas
2017-02-08  0:38     ` Dilger, Andreas
2017-02-08  0:38     ` Dilger, Andreas
2017-02-08  0:38     ` [lustre-devel] " Dilger, Andreas
2017-02-09 12:12     ` Jan Kara
2017-02-09 12:12       ` [Cluster-devel] " Jan Kara
2017-02-09 12:12       ` Jan Kara
2017-02-09 12:12       ` Jan Kara
2017-02-09 12:12       ` Jan Kara
2017-02-09 12:12       ` Jan Kara
2017-02-09 12:12       ` [lustre-devel] " Jan Kara
2017-02-02 17:34 ` Jan Kara [this message]
2017-02-09 14:36   ` [PATCH 05/24] fs: Get proper reference for s_bdi Boaz Harrosh
2017-02-09 15:52     ` Jan Kara
2017-02-02 17:34 ` [PATCH 06/24] lustre: Convert to separately allocated bdi Jan Kara
2017-02-02 17:34   ` [lustre-devel] " Jan Kara
2017-02-08  0:38   ` Dilger, Andreas
2017-02-08  0:38     ` Dilger, Andreas
2017-02-02 17:34 ` [PATCH 07/24] 9p: " Jan Kara
2017-02-02 17:34 ` [PATCH 08/24] btrfs: " Jan Kara
2017-02-03 18:33   ` Liu Bo
2017-02-08 15:22   ` David Sterba
2017-02-02 17:34 ` [PATCH 09/24] ceph: " Jan Kara
2017-02-02 17:34   ` Jan Kara
2017-02-02 17:34 ` [PATCH 10/24] cifs: " Jan Kara
2017-02-02 17:34 ` [PATCH 11/24] ecryptfs: " Jan Kara
2017-02-02 17:34   ` Jan Kara
2017-02-03 23:54   ` Tyler Hicks
2017-02-02 17:34 ` [PATCH 12/24] afs: " Jan Kara
2017-02-02 17:34 ` [PATCH 13/24] orangefs: Remove orangefs_backing_dev_info Jan Kara
2017-02-02 17:34 ` [PATCH 14/24] mtd: Convert to dynamically allocated bdi infrastructure Jan Kara
2017-02-02 17:34 ` [PATCH 15/24] coda: Convert to separately allocated bdi Jan Kara
2017-02-02 17:34 ` [PATCH 16/24] exofs: " Jan Kara
2017-02-09 14:23   ` Boaz Harrosh
2017-02-02 17:34 ` [PATCH 17/24] fuse: " Jan Kara
2017-02-07  9:16   ` Miklos Szeredi
2017-02-07 11:35     ` Jan Kara
2017-02-02 17:34 ` [PATCH 18/24] gfs2: Convert to properly refcounting bdi Jan Kara
2017-02-02 17:34   ` [Cluster-devel] " Jan Kara
2017-02-02 17:34 ` [PATCH 19/24] nilfs2: " Jan Kara
2017-02-02 17:34   ` Jan Kara
2017-02-02 17:34 ` [PATCH 20/24] ncpfs: Convert to separately allocated bdi Jan Kara
2017-02-02 17:34 ` [PATCH 21/24] nfs: " Jan Kara
2017-02-02 17:34 ` [PATCH 22/24] ubifs: " Jan Kara
2017-02-02 20:34   ` Richard Weinberger
2017-02-03 13:45     ` Jan Kara
2017-02-08 11:24   ` Richard Weinberger
2017-02-09 12:17     ` Jan Kara
2017-02-09 14:56       ` Richard Weinberger
2017-02-02 17:34 ` [PATCH 23/24] fs: Remove SB_I_DYNBDI flag Jan Kara
2017-02-02 17:34 ` [PATCH 24/24] block: Remove unused functions Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170202173422.3240-6-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.