All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, linux-mips@linux-mips.org,
	linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	target-devel@vger.kernel.org
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Derek Chickles <derek.chickles@caviumnetworks.com>,
	Felix Manlunas <felix.manlunas@caviumnetworks.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Jiri Slaby <jirislaby@gmail.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Satanand Burla <satananda.burla@caviumnetworks.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Timur Tabi <timur@codeaurora.org>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	Woojung Huh <woojung.huh@microchip.com>
Subject: [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*()
Date: Tue,  7 Feb 2017 15:03:02 -0800	[thread overview]
Message-ID: <20170207230305.18222-10-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

From: Russell King <rmk+kernel@armlinux.org.uk>

octeon-platform.c can not be built as a module for two reasons:

(a) the Makefile doesn't allow it:
    obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o

(b) the multiple *_initcall() statements, each of which are translated
    to a module_init() call when attempting a module build, become
    aliases to init_module().  Having more than one alias will cause a
    build error.

Hence, rather than adding a linux/module.h include, remove the redundant
MODULE_*() from this file.

Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/mips/cavium-octeon/octeon-platform.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
index 37a932d9148c..8297ce714c5e 100644
--- a/arch/mips/cavium-octeon/octeon-platform.c
+++ b/arch/mips/cavium-octeon/octeon-platform.c
@@ -1060,7 +1060,3 @@ static int __init octeon_publish_devices(void)
 	return of_platform_bus_probe(NULL, octeon_ids, NULL);
 }
 arch_initcall(octeon_publish_devices);
-
-MODULE_AUTHOR("David Daney <ddaney@caviumnetworks.com>");
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Platform driver for Octeon SOC");
-- 
2.9.3

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, linux-mips@linux-mips.org,
	linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	target-devel@vger.kernel.org
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Derek Chickles <derek.chickles@caviumnetworks.com>,
	Felix Manlunas <felix.manlunas@caviumnetworks.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Jiri Slaby <jirislaby@gmail.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Raghu Vatsavayi <raghu.vatsavay
Subject: [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*()
Date: Tue,  7 Feb 2017 15:03:02 -0800	[thread overview]
Message-ID: <20170207230305.18222-10-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

From: Russell King <rmk+kernel@armlinux.org.uk>

octeon-platform.c can not be built as a module for two reasons:

(a) the Makefile doesn't allow it:
    obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o

(b) the multiple *_initcall() statements, each of which are translated
    to a module_init() call when attempting a module build, become
    aliases to init_module().  Having more than one alias will cause a
    build error.

Hence, rather than adding a linux/module.h include, remove the redundant
MODULE_*() from this file.

Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/mips/cavium-octeon/octeon-platform.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
index 37a932d9148c..8297ce714c5e 100644
--- a/arch/mips/cavium-octeon/octeon-platform.c
+++ b/arch/mips/cavium-octeon/octeon-platform.c
@@ -1060,7 +1060,3 @@ static int __init octeon_publish_devices(void)
 	return of_platform_bus_probe(NULL, octeon_ids, NULL);
 }
 arch_initcall(octeon_publish_devices);
-
-MODULE_AUTHOR("David Daney <ddaney@caviumnetworks.com>");
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Platform driver for Octeon SOC");
-- 
2.9.3

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org, linux-mips@linux-mips.org,
	linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	target-devel@vger.kernel.org
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Derek Chickles <derek.chickles@caviumnetworks.com>,
	Felix Manlunas <felix.manlunas@caviumnetworks.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Jiri Slaby <jirislaby@gmail.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	Madalin Bucur <madalin.bucur@nxp.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	Nick Kossifidis <mickflemm@gmail.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Raghu Vatsavayi <raghu.vatsavay>
Subject: [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*()
Date: Tue,  7 Feb 2017 15:03:02 -0800	[thread overview]
Message-ID: <20170207230305.18222-10-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

From: Russell King <rmk+kernel@armlinux.org.uk>

octeon-platform.c can not be built as a module for two reasons:

(a) the Makefile doesn't allow it:
    obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o

(b) the multiple *_initcall() statements, each of which are translated
    to a module_init() call when attempting a module build, become
    aliases to init_module().  Having more than one alias will cause a
    build error.

Hence, rather than adding a linux/module.h include, remove the redundant
MODULE_*() from this file.

Acked-by: David Daney <david.daney@cavium.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/mips/cavium-octeon/octeon-platform.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
index 37a932d9148c..8297ce714c5e 100644
--- a/arch/mips/cavium-octeon/octeon-platform.c
+++ b/arch/mips/cavium-octeon/octeon-platform.c
@@ -1060,7 +1060,3 @@ static int __init octeon_publish_devices(void)
 	return of_platform_bus_probe(NULL, octeon_ids, NULL);
 }
 arch_initcall(octeon_publish_devices);
-
-MODULE_AUTHOR("David Daney <ddaney@caviumnetworks.com>");
-MODULE_LICENSE("GPL");
-MODULE_DESCRIPTION("Platform driver for Octeon SOC");
-- 
2.9.3

  parent reply	other threads:[~2017-02-07 23:05 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 23:02 [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 02/12] net: cgroups: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 03/12] net: macb: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 04/12] net: lan78xx: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 05/12] net: bgmac: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 06/12] net: fman: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 07/12] net: mvneta: " Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 08/12] iscsi: " Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-08  4:53   ` Nicholas A. Bellinger
2017-02-08  4:53     ` Nicholas A. Bellinger
2017-02-07 23:03 ` Florian Fainelli [this message]
2017-02-07 23:03   ` [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*() Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 10/12] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 11/12] net: ath5k: " Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-08 16:06 ` [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include David Miller
2017-02-08 16:06   ` David Miller
2017-02-08 16:06   ` David Miller
2017-02-08 16:11   ` Kalle Valo
2017-02-08 16:11     ` Kalle Valo
2017-02-08 16:11     ` Kalle Valo
2017-02-08 19:45     ` Florian Fainelli
2017-02-09 14:10       ` Kalle Valo
2017-02-09 14:10         ` Kalle Valo
2017-02-09 14:10         ` Kalle Valo
2017-02-10 18:51         ` David Miller
2017-02-10 18:51           ` David Miller
2017-02-10 18:51           ` David Miller
2017-02-10 19:44           ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207230305.18222-10-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=davem@davemloft.net \
    --cc=derek.chickles@caviumnetworks.com \
    --cc=felix.manlunas@caviumnetworks.com \
    --cc=jirislaby@gmail.com \
    --cc=jlayton@poochiereds.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=mcgrof@do-not-panic.com \
    --cc=mickflemm@gmail.com \
    --cc=nab@linux-iscsi.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=raghu.vatsavayi@caviumnetworks.com \
    --cc=ralf@linux-mips.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=satananda.burla@caviumnetworks.com \
    --cc=target-devel@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=timur@codeaurora.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.